From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes Date: Wed, 17 Feb 2021 21:20:24 -0800 Message-ID: References: <20210213141225.11309.86562@vcs0.savannah.gnu.org> <20210213141226.EEDFE20999@vcs0.savannah.gnu.org> <47209379-76df-4c97-e5ff-b3b04da0db1d@yandex.ru> <87zh07of0e.fsf@gnus.org> <0605ed62-a785-d190-caf2-2232e1db3b0f@yandex.ru> <87mtw6d480.fsf@gnus.org> <87eehid3k2.fsf@gnus.org> <87r1liblzb.fsf@gnus.org> <87czwy1mu2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19617"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Dmitry Gutov , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 18 06:21:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCbkZ-0004zw-1T for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 06:21:15 +0100 Original-Received: from localhost ([::1]:52896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCbkY-0003tM-41 for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 00:21:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCbjn-0003NU-HZ for emacs-devel@gnu.org; Thu, 18 Feb 2021 00:20:27 -0500 Original-Received: from mail-pg1-f172.google.com ([209.85.215.172]:34870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCbjm-0005m2-3Q for emacs-devel@gnu.org; Thu, 18 Feb 2021 00:20:27 -0500 Original-Received: by mail-pg1-f172.google.com with SMTP id t25so453900pga.2 for ; Wed, 17 Feb 2021 21:20:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=G4p5CqMiZeNCxa5GRBbVUzP1G9r2WfWlP7748eR0dPM=; b=mH9keabjMUpG51Wsvmvv2LZrMtL8FdqzNoxrKuyIC+RmD6j9SzI/QsLHYL4hb1aXkA F9+jdzziNU29l0DnD8PLa0tz34J60Zw0HV5h/bX2zpMeUZlvOb/BsM6yGHLT39+qVBCF Ok/PaNwKmJIL+oDXRfwaT/3UStUi/ri4OKoei179nVmznTciKJ+WbBcRlu8ESPhGJx3v MzrmGSKhjhZdTa4eI1DgCR/iZAI3VdnqL66piC+u8jHeG6hX4ysSk4lAFbYIFsDJmZuk fWXiuHHXt7mRF4dxw8o6ohd6wx7wQDs2wYQ5ZGf6087j05mtdfebViYOgPJaXJwFf1id YToQ== X-Gm-Message-State: AOAM530tP9VL84qNd4facbFNOidudQk3pegMDFPVfHDJD7XOBn+vIbIT ChdnO1p7s63sFOK7DwGmHamXk+ZhsBdAgUrsYKA= X-Google-Smtp-Source: ABdhPJxOrYai2p1c9X7gDMYOVLcoij6QCP9ez+Fc0TeDgENcRwrbopnQIrNaApDHDhHswjoG3mDVkkzpoWY4etb01Cw= X-Received: by 2002:a63:6384:: with SMTP id x126mr2522084pgb.345.1613625624640; Wed, 17 Feb 2021 21:20:24 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 17 Feb 2021 21:20:24 -0800 In-Reply-To: Received-SPF: pass client-ip=209.85.215.172; envelope-from=stefankangas@gmail.com; helo=mail-pg1-f172.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265124 Archived-At: Stefan Monnier writes: >>>> Please find attached a patch. >>> >>> Hm... trying this out now, I don't think the compat macro solution >>> actually works. That is, it works fine when byte-compiled, but not in >>> non-compiled code. The reason for this is that `interactive-form' just >>> does a `Fassq' on the Lisp form and looks for the Qinteractive symbol. >>> Which is won't find if the symbol in `future-interactive'. >> >> It is working for me in Emacs 27, and it was working for me at the time >> when I wrote it (both byte-compiled and interpreted). >> >> I test by evaluating this in "emacs -Q": > > The key here is *how* you are "evaluating", since this will determine > whether eager-macroexpansion took place or not (if it did, the code > should work, but if it didn't, it probably won't). Sorry, I used `eval-defun' in the above test. I quickly tried it with `load-file' on the uncompiled .el in Emacs 27, and it also seems to work as expected. Is there anything else I should test in addition to that?