From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: JIANG Shaojian Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Interferences between xwidgets and async processes? Date: Tue, 17 Aug 2021 23:09:38 +0800 Message-ID: References: <87mu06wyfb.fsf@gnus.org> <83tuuecrl5.fsf@gnu.org> <83v9etaz6z.fsf@gnu.org> <86sg9nsg5a.fsf@akirakyle.com> <87pn4mmybt.fsf@gnus.org> <86h7putm1q.fsf@akirakyle.com> <87sg9cymdw.fsf@gnus.org> <83blfzvrh0.fsf@gnu.org> <86blfzu34m.fsf@akirakyle.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000083eff105c9c2b58b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13566"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Lars Ingebrigtsen , emacs-devel@gnu.org To: Akira Kyle Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 17 17:10:51 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mG0jo-0003Cv-5e for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Aug 2021 17:10:48 +0200 Original-Received: from localhost ([::1]:51218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mG0jm-0000ak-7u for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Aug 2021 11:10:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mG0ix-00085b-6C for emacs-devel@gnu.org; Tue, 17 Aug 2021 11:09:55 -0400 Original-Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:38579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mG0it-0006Qq-Uc; Tue, 17 Aug 2021 11:09:54 -0400 Original-Received: by mail-oi1-x234.google.com with SMTP id u25so32345947oiv.5; Tue, 17 Aug 2021 08:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RzP+fxV9xWPHDz2xjwbs75KbqgNKvczpG8Yc0TF/qS4=; b=fUtp/UPD7CIIFFH/VHOTYgiPXTaf30eh6XzNFAX0e+xCf+OlgyADpSGjUNzxP4FWjX CZp0Fykwy2HxuA0A/ilo5FIrCeGJHRq/v8VtSO51uUYyF62h1V3R4VfOA4rNSiFtYEqs aw/SxNnr20JkkfT8lvrCDIDnKlhMKrOO4kRApLjoibIyCiKTHIpahdpWWM378Ahs1u75 q6+6EJSPTvXMy4J+vDB4l42z/E5kLiz/uwkzdsvUruM7n5kWgPa9osE/YFDEgCfGFpp9 Ug/6CBhthk3mjW+Cy3FOOnP4r1DVGC8CWjomuJPLg3ThgKrvS8eGC45O5Arr26T7ZmFm BgnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RzP+fxV9xWPHDz2xjwbs75KbqgNKvczpG8Yc0TF/qS4=; b=hPG8EyUg2dH3oDHU3KtX4MNhpNEAsxIZ9I6cLhwfmNoKjDGI8QfFxl+SmNXPSWVrLp edQQPx9+Yt0GGHE/oiM9oBXEmuoolQWDz75Kr4sauwI7rFurOXWpmAZpJ0o3pztZoLwj GQLCtJ2x0w3Baw4bg8dFE0zT4msGaBVHO7Cd5PgH5kxz/G9yVmN1IVIP1izZwluVDNMR ZNDUtoqfKkJH8MFHhlvre06G5n8y8kg7EbVW5PnqbpeTfa3/4OYAfYg7xeXT5+Joirtv /to1pZEKSbHARGiwMFARlarqJ+nHg1C8LllwlIorTZTNa0Hd8/9C8JRxRjy30bMU0hPy guhQ== X-Gm-Message-State: AOAM533syUK+hKL/2Gf6a+y6UAKFDIKYK0uLCJGURGDELJ5riCrqkbhP NfQzkvTNttGKFecculX4O5x7DAZdQD/h9fuhoug= X-Google-Smtp-Source: ABdhPJzLjD5JpzvG5V7qSM8YSuhc/+Hm6NPfLk3nTMhOEUYkkdxb566fOzUfWTxVNLDB3T/lqstEP+HJxec1lNQZSIs= X-Received: by 2002:a05:6808:d:: with SMTP id u13mr2907391oic.91.1629212989713; Tue, 17 Aug 2021 08:09:49 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=sdycjsj@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272494 Archived-At: --00000000000083eff105c9c2b58b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, WIth previous patch, I just noticed a message generated by xwidget saying "Overriding existing handler for signal 10. Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different signal". I did a bit of search and found out that this might be related to a recent version of libwebkit2gtk (see a similar message in https://github.com/vertcoin-project/one-click-miner-vnext/issues/271). The current version of the library on my ubuntu is 2.32. I tried to downgrade it to an earlier version available, which is 2.28 and the issue is gone. So it seems that the updated library breaks previous fix. Further debugging is beyond my expertise. Hopefully the above information is useful. Thanks. JIANG Shaojian =E4=BA=8E2021=E5=B9=B47=E6=9C=8830=E6=97= =A5=E5=91=A8=E4=BA=94 =E4=B8=8A=E5=8D=8810:55=E5=86=99=E9=81=93=EF=BC=9A > Hi, > > I just built emacs 28 with the lasted source, and it seems that this bug > reappears. > Since I have not updated emacs for a long time, I am not sure when it cam= e > back. > I checked xwidget.c and previous fix is still there. > > The testing environment and the way to reproduce it is the same as before= . > > Hopefully someone can confirm this. > Thanks! > > > Akira Kyle =E4=BA=8E2020=E5=B9=B411=E6=9C=8815=E6=97= =A5=E5=91=A8=E6=97=A5 =E4=B8=8A=E5=8D=883:53=E5=86=99=E9=81=93=EF=BC=9A > >> >> On Sat, Nov 14, 2020 at 09:22 AM, Eli Zaretskii >> wrote: >> >> >> > The attached patch fixes this but only in a temporary way. >> >> >> >> Thanks; applied to Emacs 28. >> > >> > Just to be sure: the fix that is now installed on master does >> > support >> > current and old versions of Glib, where the old code seemed to >> > work? >> > Or does it break with older Glib versions? >> >> I didn't explicitly try it with glib versions before they changed >> the signal handling in commit 2e471acf, but it *should* work with >> versions before the change. As you can see in the patch, it >> essentially just makes Emacs more aggressive in taking over the >> signal handler and in glib versions before 2e471acf, >> g_source_unref (source) wouldn't result in glib resetting the >> signal handler to SIG_DFL, in which case Emacs will just install >> itself twice to handle SIGCHLD which is fine. >> >> I think commit 2e471acf got added to glib with version 2.37.5 >> which was released over 7 years ago. >> >> --00000000000083eff105c9c2b58b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

WIth previous patch, I just noticed= a message generated by xwidget saying "Overriding existing handler fo= r signal 10. Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different si= gnal".
I did a bit of search and found out that this might b= e related to a recent version of libwebkit2gtk (see a similar message in=C2= =A0https://github.com/vertcoin-project/one-click-miner-vnext/issues/2= 71).

The current=C2=A0version of the library o= n my ubuntu is 2.32. I tried to downgrade it to an earlier=C2=A0version ava= ilable, which is 2.28 and the issue=C2=A0is gone.=C2=A0
So it see= ms that the updated library breaks previous fix.
Further debuggin= g is beyond my expertise. Hopefully the above information is useful.
<= div>
Thanks.


JIANG Shaojian <sdycjsj@gmail.com> =E4=BA=8E2021=E5=B9= =B47=E6=9C=8830=E6=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8A=E5=8D=8810:55=E5=86=99= =E9=81=93=EF=BC=9A
Hi,=C2=A0

I just bu= ilt emacs 28 with the lasted source, and it seems that this bug reappears.<= /div>
Since I have not updated emacs for a long time, I am not sure whe= n it came back.
I checked xwidget.c and previous fix is still the= re.

The testing environment and the way to re= produce it is the same as before.

Hopefully = someone can confirm this.=C2=A0
Thanks!


Akira Kyle <ak@ak= irakyle.com> =E4=BA=8E2020=E5=B9=B411=E6=9C=8815=E6=97=A5=E5=91=A8= =E6=97=A5 =E4=B8=8A=E5=8D=883:53=E5=86=99=E9=81=93=EF=BC=9A

On Sat, Nov 14, 2020 at 09:22 AM, Eli Zaretskii <eliz@gnu.org>
wrote:

>> > The attached patch fixes this but only in a temporary way. >>
>> Thanks; applied to Emacs 28.
>
> Just to be sure: the fix that is now installed on master does
> support
> current and old versions of Glib, where the old code seemed to
> work?
> Or does it break with older Glib versions?

I didn't explicitly try it with glib versions before they changed
the signal handling in commit 2e471acf, but it *should* work with
versions before the change. As you can see in the patch, it
essentially just makes Emacs more aggressive in taking over the
signal handler and in glib versions before 2e471acf,
g_source_unref (source) wouldn't result in glib resetting the
signal handler to SIG_DFL, in which case Emacs will just install
itself twice to handle SIGCHLD which is fine.

I think commit 2e471acf got added to glib with version 2.37.5
which was released over 7 years ago.

--00000000000083eff105c9c2b58b--