From: "Elias Mårtenson" <lokedhs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: custom-set-variables considered harmful
Date: Fri, 24 Nov 2017 15:04:22 +0800 [thread overview]
Message-ID: <CADtN0WLVyXY5WvwnhguAxR90aTQD3g5KLvSWBnVxuqpcxgmfZg@mail.gmail.com> (raw)
In-Reply-To: <jwv7euup2ql.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
On 14 November 2017 at 00:26, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> > When writing customizations, instead of writing
> >
> > (custom-set-variables
> > ;; Big ugly warning which doesn't help enough.
> > '(VAR1 VAL1)
> > '(VAR2 VAL2 nil '(REQUEST) COMMENT)
> > '(VAR3 VAL3)
> > ...)
> >
> > we write
> >
> > (autogenerated-custom-settings
> > ;; Big warning, still, but less important.
> > (setq VAR1 VAL1)
> > (require 'REQUEST)
> > (customize-set-variable VAR2 VAL2 COMMENT)
> > (customize-set-variable VAR3 VAL3)
> > ...)
>
> Here's a sample patch to do that. Comments?
>
Is there a particular reson you're not using ‘customize-set-variable’ for
all values?
It would be more consistent, and also avoid problems in case a package is
changed
and a setter function is added to a variable which previously did not use
it.
Regards,
Elias
[-- Attachment #2: Type: text/html, Size: 1513 bytes --]
next prev parent reply other threads:[~2017-11-24 7:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 17:10 custom-set-variables considered harmful Stefan Monnier
2017-11-06 9:02 ` Philippe Vaucher
2017-11-06 12:19 ` Clément Pit-Claudel
2017-11-06 16:36 ` raman
2017-11-07 19:53 ` Stefan Monnier
2017-11-08 10:06 ` Vivek Dasmohapatra
2017-11-08 13:38 ` Stefan Monnier
2017-11-08 14:23 ` Vivek Dasmohapatra
2017-11-08 15:17 ` Stefan Monnier
2017-11-08 15:34 ` Vivek Dasmohapatra
2017-11-13 16:26 ` Stefan Monnier
2017-11-24 7:04 ` Elias Mårtenson [this message]
2017-11-24 7:16 ` Stefan Monnier
2017-11-24 17:37 ` Clément Pit-Claudel
2017-11-24 17:56 ` Stefan Monnier
2017-11-26 12:15 ` Elias Mårtenson
2017-11-26 16:30 ` Drew Adams
2017-11-28 14:12 ` Philippe Vaucher
2017-11-28 16:50 ` John Wiegley
2017-12-01 9:44 ` Philippe Vaucher
2017-11-29 3:36 ` Elias Mårtenson
2017-11-29 15:00 ` Stefan Monnier
2017-11-29 15:03 ` Drew Adams
2017-12-01 20:42 ` Robert Weiner
2017-12-02 0:10 ` Richard Stallman
2017-12-02 1:58 ` Drew Adams
2017-12-02 5:56 ` Teemu Likonen
2017-11-29 16:35 ` Elias Mårtenson
2017-11-29 19:57 ` Scott Randby
2017-11-29 22:08 ` Stefan Monnier
2017-11-30 0:40 ` Scott Randby
2017-12-01 9:51 ` Philippe Vaucher
2017-12-04 13:48 ` Stefan Monnier
2017-12-04 15:36 ` Eli Zaretskii
2017-12-04 16:05 ` Robert Weiner
2017-12-04 23:50 ` Richard Stallman
2017-12-05 1:45 ` Stefan Monnier
2017-11-23 20:12 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADtN0WLVyXY5WvwnhguAxR90aTQD3g5KLvSWBnVxuqpcxgmfZg@mail.gmail.com \
--to=lokedhs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).