* Re: [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q [not found] ` <20241229180015.5FF2FD973AF@vcs3.savannah.gnu.org> @ 2024-12-29 19:45 ` Stefan Monnier 2024-12-31 8:55 ` Pranshu 0 siblings, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2024-12-29 19:45 UTC (permalink / raw) To: Pranshu Sharma; +Cc: emacs-devel > branch: elpa/haskell-ts-mode > commit df8d3690375a14ede7079640bc326111f1fb3ddd > Author: Pranshu Sharma <pranshu@pebl> > Commit: Pranshu Sharma <pranshu@pebl> > > remove indent function useless replace by M-q [...] > (defvar-keymap haskell-ts-mode-map > :doc "Keymap for haskell-ts-mode." > "C-c C-c" 'haskell-ts-compile-region-and-go > "C-c C-r" 'run-haskell > - "C-M-q" 'haskell-ts-indent-defun) > + 'haskell-ts-indent-defun) This last line doesn't look right. [ Also, I'd recommend you use #' to quote function names. ] Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q 2024-12-29 19:45 ` [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q Stefan Monnier @ 2024-12-31 8:55 ` Pranshu 2024-12-31 8:56 ` Pranshu 2024-12-31 15:14 ` Stefan Monnier 0 siblings, 2 replies; 4+ messages in thread From: Pranshu @ 2024-12-31 8:55 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel [-- Attachment #1: Type: text/plain, Size: 766 bytes --] Yeah,I realised that soon after, it should be fixed now On Mon, 30 Dec 2024, 1:15 am Stefan Monnier, <monnier@iro.umontreal.ca> wrote: > > branch: elpa/haskell-ts-mode > > commit df8d3690375a14ede7079640bc326111f1fb3ddd > > Author: Pranshu Sharma <pranshu@pebl> > > Commit: Pranshu Sharma <pranshu@pebl> > > > > remove indent function useless replace by M-q > [...] > > (defvar-keymap haskell-ts-mode-map > > :doc "Keymap for haskell-ts-mode." > > "C-c C-c" 'haskell-ts-compile-region-and-go > > "C-c C-r" 'run-haskell > > - "C-M-q" 'haskell-ts-indent-defun) > > + 'haskell-ts-indent-defun) > > This last line doesn't look right. > [ Also, I'd recommend you use #' to quote function names. ] > > > Stefan > > [-- Attachment #2: Type: text/html, Size: 1222 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q 2024-12-31 8:55 ` Pranshu @ 2024-12-31 8:56 ` Pranshu 2024-12-31 15:14 ` Stefan Monnier 1 sibling, 0 replies; 4+ messages in thread From: Pranshu @ 2024-12-31 8:56 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel [-- Attachment #1: Type: text/plain, Size: 907 bytes --] I will do hashtag thing later On Tue, 31 Dec 2024, 2:25 pm Pranshu, <pranshusharma366@gmail.com> wrote: > Yeah,I realised that soon after, it should be fixed now > > On Mon, 30 Dec 2024, 1:15 am Stefan Monnier, <monnier@iro.umontreal.ca> > wrote: > >> > branch: elpa/haskell-ts-mode >> > commit df8d3690375a14ede7079640bc326111f1fb3ddd >> > Author: Pranshu Sharma <pranshu@pebl> >> > Commit: Pranshu Sharma <pranshu@pebl> >> > >> > remove indent function useless replace by M-q >> [...] >> > (defvar-keymap haskell-ts-mode-map >> > :doc "Keymap for haskell-ts-mode." >> > "C-c C-c" 'haskell-ts-compile-region-and-go >> > "C-c C-r" 'run-haskell >> > - "C-M-q" 'haskell-ts-indent-defun) >> > + 'haskell-ts-indent-defun) >> >> This last line doesn't look right. >> [ Also, I'd recommend you use #' to quote function names. ] >> >> >> Stefan >> >> [-- Attachment #2: Type: text/html, Size: 1633 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q 2024-12-31 8:55 ` Pranshu 2024-12-31 8:56 ` Pranshu @ 2024-12-31 15:14 ` Stefan Monnier 1 sibling, 0 replies; 4+ messages in thread From: Stefan Monnier @ 2024-12-31 15:14 UTC (permalink / raw) To: Pranshu; +Cc: emacs-devel > Yeah,I realised that soon after, it should be fixed now I sa the fix pass by, indeed! Enjoy the last bits of 2024, Stefan > On Mon, 30 Dec 2024, 1:15 am Stefan Monnier, <monnier@iro.umontreal.ca> > wrote: > >> > branch: elpa/haskell-ts-mode >> > commit df8d3690375a14ede7079640bc326111f1fb3ddd >> > Author: Pranshu Sharma <pranshu@pebl> >> > Commit: Pranshu Sharma <pranshu@pebl> >> > >> > remove indent function useless replace by M-q >> [...] >> > (defvar-keymap haskell-ts-mode-map >> > :doc "Keymap for haskell-ts-mode." >> > "C-c C-c" 'haskell-ts-compile-region-and-go >> > "C-c C-r" 'run-haskell >> > - "C-M-q" 'haskell-ts-indent-defun) >> > + 'haskell-ts-indent-defun) >> >> This last line doesn't look right. >> [ Also, I'd recommend you use #' to quote function names. ] >> >> >> Stefan >> >> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-31 15:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <173549521472.300001.3703786856066422485@vcs3.savannah.gnu.org>
[not found] ` <20241229180015.5FF2FD973AF@vcs3.savannah.gnu.org>
2024-12-29 19:45 ` [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q Stefan Monnier
2024-12-31 8:55 ` Pranshu
2024-12-31 8:56 ` Pranshu
2024-12-31 15:14 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).