From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Anand Tamariya Newsgroups: gmane.emacs.devel Subject: Re: Semantic font-lock for Java Date: Thu, 23 Jan 2020 11:06:57 +0530 Message-ID: References: <83eevsx1eh.fsf@gnu.org> <83wo9jtncf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000303466059cc8082d" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 23 06:37:45 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuVBZ-000GAs-Gk for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 06:37:45 +0100 Original-Received: from localhost ([::1]:51272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuVBY-0007JY-JP for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 00:37:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48245) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuVB4-0006uV-5K for emacs-devel@gnu.org; Thu, 23 Jan 2020 00:37:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuVB2-0002B1-TU for emacs-devel@gnu.org; Thu, 23 Jan 2020 00:37:13 -0500 Original-Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]:33228) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iuVB0-00025u-9L; Thu, 23 Jan 2020 00:37:10 -0500 Original-Received: by mail-io1-xd35.google.com with SMTP id z8so1810519ioh.0; Wed, 22 Jan 2020 21:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0DTOCs0/Xny1wVhOaFJz1Z8i/NfqPatAHUCh8vs3Lyc=; b=p+UvDtVuCjXG7lkgUz1Si7UdqlK2qlzim+BG4FgkHt8/ylnarBFH2A9R4MxGVlE3DY xnCshQPf8m/vZBdRQLKtqIEcLASnBDvDPXp+1fnXDxIootopmXx7vItaVyOvcyGMCdRZ t0agqZY+WoN+L3N6HxoqB+flD1db7+tarcClLEjrqeAtxe88vJnxB6gyZXcn6qILC80t BHvbl9njiJvCFJzo6rrVJ7fDrYO/jC0ZY06h0Wcw3F/RiApGTxmLI5IQ21zlLorMWXmH VAF6jdb9jeZb6BCk4ocxcisshn9r4O4T0vS9z0R/7L3XiR2aC28GzSN9D+psNUBc3omd od8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0DTOCs0/Xny1wVhOaFJz1Z8i/NfqPatAHUCh8vs3Lyc=; b=bPJgZlCk0rllqSYds6gLLPY4qtqzmHw7EcXwIpRpM+Sfuy00Uu+eGunAxfGd0EUxjw ABckdKi7Wn2GEeF7CPhQ7dd+ls70yU1271jhccVORMJAWe/C9ROn4k08DisWq53OaywB 9mt3qIM+JnrTdYIvxFxmuF9l4KrYEaxFfdv99ZNkJjytNRRefSEskKjGM0r+auVhxZBV XzBujpQkqHEi3JgQBvVixhPoCZ2FFOaJRHo8ekM0D4zc5ZRql3DzOC+2VBGNhe4QYSIx ngBNmZraVyyeTLGijlxQThTDcMJbAzhW570KqNLGtwYgWlnlUyWYm3bLQ1CpB2jX462o PGdg== X-Gm-Message-State: APjAAAUvBdgvZcPo9PSBv65dml6kmXv/2FvK7GpA5jZbf5KXDQBA626U Ng61NKA41qFyEFUWBeiy3xtnsJkMBzmM+5o+u8/urmZeqng= X-Google-Smtp-Source: APXvYqyUQlOVbXV3kbj6QjLbBarZmNTNM8psia9SBaZppwcaZ/Qws0rgTtMBAeuso7zFC15MGgbDhLB1VXBohVINmLQ= X-Received: by 2002:a02:a694:: with SMTP id j20mr10285241jam.69.1579757828320; Wed, 22 Jan 2020 21:37:08 -0800 (PST) In-Reply-To: <83wo9jtncf.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d35 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244534 Archived-At: --000000000000303466059cc8082d Content-Type: text/plain; charset="UTF-8" > I don't think I understand the reasons for the changes in font-lock.el > and cc-mode.el. Can you explain? > These changes are there only for easy testing. They are unlikely to be part of final patch. Also, what do you mean by "disable jit-lock"? Where does that happen? > And if you disable jit-lock, does that mean Emacs will no longer > fontify only the portions of the window it is about to display? > There are some after change functions and region extend functions which are not really necessary with my approach. Hence I had to disable those portions. Following call stack should help you better visualize. - redisplay_internal (C function) 3 2% - jit-lock-function 2 1% - jit-lock-fontify-now 2 1% - jit-lock--run-functions 2 1% - run-hook-wrapped 2 1% - # 2 1% - font-lock-fontify-region 2 1% - *extract* 2 1% > you could run a benchmark of scrolling through a > > large source file top to bottom, and show the results in terms of time > > and number of GCs. > BTW I should admit that it is WIP. Right now, my focus is only on accuracy. I have made no attempts on optimization. So consider the results accordingly. - *Off* GCs: 0 Elapsed time: 0.840946 seconds - *Custom* GCs: 0 Elapsed time: 1.172106 seconds - *Builin* GCs: 1 Elapsed time: 0.991606 seconds --000000000000303466059cc8082d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I don't think I understand the reasons for the changes in font-lock.el<= br> and cc-mode.el.=C2=A0 Can you explain?
These changes a= re there only for easy testing. They are unlikely to be part of final patch= .

>=C2=A0 you could run a benchmark of scrolling through a
>=C2=A0 large source file top to bottom, and show the results in terms o= f time
>=C2=A0 and number of GCs.
BTW I should admit that = it is WIP. Right now, my focus is only on accuracy. I have made no attempts= on optimization. So consider the results accordingly.
    Off GCs: 0 Elapsed time: 0.840946 seconds
  • Custom GC= s: 0 Elapsed time: 1.172106 seconds
  • Builin GCs: 1 Elapsed ti= me: 0.991606 seconds

--000000000000303466059cc8082d--