From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Anand Tamariya Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Draw and scribble notes in GNU Emacs Date: Mon, 13 Sep 2021 14:01:27 +0530 Message-ID: References: <87fsudu7jm.fsf@gnus.org> <87pmtchogy.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000039a15b05cbdc4b61" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23206"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 13 10:33:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPhOu-0005s3-Ie for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 10:33:16 +0200 Original-Received: from localhost ([::1]:37962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPhOs-0000SJ-UU for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 04:33:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPhNN-0007We-JG for emacs-devel@gnu.org; Mon, 13 Sep 2021 04:31:41 -0400 Original-Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]:40903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPhNM-0006yl-4p for emacs-devel@gnu.org; Mon, 13 Sep 2021 04:31:41 -0400 Original-Received: by mail-il1-x12a.google.com with SMTP id a20so9216391ilq.7 for ; Mon, 13 Sep 2021 01:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6g10aG4TtnpzyXZh0XP1HW8T6uC5nGZ8ghkU3ePRjII=; b=OoYpXo68ZnmapMCfxgsHOxTtdXLqjGkrH+ETG8yZ7tU8vIR7KQs6KMDfWOE99mVarN 8n+DSzDlZUc2coZSQXVpvCe+K31tJFChYuokGSDmoeZ+RVWMcWOWTY/cckjpM44B/SLL OK+zf71wvJLajHgk1Fms4ZUiu/3kGf+4iOt4cg+2XLEk57aPxqtj2ud+N1jl4xwoyxiT QGmp7BikOVek4y/3RxV0V+uuh/A/0ya6GJLFKd59bST/SobUukAMEbyrIVFhKwrbKIO+ nYekI8v13BmoydXqcDHsHSmCOb52e51X/YwtxRcYBCpGw2DMyelR35id2FJfyxnLMYXC QOHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6g10aG4TtnpzyXZh0XP1HW8T6uC5nGZ8ghkU3ePRjII=; b=FsKlDZ0HzE5E21heSUkevaL8VcCqz4WMMj1APgsRZoWICv0YHoBEwgDkdwtyl6KoNI mbh4ELK1pYgkrpuaJv9W3lDvjH/C8qKNbikRXOrabiyNTyDDxr48R8C30I4rFKMZfmBp xiibZwd1O7VxWjd04WPOQlv7Auaq8YEwfjKzrvo8xTfhVDuhz4arFmWfrCWgAA44Fyn1 clsX8CVaXMBR6x0kOdux2bjtJufMZ09vPXlVaKU+H9jwzssQvKASRPvgGMHlU4bIf21T q1mES9p88o9cAOUNl1Nboe4RYfH1RPgMYSKin21SdXXlHOe1GNFLu0ZixbdyhwumSW74 7IHQ== X-Gm-Message-State: AOAM532WY2oSzRgBloqL6ayL2ADLwWsNfit61M7lRsP8++Oj19TAwqAy 7k72ZSySNZ0EJSUDcULKnY/BrjyO8SYVNzk8ehbE1tX2ow7eHg== X-Google-Smtp-Source: ABdhPJyWkbd6kkk1LJeIMh+2clRQ0oIn9oxV76aiEByKKvXfDbjgQb80qodKPIsWusDPaWULcjEYtwQOvrJ2jZVcG8Q= X-Received: by 2002:a05:6e02:964:: with SMTP id q4mr1700384ilt.290.1631521898860; Mon, 13 Sep 2021 01:31:38 -0700 (PDT) In-Reply-To: <87pmtchogy.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::12a; envelope-from=atamariya@gmail.com; helo=mail-il1-x12a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274622 Archived-At: --00000000000039a15b05cbdc4b61 Content-Type: text/plain; charset="UTF-8" > > Existing code doesn't ensure ids are unique. > > svg--append isn't the function to ensure this. This is an internal function. So it's safe to change its name to something which describes it's behaviour. However, this is the right function to change as this is being called by all other svg node creation functions. --00000000000039a15b05cbdc4b61 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

> Existing code doesn't ensure ids are unique.

svg--append isn't the function to ensure this.=C2=A0
T= his is an internal function. So it's safe to change its name to somethi= ng which describes it's behaviour. However, this is the right function = to change as this is being called by all other svg node creation functions.=

--00000000000039a15b05cbdc4b61--