From: "T.V. Raman" <tv.raman.tv@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Andreas Schwab <schwab@linux-m68k.org>,
emacs-devel@gnu.org
Subject: fix interactive spec for kill-region
Date: Fri, 7 Sep 2012 09:00:53 -0700 [thread overview]
Message-ID: <CADkJX2jUNpBw41yQpw95scKGbU3NtPqEBO89PBdcLp+1e8ogAw@mail.gmail.com> (raw)
In-Reply-To: <jwvr4qi311d.fsf-monnier+emacs@gnu.org>
Here is the byte-compiler warning:
emacs -batch -q -no-site-file -eval '(setq vc-handled-backends nil
byte-compile-warnings t)' -l ".."/lisp/emacspeak-load-path.el -l
".."/lisp/emacspeak-loaddefs.el -l ".."/lisp/emacspeak-cus-load.el -l
".."/lisp/g-client/g-load-path.el -f batch-byte-compile
emacspeak-advice.el
Warning: Unknown defun property special in emacspeak-should-i-fix-interactive-p
In toplevel form:
emacspeak-advice.el:1607:52:Warning: ad-Orig-kill-region called with 3
arguments, but accepts only 2
Line 1607 is the last line of this advice form:
(defadvice kill-region (around emacspeak pre act)
"Indicate region has been killed.
Use an auditory icon if possible."
(cond
((ems-interactive-p )
(let ((count (count-lines (region-beginning) (region-end))))
ad-do-it
(emacspeak-auditory-icon 'delete-object )
(message "Killed region containing %s lines" count)))
(t ad-do-it))
ad-return-value)
I'll attach just the advice form that triggers the error:
--
--
On 9/3/12, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> The signature doesn't match, and you get byte compiler warnings.
>
> Please report the actual byte-compilation warnings instead, then.
> I have a strong feeling you're confused about the source of the problem
> (which probably comes from the fact that the 3 optional argument was
> made obsolete and is hidden by an advertised signature).
>
>
> Stefan
>
next prev parent reply other threads:[~2012-09-07 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 14:33 fix interactive spec for kill-region T.V. Raman
2012-09-02 14:52 ` Andreas Schwab
2012-09-04 0:01 ` T.V. Raman
2012-09-04 3:45 ` Stefan Monnier
2012-09-07 16:00 ` T.V. Raman [this message]
2012-09-07 19:37 ` Stefan Monnier
2012-09-08 15:00 ` T.V. Raman
2012-09-08 16:14 ` Andreas Schwab
2012-10-26 18:02 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADkJX2jUNpBw41yQpw95scKGbU3NtPqEBO89PBdcLp+1e8ogAw@mail.gmail.com \
--to=tv.raman.tv@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).