From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "T.V. Raman" Newsgroups: gmane.emacs.devel Subject: Request: Use message instead of message_with_string for user visible output? Date: Sun, 27 Oct 2013 15:03:16 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1382911398 4649 80.91.229.3 (27 Oct 2013 22:03:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Oct 2013 22:03:18 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 23:03:23 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VaYQc-0004y9-IZ for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2013 23:03:22 +0100 Original-Received: from localhost ([::1]:39193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaYQc-0006bC-6B for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2013 18:03:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaYQY-0006at-Fp for emacs-devel@gnu.org; Sun, 27 Oct 2013 18:03:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VaYQX-0005YE-FV for emacs-devel@gnu.org; Sun, 27 Oct 2013 18:03:18 -0400 Original-Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:52777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaYQX-0005Y2-Bo for emacs-devel@gnu.org; Sun, 27 Oct 2013 18:03:17 -0400 Original-Received: by mail-qa0-f50.google.com with SMTP id cm18so1729683qab.9 for ; Sun, 27 Oct 2013 15:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=0tqa5FXMC6TNzNGGvjZ5ehfflhvZtqFe379uQPjXsgg=; b=IUOAmeEsw+YB3r/C4S2xbPyW8Gh14wJ1ERDIqutpbfSURYKx99AcIgvuYr9et/YYWf NzpAxSk5QGmIXnQv9xLRGSR0ZBw5jUbhhiRqwdLmlByEvYtcOHkX04qwcg84lf2MQP+f wz0vTCTP4pQBkVsC2WkwpX1jp1vq6tzL5nFq5lEczK8Qr83zIF8m1uAzIAQfWvzpboQU BfSkqv7x6UwwIhqMMX4AWA57EGS6CG0RzHD8DUOvA6tvAscX/sJwfcW1nZJRomn8r8sg T+Dj3rDF7ZGy2wPIbp0CqN8uuXBhT/9YTAsaZPOzzk0qd+ILtZ2x+RQvE1rtiZtotVCD vZ8g== X-Received: by 10.49.72.3 with SMTP id z3mr25648026qeu.23.1382911396720; Sun, 27 Oct 2013 15:03:16 -0700 (PDT) Original-Received: by 10.229.171.135 with HTTP; Sun, 27 Oct 2013 15:03:16 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164585 Archived-At: Thanks Stefan, Could you please update keyboard.c to call message instead of message_with_string when the user presses a key that is undefined? I understand that opinions re advice is mixed with some considering it a kluge, but kluge or not, it's stood Emacspeak in good stead and helped create a solution that has made me and others very productive over the last 18 years:-) -- Best Regards, --raman On 10/26/13, Stefan Monnier wrote: >> Except in cases where efficiency is the reason for the choice, >> could we switch to using message -- instead of >> message_with_string to produce output in the echo area that is >> to be seen by the user? > > I doubt there is a place where we call message_with_string for > efficiency reasons: the added cost of going through Ffuncall of Qmessage > is negligible compared to the cost of doing the actual display of > the message. > > But there might be cases where we need it for correctness reasons, > because the context is such that we can't run arbitrary Elisp code. > > > Stefan >