emacsclient always raise frame (possible regression)

emacsclient always raise frame (possible regression)

[Jon Dufresne]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi,

I recently updated my system to Fedora 19. Fedora 19 packages Gnome 3.8 and
Emacs 24.2.1.

I run Emacs in daemon mode. When using tools such as mercurial or git from
the command line, an editor is invoked with the command "emacsclient -c
FILENAME". When this editor is invoked I want the newly created frame
immediately raised to the top of Gnome's window stack so I may interact
with it.

In previous Fedora/Emacs versions I achieved this with the following in my
init.el

(add-hook 'after-make-frame-functions
          (lambda (frame)
            (raise-frame frame)))

This no longer works. Now whenever mercurial invokes the editor the frame
remains at the bottom of the stack of windows.

First off, should this elisp do what I'm trying to do? Is this a regression
in Emacs or an issue with Gnome? If this is wrong, what is the correct way
to always raise new frames?

Thanks,
Jon

[-- Attachment #2: Type: text/html, Size: 1028 bytes --]

Re: emacsclient always raise frame (possible regression)

[Michael Heerdegen]

Hi Jon,

> I recently updated my system to Fedora 19. Fedora 19 packages Gnome
> 3.8 and Emacs 24.2.1.
>
> I run Emacs in daemon mode. When using tools such as mercurial or git
> from the command line, an editor is invoked with the command
> "emacsclient -c FILENAME". When this editor is invoked I want the
> newly created frame immediately raised to the top of Gnome's window
> stack so I may interact with it.
>
> In previous Fedora/Emacs versions I achieved this with the following
> in my init.el
>
> (add-hook 'after-make-frame-functions
>           (lambda (frame)
>             (raise-frame frame)))
>
> This no longer works. Now whenever mercurial invokes the editor the
> frame remains at the bottom of the stack of windows.
>
> First off, should this elisp do what I'm trying to do?

Dunno.  AFAIK, it can happen that the newly created frame is not yet
displayed (i.e., created by X) when `after-make-frame-functions' are
called.

Try to use a delay, like this:

(add-hook 'after-make-frame-functions
	  (lambda (frame)
	    (run-with-idle-timer 1. nil 'raise-frame frame)))

> Is this a regression in Emacs or an issue with Gnome?  If this is
> wrong, what is the correct way to always raise new frames?

Note that `raise-frame' doesn't make the frame "current".  Maybe Gnome
raises the frame that has focus automatically?  Then you want
`select-frame-set-input-focus' instead of `raise-frame'.

If your problem is specific to emacsclient invocations, it is probably
better to configure `server-window' instead of
`after-make-frame-functions'.  This is what I do:

(setq server-window
      (lambda (buf)
	(let ((win (display-buffer-pop-up-frame buf ())))
	  (select-frame-set-input-focus (window-frame win)))))

Hope one of the above proposals helps.


Regards,

Michael.

Re: emacsclient always raise frame (possible regression)

[chad]

On 25 Jul 2013, at 13:29, Jon Dufresne <jon.dufresne@gmail.com> wrote:

> I run Emacs in daemon mode. When using tools such as mercurial or git from the command line, an editor is invoked with the command "emacsclient -c FILENAME". When this editor is invoked I want the newly created frame immediately raised to the top of Gnome's window stack so I may interact with it.
> 
> In previous Fedora/Emacs versions I achieved this with the following in my init.el
> 
> (add-hook 'after-make-frame-functions
>           (lambda (frame)
>             (raise-frame frame)))
> 
> This no longer works. Now whenever mercurial invokes the editor the frame remains at the bottom of the stack of windows.

I used to use:

 (setq server-visit-hook (append server-visit-hook '(raise-frame)))

I'm not in a position to test it right now, but you might give it a try.

Hope that helps,
~Chad

Re: emacsclient always raise frame (possible regression)

[Stefan Monnier]

>  (setq server-visit-hook (append server-visit-hook '(raise-frame)))

I strongly recommend you use `add-hook' to manipulate hooks.


        Stefan

Re: emacsclient always raise frame (possible regression)

[chad]

On 29 Jul 2013, at 10:20, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> (setq server-visit-hook (append server-visit-hook '(raise-frame)))
> 
> I strongly recommend you use `add-hook' to manipulate hooks.

Good point! That particular snippet might actually pre-date add-hook;
it's from somewhere around emacs 21, maybe 22. Sorry for not fixing
it up before sending it.

~Chad

Re: emacsclient always raise frame (possible regression)

[Stefan Monnier]

>>> (setq server-visit-hook (append server-visit-hook '(raise-frame)))
>> I strongly recommend you use `add-hook' to manipulate hooks.
> Good point! That particular snippet might actually pre-date add-hook;

Of course, such things happen.

> it's from somewhere around emacs 21, maybe 22.

Note that add-hook was added long before Emacs-21.


        Stefan