From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolai Weibull Newsgroups: gmane.emacs.devel Subject: Interaction between load-theme and custom-theme-set-faces is broken Date: Mon, 23 Jul 2012 09:30:46 +0200 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1343028662 9146 80.91.229.3 (23 Jul 2012 07:31:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 23 Jul 2012 07:31:02 +0000 (UTC) To: Emacs Developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 23 09:31:00 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1StD6Z-0002D6-Ou for ged-emacs-devel@m.gmane.org; Mon, 23 Jul 2012 09:30:59 +0200 Original-Received: from localhost ([::1]:51606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StD6W-0004Jz-3E for ged-emacs-devel@m.gmane.org; Mon, 23 Jul 2012 03:30:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StD6T-0004Jg-2D for emacs-devel@gnu.org; Mon, 23 Jul 2012 03:30:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StD6N-0006VU-BD for emacs-devel@gnu.org; Mon, 23 Jul 2012 03:30:53 -0400 Original-Received: from mail-pb0-f41.google.com ([209.85.160.41]:53409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StD6M-0006VN-VA for emacs-devel@gnu.org; Mon, 23 Jul 2012 03:30:47 -0400 Original-Received: by pbbrp2 with SMTP id rp2so12458280pbb.0 for ; Mon, 23 Jul 2012 00:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; bh=L2oddrMuls+iaLd51nFfys+rEo9eRhN1xdMu7L+9l3s=; b=Jqn7hLg3bK9vlBwRp/nxsoQe+5rbp3p6zVJWJ86Nc+v8DlaP9ssg463dUJcIBiHwrn MMftkgR+Za2B6DX9aMeL0WseU+hsh4Tt+yvs52eePsA+/VhafuTLf6mMIRCiIFoEEtZt clS9AmZJpEq3QM8GRIAH+eWBYE/lANQzBfc8jtRNmcttXECFWguP+JDTE1/IwJTjoWxq zOefB2swleBMJyP6Un1iYNTMY2Hmncy25dbjEP0heqd6Ul7HVaGv7K3f6dwaBMgDL/jx G2RRp9YwOQ+A2HFvTG66mxwdVtyKkqgx46wR9+1NzXN1oTnRHg2YSB1mwajGgxAyR8iy K+iw== Original-Received: by 10.68.132.165 with SMTP id ov5mr32791251pbb.19.1343028646214; Mon, 23 Jul 2012 00:30:46 -0700 (PDT) Original-Received: by 10.68.42.106 with HTTP; Mon, 23 Jul 2012 00:30:46 -0700 (PDT) X-Google-Sender-Auth: mOj_mBkSXwE-sguJpuZF2Y2b6gE X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151804 Archived-At: Hi! It seems that the interaction between load-theme and custom-theme-set-faces is broken. Previously, before a commit on 2011-03-21 that changed how custom--inhibit-theme-enable was used, custom-theme-set-faces would do quite a bit of work (setting properties) that other code depends upon (unless custom--inhibit-theme-enable was t, of course). For example, it would set 'saved-face, which face-spec-recalc checks for to determine how it should recalculate the specification of a face. As this code is no longer executed (ever, it seems, as custom--inhibit-theme-enable is never logically non-t while it=E2=80=99s being executed), this is now broke= n, which means that faces set through themes will always be a combination of the face-default-spec of the face and the spec of the theme. The same goes for custom-theme-set-variables, but isn=E2=80=99t as visually= apparent.