unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Brian Jenkins <brian@brianjenkins.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Fwd: [PATCH] frame.c: focus hooks
Date: Mon, 18 Nov 2013 08:33:11 -0500	[thread overview]
Message-ID: <CADTx1Oz3_xN9yu44_+UguZycyjEpS-gZBxGB=jVO5Epua=11_Q@mail.gmail.com> (raw)
In-Reply-To: <CADTx1Oy5pUmb9sPU6jm0yt1hJtvgJmfDtZQpeFakmHknhEXE=A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

Hi, Leo.

Thanks for the suggestion.

It's my understanding that the convention for hooks to receive no
arguments and for more complicated functions to be used only when
necessary.

From the Emacs info page 48.2.2

    Most hooks are "normal hooks".  This means that when Emacs runs the
    hook, it calls each hook function in turn, with no arguments.  We
    have made an effort to keep most hooks normal, so that you can use
    them in a uniform way.  Every variable whose name ends in `-hook' is
    a normal hook.

    A few hooks are "abnormal hooks".  Their names end in `-functions',
    instead of `-hook' (some old code may also use the deprecated suffix
    `-hooks').  What makes these hooks abnormal is the way its functions
    are called--perhaps they are given arguments, or perhaps the values
    they return are used in some way.  For example,
    `find-file-not-found-functions' is abnormal because as soon as one
    hook function returns a non-`nil' value, the rest are not called at
    all (*note Visiting::).  The documentation of each abnormal hook
    variable explains how its functions are used.

I'd like to keep things as simple as possible.  I think two normal hooks
are simpler than one abnormal hook.

Brian


On Sun, Nov 17, 2013 at 11:11 PM, Leo Liu <sdl.web@gmail.com> wrote:

> On 2013-11-18 01:50 +0800, Brian Jenkins wrote:
> > People will probably find other handy uses for these hooks.
>
> How about name it frame-focus-hook? and pass `t' to hook functions when
> gained focus and `nil' when lost focus?
>
> Leo
>

[-- Attachment #2: Type: text/html, Size: 2522 bytes --]

      parent reply	other threads:[~2013-11-18 13:33 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17 17:50 [PATCH] frame.c: focus hooks Brian Jenkins
2013-11-17 18:29 ` Bozhidar Batsov
2013-11-17 22:25   ` Brian Jenkins
2013-11-17 22:33     ` Drew Adams
2013-11-18 13:24       ` Brian Jenkins
2013-11-18 14:53         ` Drew Adams
2013-11-19  0:19         ` Stefan Monnier
2013-11-19  8:26         ` Stephen J. Turnbull
2013-11-19 14:10           ` Bozhidar Batsov
2013-11-20  3:10             ` Brian Jenkins
2013-11-18  8:20     ` Bozhidar Batsov
2013-11-18 13:32   ` Stefan Monnier
     [not found]     ` <CAM9Zgm18uL7+PJ+60NjZqtjZJ6tUV77xUbFhXh7UPwqs==1=hg@mail.gmail.com>
2013-11-18 14:20       ` Fwd: " Bozhidar Batsov
2013-11-18 14:23     ` Brian Jenkins
2013-11-18 18:44   ` Richard Stallman
2013-11-18 19:49     ` Brian Jenkins
2013-11-19  6:02       ` Richard Stallman
2013-11-19 18:14         ` Brian Jenkins
2013-11-19 18:53           ` Drew Adams
2013-11-20  0:52             ` Brian Jenkins
2013-11-19 23:42           ` Richard Stallman
2013-11-20  0:52             ` Josh
2013-11-20  3:16               ` Stefan Monnier
2013-11-20  3:36                 ` Josh
2013-11-20  7:34                   ` martin rudalics
2014-01-09 17:01                     ` Josh
2014-01-11 10:25                       ` martin rudalics
2014-01-11 19:05                         ` Josh
2014-01-12  9:54                           ` martin rudalics
2014-01-14 17:30                             ` Josh
2014-01-14 18:10                               ` martin rudalics
2014-01-10 17:31                   ` Stefan Monnier
2014-01-11 19:06                     ` Josh
2013-11-20  0:53             ` Brian Jenkins
2013-11-20  7:46               ` Jarek Czekalski
2013-11-17 19:28 ` Glenn Morris
2013-11-17 21:19 ` Stefan Monnier
2013-11-18  4:11 ` Leo Liu
     [not found]   ` <CADTx1Oy5pUmb9sPU6jm0yt1hJtvgJmfDtZQpeFakmHknhEXE=A@mail.gmail.com>
2013-11-18 13:33     ` Brian Jenkins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADTx1Oz3_xN9yu44_+UguZycyjEpS-gZBxGB=jVO5Epua=11_Q@mail.gmail.com' \
    --to=brian@brianjenkins.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).