From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Radon Rosborough Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix `early-init-file' value when file is missing Date: Fri, 8 Feb 2019 09:34:08 -0800 Message-ID: References: <8336p7zxdf.fsf@gnu.org> <83bm3mrazc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ed23430581655f53" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149204"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 18:36:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsA5D-000cgT-1i for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 18:36:59 +0100 Original-Received: from localhost ([127.0.0.1]:60573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsA5B-00079u-W9 for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 12:36:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsA3I-0006gY-1R for emacs-devel@gnu.org; Fri, 08 Feb 2019 12:35:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsA3G-0000Nb-4g for emacs-devel@gnu.org; Fri, 08 Feb 2019 12:34:59 -0500 Original-Received: from mail-ua1-x944.google.com ([2607:f8b0:4864:20::944]:38911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsA39-00009m-Lg; Fri, 08 Feb 2019 12:34:52 -0500 Original-Received: by mail-ua1-x944.google.com with SMTP id p9so1381494uaa.5; Fri, 08 Feb 2019 09:34:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VtkXP6wOjpQ3db6uo3lAO90Vr8h8UrwZRoI7cumUccs=; b=GojBF4S5/0/r/kT07Q2h945G4SM3J8q7qIo7YuQjT4VOKNOQbz0Z6ULTE4dWt2V9Ws SKuCAIO5fmoiGjUiCdD/Til9fBEcsIV0slruygc2qLCMiHnBJ59etBGm3VCuQdiMX4FP HNeip9BUHqjMSRR15zwW6AnuFLQ86ZTp9GqofvULbVBDfM8L/IFDFMTXy6FVsVbxjS1a +l04VPbECY1THPci/7sMxmQvUGkQxNcElxR8M0uNEWYDHeMqUFNmqLaU9O4RjTwvJqrV bHoBdE9hTY8yr0T0NbWK8K+1Cz3jFxWtXKRKvvcqG6ZHRYtqyHFlxUHFJITqWhx/BKaf evjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VtkXP6wOjpQ3db6uo3lAO90Vr8h8UrwZRoI7cumUccs=; b=ZuJs+V7qRAeaHoRROsI1Ilu5oNv3Z4u8ugUOYD+iO1GlrAgnCJBFXxJW1ZYYxfyU3Z pK/qOBpP/HCreZn/Qcukm34Auv7x0gFRPdZShEmzXTdqvEt2FBi8t3neYbqaeUGKPldO 2yWgSl8xq5ixe9XZAryuZJUGbebLeeOFxxH2VbFmY+HVW1/hClkAwaQDXwO1P0m5HMAz gMIBQFSKgIn1WPibUDHEagE7eezra8rjxI33XcEJSsdfnKoNwJ7sRVkiIyzJxf0F0K7Q EX4jv+5BLtNP6+O6KNyvktBZomSh223PMP+7BbLcVgvSxcZ7TbZXsEYqycHwxSsKyoNc 9fIg== X-Gm-Message-State: AHQUAubyhuaBmNQY9vi/e3cTfghqTk9RfJ2G0rAm7CbekA2XX1ohMhfM BIhawod3d2lJR4GwCLRF3NipWDidD9h18pWnuGjo3KnE X-Google-Smtp-Source: AHgI3IZm4Wg65M0hAJdGBh6iiE7kiyJ1NEbfSrMH9SosrBiKGxzxenc+wsef03HMG15coItAN7GZ16/omKp1jS/2PDM= X-Received: by 2002:ab0:3407:: with SMTP id z7mr7210579uap.115.1549647284608; Fri, 08 Feb 2019 09:34:44 -0800 (PST) In-Reply-To: <83bm3mrazc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::944 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233138 Archived-At: --000000000000ed23430581655f53 Content-Type: text/plain; charset="UTF-8" > From: Eli Zaretskii > Date: Feb 7, 2019, 11:32 PM > > However, I would prefer to have this solved outside > load-user-init-file, if feasible. This function is too central to > Emacs to make non-trivial changes there for such a minor problem's > sake. I am sorry, but I simply cannot see how this change is non-trivial. There is exactly one logic change that this patch makes: namely, that the extension of user-init-file is changed to .el, but only in the case of the early init-file not being found. That change will affect only one of the two invocations of this function which exist, in only one case. Everything else in the patch is simply renaming variables and updating the documentation. I also cannot see how any other way of solving this bug could be as clear and straightforward as fixing it directly by updating the code that was broken. Could you explain your reasoning? Thanks, Radon --000000000000ed23430581655f53 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> From: Eli Zaretskii <eliz@gnu.org>
> Date: Feb 7, 2019, 11:32 PM
>
> However, I would prefer to have this solved outs= ide
> load-user-init-file, if feasible. This function is too c= entral to
> Emacs to make non-trivial changes there for such a= minor problem's
> sake.

I am sorry, but I s= imply cannot see how this change is non-trivial.
There is exactly= one logic change that this patch makes: namely, that
the extensi= on of user-init-file is changed to .el, but only in the
case of t= he early init-file not being found. That change will affect
only = one of the two invocations of this function which exist, in only
= one case. Everything else in the patch is simply renaming variables
and updating the documentation.

I also cannot see how any = other way of solving this bug could be as
clear and straightforwa= rd as fixing it directly by updating the code
that was broken.
Could you explain your reasoning?

Thanks,
Radon

--000000000000ed23430581655f53--