bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Noah Sussman]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

Since this bug still exists in Homebrew as of July 2018, I thought I would
share how I solved it on OS X Sierra v10.12.6

brew edit cask emacs

This will open a text editor. Search for “def install”

Paste the following line immediately below “def install”:

ENV[“cflags"]="-DMAC_OS_X_VERSION_MAX_ALLOWED=101200”

Close the editor and reinstall the cask:

brew reinstall cask emacs

[-- Attachment #2: Type: text/html, Size: 598 bytes --]

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Tue, Jul 10, 2018 at 04:52:29PM -0400, Noah Sussman wrote:
> Since this bug still exists in Homebrew as of July 2018, I thought I would
> share how I solved it on OS X Sierra v10.12.6
> 
> brew edit cask emacs
> 
> This will open a text editor. Search for “def install”
> 
> Paste the following line immediately below “def install”:
> 
> ENV[“cflags"]="-DMAC_OS_X_VERSION_MAX_ALLOWED=101200”
> 
> Close the editor and reinstall the cask:
> 
> brew reinstall cask emacs

Why is this an issue in homebrew? Does it use an old version of the
XCode command line tools?
-- 
Alan Third

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Radon Rosborough]

> brew edit cask emacs

Do you perhaps mean 'brew cask edit' rather than 'brew edit cask'?

I would assume yes, but 'cask' is also the name of a Homebrew formula
relating to Emacs... :)

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Noah Sussman]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On Thu, Jul 12, 2018 at 10:16 PM, Radon Rosborough <radon.neon@gmail.com>
wrote:

> > brew edit cask emacs
>
> Do you perhaps mean 'brew cask edit' rather than 'brew edit cask'?
>

The quoted command is the one I used.

It may not be optimal or there may be a more idiomatic Homebrew way to do
it, but I have looked at my .history file and here are all 3 commands I
used to get Emacs to stop crashing when closing a fullscreen window:

brew cask install emacs
brew edit cask emacs
# change the ctags as described above
brew reinstall cask emacs

I did try the other way round:

brew cask edit emacs

and it opens a different file, not the right file to put that ctags change
in!!!

[-- Attachment #2: Type: text/html, Size: 1225 bytes --]

bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Matthew Bauer]

Hi Alan,

This is still an issue for me. Note that to reproduce you must have
"tabbing" enabled through macOS:

System Preferences -> Dock -> Prefer tabs when opening document -> Always

Any idea what is going on? It's still happening in my 26.0.91 build,
so I'm assuming it hasn't been fixed in master).

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Thu, Mar 15, 2018 at 07:54:56PM -0500, Matthew Bauer wrote:
> Hi Alan,
> 
> This is still an issue for me. Note that to reproduce you must have
> "tabbing" enabled through macOS:
> 
> System Preferences -> Dock -> Prefer tabs when opening document -> Always
> 
> Any idea what is going on? It's still happening in my 26.0.91 build,
> so I'm assuming it hasn't been fixed in master).

Hi, are you building your own Emacs or downloading it from somewhere
else?
-- 
Alan Third

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[David Reitter]

On Mar 16, 2018, at 6:47 AM, Alan Third <alan@idiocy.org> wrote:
> 
> Hi, are you building your own Emacs or downloading it from somewhere
> else?

I just reproduced Matthew’s bug, several times (relevant portion of stack trace below).
Just open a few new frames (which is redirected to a tab), then close the frame.

It reproduced in a mid-2016 build, and in a current build (based on the 25 branch).


10  libsystem_platform.dylib      	0x00007fff61c3ff5a _sigtramp + 26
11  ???                           	000000000000000000 0 + 0
12  org.gnu.Aquamacs              	0x00000001001c5fa4 -[EmacsView drawRect:] + 84
13  com.apple.AppKit              	0x00007fff37f3bc21 _NSViewDrawRect + 83
14  com.apple.AppKit              	0x00007fff377d4b38 -[NSView _drawRect:clip:] + 1819
15  com.apple.AppKit              	0x00007fff3781cf62 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1735
16  com.apple.AppKit              	0x00007fff3781d42f -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2964
17  com.apple.AppKit              	0x00007fff3781d42f -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2964
18  com.apple.AppKit              	0x00007fff377d2a52 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 938
19  com.apple.AppKit              	0x00007fff377d21db -[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 327
20  com.apple.AppKit              	0x00007fff37f3d1d8 -[NSView _oldDisplayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 2051
21  com.apple.AppKit              	0x00007fff377d1261 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 253
22  com.apple.AppKit              	0x00007fff377cd4b8 -[NSView displayIfNeeded] + 1581
23  com.apple.AppKit              	0x00007fff37757dc1 -[NSThemeFrame handleSetFrameCommonRedisplay] + 281
24  com.apple.AppKit              	0x00007fff3774fa1d -[NSWindow _setFrameCommon:display:stashSize:] + 4103
25  com.apple.AppKit              	0x00007fff3774ea09 -[NSWindow _setFrame:display:allowImplicitAnimation:stashSize:] + 222
26  com.apple.AppKit              	0x00007fff3784d42c -[NSWindow setFrame:display:animate:] + 647
27  org.gnu.Aquamacs              	0x00000001001c834a -[EmacsWindow setFrame:display:animate:] + 74
28  com.apple.AppKit              	0x00007fff37ee4d42 -[NSThemeFrame _growWindowReshapeContentAndToolbarView:withOldToolbarFrameSize:animate:] + 1371
29  com.apple.AppKit              	0x00007fff37ee50a0 -[NSThemeFrame _reshapeContentAndToolbarView:withOldToolbarFrameSize:resizeWindow:animate:] + 494
30  com.apple.AppKit              	0x00007fff3774c32c -[NSThemeFrame _toolbarFrameSizeChanged:oldSize:] + 66
31  com.apple.AppKit              	0x00007fff3784ccb0 -[NSWindow _toolbarFrameSizeChanged:oldSize:] + 93
32  com.apple.AppKit              	0x00007fff3772236a -[NSToolbarView _layoutDirtyItemViewersAndTileToolbar] + 5826
33  com.apple.AppKit              	0x00007fff37713bfd -[NSToolbar _noteToolbarShowsBaselinePropertyChanged] + 27
34  com.apple.AppKit              	0x00007fff37f02219 -[NSToolbar _setHideBaselineOverride:] + 96
35  com.apple.AppKit              	0x00007fff37eeaff0 -[NSWindowStackController _removeTabBarAccessoryViewControllerForWindow:] + 271
36  com.apple.AppKit              	0x00007fff37eebe52 -[NSWindowStackController removeWindow:] + 277
37  com.apple.AppKit              	0x00007fff37a75cb5 -[NSWindow(NSWindowTabbing) _doTabbedWindowCleanupForOrderOut] + 97
38  com.apple.AppKit              	0x00007fff37f5ef44 -[NSWindow _finishClosingWindow] + 73
39  com.apple.AppKit              	0x00007fff378ff264 -[NSWindow _close] + 378
40  org.gnu.Aquamacs              	0x00000001001b770d x_free_frame_resources + 301
41  org.gnu.Aquamacs              	0x00000001001b7756 x_destroy_window + 22
42  org.gnu.Aquamacs              	0x0000000100010250 delete_frame + 1440

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Fri, Mar 16, 2018 at 02:12:32PM -0400, David Reitter wrote:
> I just reproduced Matthew’s bug, several times (relevant portion of stack trace below).
> Just open a few new frames (which is redirected to a tab), then close the frame.
> 
> It reproduced in a mid-2016 build, and in a current build (based on the 25 branch).

It was fixed after that. I can’t reproduce it in Emacs 26.

I want to know how Matthew got his copy of Emacs as the code to turn
off Sierra tab support is only included when built on Sierra+ or when
using the right build options.

As far as I’m aware emacsformacosx.com builds, for example, don’t
include it yet.
-- 
Alan Third

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[David Reitter]

On Mar 18, 2018, at 7:15 AM, Alan Third <alan@idiocy.org> wrote:

>> It reproduced in a mid-2016 build, and in a current build (based on the 25 branch).
> 
> It was fixed after that. I can’t reproduce it in Emacs 26.

Is this going to be backported to 25?

> I want to know how Matthew got his copy of Emacs as the code to turn
> off Sierra tab support is only included when built on Sierra+ or when
> using the right build options.

That suggests the “fix” is to turn off tab support - is that right?

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Sun, Mar 18, 2018 at 07:17:34AM -0400, David Reitter wrote:
> On Mar 18, 2018, at 7:15 AM, Alan Third <alan@idiocy.org> wrote:
> 
> >> It reproduced in a mid-2016 build, and in a current build (based on the 25 branch).
> > 
> > It was fixed after that. I can’t reproduce it in Emacs 26.
> 
> Is this going to be backported to 25?

No, I’m pretty sure it isn’t.

> > I want to know how Matthew got his copy of Emacs as the code to turn
> > off Sierra tab support is only included when built on Sierra+ or when
> > using the right build options.
> 
> That suggests the “fix” is to turn off tab support - is that right?

I’m not sure, to be honest, but Matthew said he could only reproduce
the problem with tab support on.

I have tab support on in the OS and can’t reproduce it.

The relevant code is:

  /* macOS Sierra automatically enables tabbed windows.  We can't
     allow this to be enabled until it's available on a Free system.
     Currently it only happens by accident and is buggy anyway. */
#if defined (NS_IMPL_COCOA) \
  && MAC_OS_X_VERSION_MAX_ALLOWED >= 101200
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101200
  if ([win respondsToSelector: @selector(setTabbingMode:)])
#endif
    [win setTabbingMode: NSWindowTabbingModeDisallowed];
#endif

at the bottom of initFrameFromEmacs in nsterm.m.

It’s possible we need to include similar code for fullscreen (I can’t
remember if the fullscreen code uses initFrameFromEmacs), but it seems
OK here.
-- 
Alan Third

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[John Wiegley]

>>>>> "DR" == David Reitter <david.reitter@gmail.com> writes:

DR> On Mar 18, 2018, at 7:15 AM, Alan Third <alan@idiocy.org> wrote:
>>> It reproduced in a mid-2016 build, and in a current build (based on the 25
>>> branch).
>> 
>> It was fixed after that. I can’t reproduce it in Emacs 26.

DR> Is this going to be backported to 25?

When was this fixed? It happens to me in Emacs 26 every time.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Sun, Mar 18, 2018 at 11:14:04AM -0700, John Wiegley wrote:
> >>>>> "DR" == David Reitter <david.reitter@gmail.com> writes:
> 
> DR> On Mar 18, 2018, at 7:15 AM, Alan Third <alan@idiocy.org> wrote:
> >>> It reproduced in a mid-2016 build, and in a current build (based on the 25
> >>> branch).
> >> 
> >> It was fixed after that. I can’t reproduce it in Emacs 26.
> 
> DR> Is this going to be backported to 25?
> 
> When was this fixed? It happens to me in Emacs 26 every time.

I haven’t been able to replicate it since sometime around the middle
of last year. Additionally there was a fix for macOS 10.13 installed
in emacs-26 in October last year.

I still can’t replicate it.

If anyone is able to provide a backtrace for either emacs 26 or the
master branch crashing, that would be helpful.
-- 
Alan Third

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Nick Helm]

On Sun, 18 Mar 2018 at 20:14:16 +0000, Alan Third wrote:

> If anyone is able to provide a backtrace for either emacs 26 or the
> master branch crashing, that would be helpful.

I can't reproduce this using a current build on macOS HS (either emacs-26 or
master), but I can with a prebuilt download from emacsformacosx.com. The
emacs-26 branch (dated 2018.01.23) and master (dated 2018.02.22) crash
every time. I don't know what system these were built on.

Here's a backtrace from 27.0.50, if it's useful:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff7fb6fe3e __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff7fcae150 pthread_kill + 333
2   libsystem_c.dylib             	0x00007fff7fa7e8fe raise + 26
3   Emacs-x86_64-10_9             	0x00000001000bdc11 terminate_due_to_signal + 161
4   Emacs-x86_64-10_9             	0x00000001000da9c3 emacs_abort + 19
5   Emacs-x86_64-10_9             	0x00000001001be94c ns_term_shutdown + 124
6   Emacs-x86_64-10_9             	0x00000001000bddf5 shut_down_emacs + 261
7   Emacs-x86_64-10_9             	0x00000001000bdbd6 terminate_due_to_signal + 102
8   Emacs-x86_64-10_9             	0x00000001000dc2f6 deliver_fatal_thread_signal + 134
9   Emacs-x86_64-10_9             	0x00000001000dd6d7 handle_sigsegv + 167
10  libsystem_platform.dylib      	0x00007fff7fca1f5a _sigtramp + 26
11  ???                           	000000000000000000 0 + 0
12  Emacs-x86_64-10_9             	0x00000001001c8504 -[EmacsView drawRect:] + 84
13  com.apple.AppKit              	0x00007fff55f9dc21 _NSViewDrawRect + 83
14  com.apple.AppKit              	0x00007fff55836b38 -[NSView _drawRect:clip:] + 1819
15  com.apple.AppKit              	0x00007fff5587ef62 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1735
16  com.apple.AppKit              	0x00007fff5587f42f -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2964
17  com.apple.AppKit              	0x00007fff5587f42f -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2964
18  com.apple.AppKit              	0x00007fff55834a52 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 938
19  com.apple.AppKit              	0x00007fff558341db -[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 327
20  com.apple.AppKit              	0x00007fff55f9f1d8 -[NSView _oldDisplayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 2051
21  com.apple.AppKit              	0x00007fff55833261 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 253
22  com.apple.AppKit              	0x00007fff5582f4b8 -[NSView displayIfNeeded] + 1581
23  com.apple.AppKit              	0x00007fff557b9dc1 -[NSThemeFrame handleSetFrameCommonRedisplay] + 281
24  com.apple.AppKit              	0x00007fff557b1a1d -[NSWindow _setFrameCommon:display:stashSize:] + 4103
25  com.apple.AppKit              	0x00007fff557b0a09 -[NSWindow _setFrame:display:allowImplicitAnimation:stashSize:] + 222
26  com.apple.AppKit              	0x00007fff557b0924 -[NSWindow setFrame:display:] + 67
27  Emacs-x86_64-10_9             	0x00000001001ca17a -[EmacsWindow setFrame:display:] + 74
28  com.apple.AppKit              	0x00007fff55d71cd2 -[_NSWindowExitFullScreenTransitionController setupWindowForAfterFullScreenExit] + 282
29  com.apple.AppKit              	0x00007fff5605a90c -[_NSExitFullScreenTransitionController start] + 430
30  com.apple.AppKit              	0x00007fff55ad7d63 -[NSWindow(NSWindowTabbing) _doTabbedWindowCleanupForOrderOut] + 271
31  com.apple.AppKit              	0x00007fff55fc0f44 -[NSWindow _finishClosingWindow] + 73
32  com.apple.AppKit              	0x00007fff55961264 -[NSWindow _close] + 378
33  Emacs-x86_64-10_9             	0x00000001001bad9c x_free_frame_resources + 300
34  Emacs-x86_64-10_9             	0x00000001001bae3a x_destroy_window + 106
35  Emacs-x86_64-10_9             	0x000000010000f93f delete_frame + 1295
36  Emacs-x86_64-10_9             	0x0000000100142ca3 funcall_subr + 83
37  Emacs-x86_64-10_9             	0x0000000100142275 Ffuncall + 773
38  Emacs-x86_64-10_9             	0x0000000100141bd1 Fapply + 145
39  Emacs-x86_64-10_9             	0x000000010013e7a1 eval_sub + 2449
40  Emacs-x86_64-10_9             	0x000000010013e98d Fif + 93
41  Emacs-x86_64-10_9             	0x000000010013e3ca eval_sub + 1466
42  Emacs-x86_64-10_9             	0x000000010014326d funcall_lambda + 989
43  Emacs-x86_64-10_9             	0x0000000100142215 Ffuncall + 677
44  Emacs-x86_64-10_9             	0x0000000100141bd1 Fapply + 145
45  Emacs-x86_64-10_9             	0x0000000100142ca3 funcall_subr + 83
46  Emacs-x86_64-10_9             	0x0000000100142275 Ffuncall + 773
47  Emacs-x86_64-10_9             	0x000000010018359b exec_byte_code + 1771
48  Emacs-x86_64-10_9             	0x0000000100142215 Ffuncall + 677
49  Emacs-x86_64-10_9             	0x000000010013b8b6 Ffuncall_interactively + 70
50  Emacs-x86_64-10_9             	0x0000000100142ca3 funcall_subr + 83
51  Emacs-x86_64-10_9             	0x0000000100142275 Ffuncall + 773
52  Emacs-x86_64-10_9             	0x000000010013d04b Fcall_interactively + 6011
53  Emacs-x86_64-10_9             	0x0000000100142d92 funcall_subr + 322
54  Emacs-x86_64-10_9             	0x0000000100142275 Ffuncall + 773
55  Emacs-x86_64-10_9             	0x000000010018359b exec_byte_code + 1771
56  Emacs-x86_64-10_9             	0x0000000100142215 Ffuncall + 677
57  Emacs-x86_64-10_9             	0x000000010014297d call1 + 45
58  Emacs-x86_64-10_9             	0x00000001000c1c1d command_loop_1 + 1981
59  Emacs-x86_64-10_9             	0x0000000100140937 internal_condition_case + 87
60  Emacs-x86_64-10_9             	0x00000001000d2460 command_loop_2 + 48
61  Emacs-x86_64-10_9             	0x00000001001401ee internal_catch + 78
62  Emacs-x86_64-10_9             	0x00000001000c0b1e command_loop + 158
63  Emacs-x86_64-10_9             	0x00000001000c0a30 recursive_edit_1 + 112
64  Emacs-x86_64-10_9             	0x00000001000c0c65 Frecursive_edit + 229
65  Emacs-x86_64-10_9             	0x00000001000bf83a main + 6618
66  libdyld.dylib                 	0x00007fff7fa20115 start + 1

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Mon, Mar 19, 2018 at 01:37:36PM +1300, Nick Helm wrote:
> On Sun, 18 Mar 2018 at 20:14:16 +0000, Alan Third wrote:
> 
> > If anyone is able to provide a backtrace for either emacs 26 or the
> > master branch crashing, that would be helpful.
> 
> I can't reproduce this using a current build on macOS HS (either emacs-26 or
> master), but I can with a prebuilt download from emacsformacosx.com. The
> emacs-26 branch (dated 2018.01.23) and master (dated 2018.02.22) crash
> every time. I don't know what system these were built on.

Thanks.

I think this is because it’s built on 10.9. We added some code to
support building across versions (actually because of this specific
issue) but David hasn’t sorted it out yet.

What was really confusing me was people building on 10.13 running into
the same issue. It looks like it’s because they’re using Nix which
apparently builds against the 10.10 SDK.

-- 
Alan Third

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Matthew Bauer]

Alan Third <alan@idiocy.org> writes:

> It was fixed after that. I can’t reproduce it in Emacs 26.
>
> I want to know how Matthew got his copy of Emacs as the code to turn
> off Sierra tab support is only included when built on Sierra+ or when
> using the right build options.
>
> As far as I’m aware emacsformacosx.com builds, for example, don’t
> include it yet.

So I've been building from source with a checkout of
https://git.savannah.gnu.org/git/emacs.git. The revision is
8d4500087f547e203cfba03f61dcbe641bf650de.

I actually hadn't realized that Sierra's "tabbing" feature is disabled
intentionally in Emacs. I had been using it since Sierra came out and it
works fine except for the frame closing issue. This is obviously a
little contentious in the Emacs world but I wonder if it could be
supported. IMO this is a "window manager" feature similar to how lots of
window managers will group multiple frames of Emacs. In no way is it
really an "Emacs feature" that has to be disabled.

A note on this that may be important: This was from John's Nix
configuration script that is available on:
https://github.com/jwiegley/nix-config/blob/e5649602dc89f944e0444a88d8526b19b965bccb/overlays/10-emacs.nix#L678-L698

This probably accounts for how John is having the same issue. Nix does
some stuff to achieve "purity" but might be inadvertly introducing the
issue. The SDK used in Nixpkgs is still at macOS 10.10 Yosemite. It
could be causing the discrepency. Most likely the build from
"emacsformacosx.com" is using older SDKs as well.

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Sun, Mar 18, 2018 at 09:05:06PM -0500, Matthew Bauer wrote:
> 
> I actually hadn't realized that Sierra's "tabbing" feature is disabled
> intentionally in Emacs. I had been using it since Sierra came out and it
> works fine except for the frame closing issue. This is obviously a
> little contentious in the Emacs world but I wonder if it could be
> supported. IMO this is a "window manager" feature similar to how lots of
> window managers will group multiple frames of Emacs. In no way is it
> really an "Emacs feature" that has to be disabled.

You could also argue that free OS’s support tab bar mode and the like,
so this isn’t really unprecedented. It would need some work before it
could be properly supported, though. Not least because it appears to
cause crashes.

> A note on this that may be important: This was from John's Nix
> configuration script that is available on:
> https://github.com/jwiegley/nix-config/blob/e5649602dc89f944e0444a88d8526b19b965bccb/overlays/10-emacs.nix#L678-L698
> 
> This probably accounts for how John is having the same issue. Nix does
> some stuff to achieve "purity" but might be inadvertly introducing the
> issue. The SDK used in Nixpkgs is still at macOS 10.10 Yosemite. It
> could be causing the discrepency. Most likely the build from
> "emacsformacosx.com" is using older SDKs as well.

Yes, 10.10 doesn’t support the tabs command. emacsformacosx.com builds
on 10.9 the last time I looked, so yes, that’s what’s going on there.

Please try adding

    -DMAC_OS_X_VERSION_MAX_ALLOWED=101200

to CFLAGS.

It should give you a compiler warning or two, but you can safely
ignore them.
-- 
Alan Third

Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[John Wiegley]

>>>>> "AT" == Alan Third <alan@idiocy.org> writes:

AT> Yes, 10.10 doesn’t support the tabs command. emacsformacosx.com builds on
AT> 10.9 the last time I looked, so yes, that’s what’s going on there.

AT> Please try adding
AT>     -DMAC_OS_X_VERSION_MAX_ALLOWED=101200
AT> to CFLAGS.

I can confirm that this resolves the issue for me. In fact, now each created
frame gets its own space, and I can even have a non-fullscreen frame in my
main space, with the other frames being their own spaces.  And no more crashes
when closing a fullscreen frame. Thank you!

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2