From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Radon Rosborough Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fixing package-initialize, adding early init file Date: Tue, 20 Feb 2018 12:35:27 -0800 Message-ID: References: <83po9vos4z.fsf@gnu.org> <87shelv2m6.fsf@udel.edu> <83vajgh4xe.fsf@gnu.org> <838tc12h42.fsf@gnu.org> <834lmfdexa.fsf@gnu.org> <87vaeu40iz.fsf@tcd.ie> <87mv034gp5.fsf@tcd.ie> <87r2pfcvil.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f4f5e8079970aeb1070565aac24e" X-Trace: blaine.gmane.org 1519158862 6430 195.159.176.226 (20 Feb 2018 20:34:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Feb 2018 20:34:22 +0000 (UTC) Cc: Eli Zaretskii , =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= , Stefan Monnier , emacs-devel To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 20 21:34:18 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoEcD-00018e-Vm for ged-emacs-devel@m.gmane.org; Tue, 20 Feb 2018 21:34:18 +0100 Original-Received: from localhost ([::1]:57666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoEeF-0000Ud-TK for ged-emacs-devel@m.gmane.org; Tue, 20 Feb 2018 15:36:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoEe4-0000UK-Ka for emacs-devel@gnu.org; Tue, 20 Feb 2018 15:36:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoEe3-0006Fi-QD for emacs-devel@gnu.org; Tue, 20 Feb 2018 15:36:12 -0500 Original-Received: from mail-lf0-x232.google.com ([2a00:1450:4010:c07::232]:43681) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoEe2-0006Es-7K; Tue, 20 Feb 2018 15:36:10 -0500 Original-Received: by mail-lf0-x232.google.com with SMTP id q69so6058436lfi.10; Tue, 20 Feb 2018 12:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yJcjj7haGvucMnXySnvXK9HbBYpyJX1/61iTTQ3wOsA=; b=Ai0/KqS+uKlJ45At1c2xKe7nm/Hpyk6ggsjvMRopfsDzIg558gE8CMQNmJBGejI8Cn mQXSjmuCpCJ2YvrFGiQwRDlYU+uc20xqMz8k+6hTkddis279hpydeekubQuCi0jCC/YN shHgW0H+GLhscUj4g6F++Ajs2y1olLDsk8B1Nb9zE2g69A6xYg8nWnQEWSRq0sgNTliH Gc6DqLMcgjUI3Qj/NMtOOGNG22C5jGFfV2o9OVk1F41f+3B3sDAnPQ910pKwoe0SKtva LgJtCg2P+2RSwRPNuiNUxwJaz0l0CFvWYXkFdnvRQw/GvHT0S3ixjxfFmY+POb30ndTm KPMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yJcjj7haGvucMnXySnvXK9HbBYpyJX1/61iTTQ3wOsA=; b=AhqAglHKMuZHibU8HvepBaTjH3Nf7UrP1fpSQuljpwLpVS0ZmhrCEAoeYEDHwU+c5G bp/VZZ2PKkAhCb4N+Xr++rBmd60klH0IcFVNlxNWmge0QhwDLZYntcdwWS5Pv6WlwMqF M8d54ItXvgXeSGKtecl+BxPLnrGwQJPBVW2oF6km/vXscPGEQxWLLwxh8HSF0FvsXzZ1 gAdAvY78Hf5b3AkXbYWY0eU/kxP99LdX0t/c8czl2XjUvtUWygs/ApItJZH78y37F5Tz kpYY41QFlAenDSKaMqpmzT29kBMy0s7+tKVnJ7Zq5EeS00w8/EC9DZynLH/n8NFxpw0c PUWg== X-Gm-Message-State: APf1xPCLoe+ICGhfpYG7W32apdrw58q+YVeascP6rzWTKmm+Zjw20Jbo TfJSTy0id9RgLem5X2fu8pgyvddhNh9HHhXJnF0= X-Google-Smtp-Source: AH8x224Lb4Tn6KkbGBOK4elTXVDQGVxYIV+yxp3q7O7YQ0+/J1t+linnS+V9sOvYXVNzUWtjryRGhX+SAURsfrgyYsY= X-Received: by 10.46.53.23 with SMTP id z23mr618345ljz.113.1519158968624; Tue, 20 Feb 2018 12:36:08 -0800 (PST) Original-Received: by 10.25.16.33 with HTTP; Tue, 20 Feb 2018 12:35:27 -0800 (PST) In-Reply-To: <87r2pfcvil.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222947 Archived-At: --f4f5e8079970aeb1070565aac24e Content-Type: text/plain; charset="UTF-8" > I think the slowdown was being caused by a > repeated call to package-initialize, which I now avoid by disabling > package-enable-at-startup in early-init-file. Might it be a good idea to have `package-initialize' signal a warning if it's called multiple times? I hadn't considered this side effect of the change, but at least it's easier to get users to remove a duplicate call than to add a missing one. Are there ever circumstances where calling `package-initialize' more than once makes sense? Perhaps we can allow for those by introducing a variable `package-warn-on-reinitialization' or somesuch, which would be set to non-nil in `package-initialize', and then next time around produce a warning, but then could be set back to nil to suppress the warning. --f4f5e8079970aeb1070565aac24e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> I think the slowdown= was being caused by a
> repeated call to package-initialize, which I now avo= id by disabling
> package-enable-at-startup in early-init-file.

Might it be a good idea to have `package-initialize' sig= nal a warning if it's
called multiple times? I hadn't considered this side effect of the cha= nge,
but at least it'= s=C2=A0easier to get users to remov= e a duplicate call than to add
a missing one.

=
Are there ever circumsta= nces where calling `package-initialize' more than
once makes sense? Perhaps we can allow for tho= se by introducing a
varia= ble `package-warn-on-reinitialization' or somesuch, which would be
set to non-nil in `package-in= itialize', and then next time around produce a
warning, but then could be set back to nil to sup= press the warning.
--f4f5e8079970aeb1070565aac24e--