unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alp Aker <alptekin.aker@gmail.com>
To: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
Cc: Emacs devel <emacs-devel@gnu.org>
Subject: Re: Patch for build failure on OS X (under review)
Date: Tue, 6 May 2014 16:10:38 -0400	[thread overview]
Message-ID: <CACxch4r1hUohRqGUcvxHdyQS2--OzGYcLhON+ZU+Q9SG15xEPQ@mail.gmail.com> (raw)
In-Reply-To: <CACxch4oos2tHTYcTXRxh4RKpYy7AUdyu8Ss_h3_gT5KoxKWnrg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

[Apologies for the premature send on the previous.]

Unfortunately, that's not the correct fix.  The code that's causing the
error shouldn't be compiled at all on an NS build; it's in a large block
that's conditioned on HAVE_PNG, which the NS build expects to be false, as
that port supplies its on version of png_load().

The current incorrect configuration behavior appears to have been caused by:

revno: 117059
fixes bug: http://debbugs.gnu.org/17339
committer: Paul Eggert <eggert@cs.ucla.edu>
branch nick: trunk
timestamp: Sun 2014-05-04 14:28:08 -0700
message:
  Consult libpng-config more consistently.

  This is mainly for simplicity, but it should also avoid
  some future problems like the ones we recently had with NetBSD.
  * configure.ac (LIBPNG): Configure after LIBZ.  Use libpng-config
  for cflags, too.  Append -lz if we're not already doing that with
  LIBZ.  Do not bother appending -lm, since we always append that.
  Coalesce some duplicate code.
  * src/Makefile.in (PNG_CFLAGS): New var.
  (ALL_CFLAGS): Use it.
  * src/image.c [HAVE_PNG]: Don't worry about <libpng/png.h>, as
  CFLAGS now handles this.

[-- Attachment #2: Type: text/html, Size: 1408 bytes --]

  reply	other threads:[~2014-05-06 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  2:39 Patch for build failure on OS X (under review) Andrew Schwartzmeyer
2014-05-06 20:06 ` Alp Aker
2014-05-06 20:10   ` Alp Aker [this message]
2014-05-06 21:16     ` Paul Eggert
2014-05-07  7:14       ` Harald Hanche-Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACxch4r1hUohRqGUcvxHdyQS2--OzGYcLhON+ZU+Q9SG15xEPQ@mail.gmail.com \
    --to=alptekin.aker@gmail.com \
    --cc=andrew@schwartzmeyer.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).