From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Elijah G Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin Date: Wed, 13 Mar 2024 19:50:59 -0600 Message-ID: References: <87r0gfajlh.fsf@posteo.net> <868r2mtjdk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000005cd8aa0613952069" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2031"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 14 02:52:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkaGO-0000Jf-Mz for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Mar 2024 02:52:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkaFc-0004jX-Rp; Wed, 13 Mar 2024 21:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkaFb-0004in-Kr for emacs-devel@gnu.org; Wed, 13 Mar 2024 21:51:19 -0400 Original-Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkaFZ-0007Sf-SE; Wed, 13 Mar 2024 21:51:19 -0400 Original-Received: by mail-qt1-x841.google.com with SMTP id d75a77b69052e-42ef1822b07so2590451cf.0; Wed, 13 Mar 2024 18:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710381074; x=1710985874; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qmlfnkGKy+g3/8iHjHd3ywptHF5S6ZMjHIFf2SuK3Tg=; b=f5hiD0wZUMakU0SB7rO8etmhC3s3uoJ9DFBnE5bYeOwcGmnNm0d2TZuFe8O0jvyRC9 muQ9QEerqGi8U2Hsn6GWtFttfs03KSNbjdW0iTXeqCP9isduiNxhIq3TyJCuatQl+4uR MPx/A/CCMxtjFowrlnIs0xyXr8K1jbmC94IWeELVWf64nc6Ty07O1zqt1O9U3aYd74M6 ajPAmeiGcuqGcWQYwK1Sfwahfjfc3RAR/BppEuv8kXjDVgcw+QIqfneQkbaVOlgDOHer eXVmmRoMWEL5CWZGvDuVVgYITps7uGDopsQU6cS5wiIQSDn2i1rAd0qCyxONsRu+ppYk 8/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710381074; x=1710985874; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qmlfnkGKy+g3/8iHjHd3ywptHF5S6ZMjHIFf2SuK3Tg=; b=mfDoRIW6rbyYqCk9wKP5fnLncb5+TRXIRNr0KVW3uouWKbNDOtI4gAxyhez7MoyKZ+ IfGwkEd8zyDsdMcwwL9pzKi6PSRJWhgEJzhe4YHAbyCZ70nbtrogRAGYhJfd1+2TVzLn aU++oWFBJhpga8frF+upNjsZ4zo+UqI/yt5gbccn5bCPGqqMGi6ZvsmXziRILu4CnaVD psMs1H44aqdwkjWA6eUJzgcLtgzJuNPAP79V4coaEaJLo8SDXDxC8dSh2eOYoS0WlT0P GGnXZRsCGnW6P/fmkcB/aQQz+JRhS+61veyXvomLPYr4f965WXKhroJsEq26jojZ0SvA j0+A== X-Forwarded-Encrypted: i=1; AJvYcCW5/MfC6hKZTNZKb5hD6xA+vlHLjWWEd9brjpLI+fxolD6VRdM7rIFsc8FhfOi2iRuWns2a8RPm2VYE8zLsA1nGcc5x X-Gm-Message-State: AOJu0YxZY/z35St8QXTM9aHxa92bBxcbGQ77jwHC7N/K9i6tqLqfGqts tAao2WgOsFiTWL0X+DkCi2j8qSfYnoLf2UHXZj5aU2Q1VD6Ltb9Aor6SxwAdhA0mAIseOFKUCW3 qrRT5XvnpMN+bn46ETGBSkWBqKcR1bwFQeRE3uA== X-Google-Smtp-Source: AGHT+IGDIB4nN0tKzAw9RGhcr15KLIzT49RK/oaCxPB2KD9ARCT6qokkcpJdLXYSAzbFmko1bvgF2YhVbhkW7cLSBqw= X-Received: by 2002:a05:622a:1647:b0:42e:7999:3f58 with SMTP id y7-20020a05622a164700b0042e79993f58mr359640qtj.57.1710381074256; Wed, 13 Mar 2024 18:51:14 -0700 (PDT) In-Reply-To: <868r2mtjdk.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::841; envelope-from=eg642616@gmail.com; helo=mail-qt1-x841.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317038 Archived-At: --0000000000005cd8aa0613952069 Content-Type: multipart/alternative; boundary="0000000000005cd8a70613952067" --0000000000005cd8a70613952067 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2024 at 6:18=E2=80=AFAM Eli Zaretskii wrote: > > From: Elijah G > > Date: Tue, 12 Mar 2024 11:22:04 -0600 > > Cc: emacs-devel@gnu.org > > > > Thank you, I've fixed my patch. > > Thanks, I have a few more comments below. > > > Also I merged every flymake *-bitmap variable > > into a single user option. > > I think this is a mistake: it makes this change backward-incompatible, > in the sense that users who had customizations of the options you are > removing will now have to rework their customizations. We try to > avoid backward-incompatible changes like this as much as possible. It > doesn't sound to me like this part of the patch is strictly needed, is > it? > You are right, i was planning something like marking those variables as deprecated for 30, but since it makes backward incompatible think it can be too early to do it in this patch, However I find merging them easier to customize instead of defining them separately. If these variables are necessary, I've now reverted the changes in the patch. > + :type '(choice (const :tag "Use Fringes" fringes) > > + (const :tag "Use Margins "margins) > ^^ > A typo there. > Thanks, I've fixed it. > +(defcustom flymake-margin-indicators-string '((error "=E2=80=BC" > compilation-error) > > This is a non-ASCII character, so we should either use its ASCII > equivalent "!!" or test the display for being able to show it on the > screen (since it is likely the margin indicator will be used on TTY > frames). > > Please also accompany your patch with the ChangeLog-style commit log > message (see the file CONTRIBUTE for the details). > --0000000000005cd8a70613952067 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 13, 2024 at 6:18=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Elijah G <eg642616@gmail.com>
> Date: Tue, 12 Mar 2024 11:22:04 -0600
> Cc: emacs-dev= el@gnu.org
>
> Thank you, I've fixed my patch.

Thanks, I have a few more comments below.

> Also I merged every flymake *-bitmap variable
> into a single user option.

I think this is a mistake: it makes this change backward-incompatible,
in the sense that users who had customizations of the options you are
removing will now have to rework their customizations.=C2=A0 We try to
avoid backward-incompatible changes like this as much as possible.=C2=A0 It=
doesn't sound to me like this part of the patch is strictly needed, is<= br> it?
=C2=A0
You are right, i was planning som= ething like marking those variables as deprecated for 30,
but sin= ce it makes backward incompatible think it can be too early to do it in this patch,
However I find= merging them easier to customize instead of defining them separately.

If these variables are necessary, I've now reverte= d the changes in the patch.

> +=C2=A0 :type '(choice (const :tag "Use Fringes" fringes= )
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(const = :tag "Use Margins "margins)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ^^
A typo there.
=C2=A0
Thanks, I've fixed = it.

> +(defcustom flymake-margin-indicators-string '((error "=E2=80= =BC" compilation-error)

This is a non-ASCII character, so we should either use its ASCII
equivalent "!!" or test the display for being able to show it on = the
screen (since it is likely the margin indicator will be used on TTY
frames).

Please also accompany your patch with the ChangeLog-style commit log
message (see the file CONTRIBUTE for the details).
<= /div> --0000000000005cd8a70613952067-- --0000000000005cd8aa0613952069 Content-Type: application/octet-stream; name="0001-Flymake-Support-Indicator-Errors-in-Margin.patch" Content-Disposition: attachment; filename="0001-Flymake-Support-Indicator-Errors-in-Margin.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ltqkn88w0 RnJvbSBmMDI4NzdjNjAzMzdmZDg3M2ZiMDRhZjI1NjNlMDYzZDA1NzYyZDQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGlhcyBHIDxlZzY0MjYxNkBnbWFpbC5jb20+CkRhdGU6IE1v biwgMTEgTWFyIDIwMjQgMTM6MzU6MDYgLTA2MDAKU3ViamVjdDogW1BBVENIXSBGbHltYWtlIFN1 cHBvcnQgSW5kaWNhdG9yIEVycm9ycyBpbiBNYXJnaW4KCkFkZCBzdXBwb3J0IGZvciBkaXNwbGF5 aW5nIGZseW1ha2UgZXJyb3JzIGluIG1hcmdpbiB3aGljaAphbGxvd3MgZGlzcGxheWluZyBpbiBi b3RoIGdyYXBoaWNhbCBhbmQgdGV4dCBkaXNwbGF5cwoKKiBsaXNwL3Byb2dtb2Rlcy9mbHltYWtl LmVsIChmbHltYWtlLW1hcmdpbi1pbmRpY2F0b3JzLXN0cmluZywKZmx5bWFrZS1pbmRpY2F0b3It dHlwZSk6IE5ldy4KKGZseW1ha2UtLWZyaW5nZS1vdmVybGF5LXNwZWMsIGZseW1ha2UtLWVxdWFs LWRpYWdub3N0aWMtcCk6IFJld29yay4KKGZseW1ha2UtZXJyb3IsIGZseW1ha2Utd2FybmluZywg Zmx5bWFrZS1ub3RlKTogVXNlIG5ldyBtYXJnaW4gdmFsdWUuCi0tLQogbGlzcC9wcm9nbW9kZXMv Zmx5bWFrZS5lbCB8IDkzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDc5IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2xpc3AvcHJvZ21vZGVzL2ZseW1ha2UuZWwgYi9saXNwL3Byb2dtb2Rlcy9mbHltYWtl LmVsCmluZGV4IGRiMDBjYzU5YzBlLi5kYTdlMDA3OWZjNiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9n bW9kZXMvZmx5bWFrZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9mbHltYWtlLmVsCkBAIC0xODAs NiArMTgwLDUyIEBAIFNlZSBgZmx5bWFrZS1lcnJvci1iaXRtYXAnIGFuZCBgZmx5bWFrZS13YXJu aW5nLWJpdG1hcCcuIgogCQkgKGNvbnN0IHJpZ2h0LWZyaW5nZSkKIAkJIChjb25zdCA6dGFnICJO byBmcmluZ2UgaW5kaWNhdG9ycyIgbmlsKSkpCiAKKyhkZWZjdXN0b20gZmx5bWFrZS1pbmRpY2F0 b3ItdHlwZSAnZnJpbmdlcworICAiSW5kaWNhdGUgd2hpY2ggaW5kaWNhdG9yIHR5cGUgdG8gdXNl IGZvciBkaXNwbGF5IGVycm9ycy4KKworVGhlIHZhbHVlIGNhbiBiZSBuaWwgKGRvbnQgaW5kaWNh dGUgZXJyb3JzIGJ1dCBqdXN0IGhpZ2hsaWdodCB0aGVtKSwKK2ZyaW5nZXMgKHVzZSBmcmluZ2Vz KSBvciBtYXJnaW5zICh1c2UgbWFyZ2lucykKKworRGlmZmVyZW5jZSBiZXR3ZWVuIGZyaW5nZXMg YW5kIG1hcmdpbiBpcyB0aGF0IGZyaW5nZXMgc3VwcG9ydCBkaXBsYXlpbmcKK2JpdG1hcHMgb24g Z3JhcGhpY2FsIGRpc3BsYXlzIGFuZCBtYXJnaW5zIGRpc3BsYXkgdGV4dCBpbiBhIGJsYW5rIGFy ZWEKK29mIGJ1ZmZlciB0aGF0IHdvcmtzIGluIGJvdGggZ3JhcGhpY2FsIGFuZCB0ZXh0IGRpc3Bs YXlzLgorCitTZWUgSW5mbyBub2RlIGBGcmluZ2VzJyBhbmQgSW5mbyBub2RlIGAoZWxpc3ApRGlz cGxheSBNYXJnaW5zJy4iCisgIDp2ZXJzaW9uICIzMC4xIgorICA6dHlwZSAnKGNob2ljZSAoY29u c3QgOnRhZyAiVXNlIEZyaW5nZXMiIGZyaW5nZXMpCisgICAgICAgICAgICAgICAgIChjb25zdCA6 dGFnICJVc2UgTWFyZ2lucyIgbWFyZ2lucykKKyAgICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcg Ik5vIGluZGljYXRvcnMiIG5pbCkpKQorCisoZGVmY3VzdG9tIGZseW1ha2UtbWFyZ2luLWluZGlj YXRvcnMtc3RyaW5nCisgIGAoKGVycm9yICwoaWYgKGNoYXItZGlzcGxheWFibGUtcCA4MjUyKQor ICAgICAgICAgICAgICAgIuKAvCIKKyAgICAgICAgICAgICAiISEiKQorICAgICBjb21waWxhdGlv bi1lcnJvcikKKyAgICAod2FybmluZyAiISIgY29tcGlsYXRpb24td2FybmluZykKKyAgICAobm90 ZSAiISIgY29tcGlsYXRpb24taW5mbykpCisgICJTdHJpbmdzIHVzZWQgZm9yIG1hcmdpbnMgaW5k aWNhdG9ycy4KK1RoZSB2YWx1ZSBvZiBlYWNoIGxpc3QgbWF5IGJlIGEgbGlzdCBvZiAzIGVsZW1l bnRzIHdoZXJlIHNwZWNpZmllcyB0aGUKK2Vycm9yIHR5cGUsIGl0cyBzdHJpbmcgdG8gdXNlIGFu ZCBpdHMgZmFjZSwKK29yIGEgbGlzdCBvZiAyIGVsZW1lbnRzIHNwZWNpZnlpbmcgb25seSB0aGUg ZXJyb3IgdHlwZSBhbmQgaXRzIHN0cmluZy4KKworVGhlIG9wdGlvbiBgZmx5bWFrZS1tYXJnaW4t aW5kaWNhdG9yLXBvc2l0aW9uJyBjb250cm9scyBob3cgYW5kIHdoZXJlCit0aGlzIGlzIHVzZWQu IgorICA6dmVyc2lvbiAiMzAuMSIKKyAgOnR5cGUgJyhyZXBlYXQgOnRhZyAiRXJyb3IgdHlwZXMg bGlzdHMiCisgICAgICAgICAgICAgICAgIChsaXN0IDp0YWcgIlN0cmluZyBhbmQgZmFjZSBmb3Ig ZXJyb3IgdHlwZXMiCisgICAgICAgICAgICAgICAgICAgICAgIChzeW1ib2wgOnRhZyAiRXJyb3Ig dHlwZSIpCisgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiU3RyaW5nIikKKyAg ICAgICAgICAgICAgICAgICAgICAgKGZhY2UgOnRhZyAiRmFjZSIpKSkpCisKKyhkZWZjdXN0b20g Zmx5bWFrZS1tYXJnaW4taW5kaWNhdG9yLXBvc2l0aW9uICdsZWZ0LW1hcmdpbgorICAiVGhlIHBv c2l0aW9uIHRvIHB1dCBGbHltYWtlIG1hcmdpbiBpbmRpY2F0b3IuCitUaGUgdmFsdWUgY2FuIGJl IG5pbCAoZG8gbm90IHVzZSBpbmRpY2F0b3JzKSwgYGxlZnQtbWFyZ2luJyBvciBgcmlnaHQtbWFy Z2luJy4KK1NlZSBgZmx5bWFrZS1lcnJvci1tYXJnaW4tc3RyaW5nJyBhbmQgYGZseW1ha2Utd2Fy bmluZy1tYXJnaW4tc3RyaW5nJy4iCisgIDp2ZXJzaW9uICIzMC4xIgorICA6dHlwZSAnKGNob2lj ZSAoY29uc3QgbGVmdC1tYXJnaW4pCisgICAgICAgICAgICAgICAgIChjb25zdCByaWdodC1tYXJn aW4pCisgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJObyBtYXJnaW4gaW5kaWNhdG9ycyIg bmlsKSkpCisKIChtYWtlLW9ic29sZXRlLXZhcmlhYmxlICdmbHltYWtlLXN0YXJ0LXN5bnRheC1j aGVjay1vbi1uZXdsaW5lCiAJCSAgICAgICAgImNhbiBjaGVjayBvbiBuZXdsaW5lIGluIHBvc3Qt c2VsZi1pbnNlcnQtaG9vayIKICAgICAgICAgICAgICAgICAgICAgICAgICIyNy4xIikKQEAgLTYz MCw2ICs2NzYsNyBAQCBOb2RlIGAoRmx5bWFrZSlGbHltYWtlIGVycm9yIHR5cGVzJyIKIAogKHB1 dCAnZmx5bWFrZS1lcnJvciAnZmFjZSAnZmx5bWFrZS1lcnJvcikKIChwdXQgJ2ZseW1ha2UtZXJy b3IgJ2ZseW1ha2UtYml0bWFwICdmbHltYWtlLWVycm9yLWJpdG1hcCkKKyhwdXQgJ2ZseW1ha2Ut ZXJyb3IgJ2ZseW1ha2UtbWFyZ2luLXN0cmluZyAoYWxpc3QtZ2V0ICdlcnJvciBmbHltYWtlLW1h cmdpbi1pbmRpY2F0b3JzLXN0cmluZykpCiAocHV0ICdmbHltYWtlLWVycm9yICdzZXZlcml0eSAo d2FybmluZy1udW1lcmljLWxldmVsIDplcnJvcikpCiAocHV0ICdmbHltYWtlLWVycm9yICdtb2Rl LWxpbmUtZmFjZSAnZmx5bWFrZS1lcnJvci1lY2hvKQogKHB1dCAnZmx5bWFrZS1lcnJvciAnZWNo by1mYWNlICdmbHltYWtlLWVycm9yLWVjaG8pCkBAIC02MzgsNiArNjg1LDcgQEAgTm9kZSBgKEZs eW1ha2UpRmx5bWFrZSBlcnJvciB0eXBlcyciCiAKIChwdXQgJ2ZseW1ha2Utd2FybmluZyAnZmFj ZSAnZmx5bWFrZS13YXJuaW5nKQogKHB1dCAnZmx5bWFrZS13YXJuaW5nICdmbHltYWtlLWJpdG1h cCAnZmx5bWFrZS13YXJuaW5nLWJpdG1hcCkKKyhwdXQgJ2ZseW1ha2Utd2FybmluZyAnZmx5bWFr ZS1tYXJnaW4tc3RyaW5nIChhbGlzdC1nZXQgJ3dhcm5pbmcgZmx5bWFrZS1tYXJnaW4taW5kaWNh dG9ycy1zdHJpbmcpKQogKHB1dCAnZmx5bWFrZS13YXJuaW5nICdzZXZlcml0eSAod2FybmluZy1u dW1lcmljLWxldmVsIDp3YXJuaW5nKSkKIChwdXQgJ2ZseW1ha2Utd2FybmluZyAnbW9kZS1saW5l LWZhY2UgJ2ZseW1ha2Utd2FybmluZy1lY2hvKQogKHB1dCAnZmx5bWFrZS13YXJuaW5nICdlY2hv LWZhY2UgJ2ZseW1ha2Utd2FybmluZy1lY2hvKQpAQCAtNjQ2LDYgKzY5NCw3IEBAIE5vZGUgYChG bHltYWtlKUZseW1ha2UgZXJyb3IgdHlwZXMnIgogCiAocHV0ICdmbHltYWtlLW5vdGUgJ2ZhY2Ug J2ZseW1ha2Utbm90ZSkKIChwdXQgJ2ZseW1ha2Utbm90ZSAnZmx5bWFrZS1iaXRtYXAgJ2ZseW1h a2Utbm90ZS1iaXRtYXApCisocHV0ICdmbHltYWtlLW5vdGUgJ2ZseW1ha2UtbWFyZ2luLXN0cmlu ZyAoYWxpc3QtZ2V0ICdub3RlIGZseW1ha2UtbWFyZ2luLWluZGljYXRvcnMtc3RyaW5nKSkKIChw dXQgJ2ZseW1ha2Utbm90ZSAnc2V2ZXJpdHkgKHdhcm5pbmctbnVtZXJpYy1sZXZlbCA6ZGVidWcp KQogKHB1dCAnZmx5bWFrZS1ub3RlICdtb2RlLWxpbmUtZmFjZSAnZmx5bWFrZS1ub3RlLWVjaG8p CiAocHV0ICdmbHltYWtlLW5vdGUgJ2VjaG8tZmFjZSAnZmx5bWFrZS1ub3RlLWVjaG8pCkBAIC02 ODIsMTkgKzczMSwzMiBAQCBhc3NvY2lhdGVkIGBmbHltYWtlLWNhdGVnb3J5JyByZXR1cm4gREVG QVVMVC4iCiAgIChmbHltYWtlLS1sb29rdXAtdHlwZS1wcm9wZXJ0eSB0eXBlICdzZXZlcml0eQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdhcm5pbmctbnVtZXJpYy1sZXZlbCA6 ZXJyb3IpKSkKIAotKGRlZnVuIGZseW1ha2UtLWZyaW5nZS1vdmVybGF5LXNwZWMgKGJpdG1hcCAm b3B0aW9uYWwgcmVjdXJzZWQpCi0gIChpZiAoYW5kIChzeW1ib2xwIGJpdG1hcCkKLSAgICAgICAg ICAgKGJvdW5kcCBiaXRtYXApCi0gICAgICAgICAgIChub3QgcmVjdXJzZWQpKQotICAgICAgKGZs eW1ha2UtLWZyaW5nZS1vdmVybGF5LXNwZWMKLSAgICAgICAoc3ltYm9sLXZhbHVlIGJpdG1hcCkg dCkKLSAgICAoYW5kIGZseW1ha2UtZnJpbmdlLWluZGljYXRvci1wb3NpdGlvbgotICAgICAgICAg Yml0bWFwCi0gICAgICAgICAocHJvcGVydGl6ZSAiISIgJ2Rpc3BsYXkKLSAgICAgICAgICAgICAg ICAgICAgIChjb25zIGZseW1ha2UtZnJpbmdlLWluZGljYXRvci1wb3NpdGlvbgotICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGlmIChsaXN0cCBiaXRtYXApCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYml0bWFwCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0IGJp dG1hcCkpKSkpKSkKKyhkZWZ1biBmbHltYWtlLS1mcmluZ2Utb3ZlcmxheS1zcGVjIChpbmRpY2F0 b3IpCisgICJSZXR1cm4gSU5ESUNBVE9SIGFzIHByb3BlcnRpemVkIHN0cmluZyB0byB1c2UgaW4g ZXJyb3IgaW5kaWNhdG9ycy4iCisgIChsZXQqICgodmFsdWUgKGlmIChzeW1ib2xwIGluZGljYXRv cikKKyAgICAgICAgICAgICAgICAgICAgKHN5bWJvbC12YWx1ZSBpbmRpY2F0b3IpCisgICAgICAg ICAgICAgICAgICBpbmRpY2F0b3IpKQorICAgICAgICAgKGluZGljYXRvci1jYXIgKGlmIChsaXN0 cCB2YWx1ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FyIHZhbHVlKQorICAgICAg ICAgICAgICAgICAgICAgICAgICB2YWx1ZSkpCisgICAgICAgICAoaW5kaWNhdG9yLWNkciAoaWYg KGxpc3RwIHZhbHVlKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjZHIgdmFsdWUpKSkp CisgICAgKGNvbmQKKyAgICAgKChzeW1ib2xwIGluZGljYXRvci1jYXIpCisgICAgICAocHJvcGVy dGl6ZSAiISIgJ2Rpc3BsYXkKKyAgICAgICAgICAgICAgICAgIChjb25zIGZseW1ha2UtZnJpbmdl LWluZGljYXRvci1wb3NpdGlvbgorICAgICAgICAgICAgICAgICAgICAgICAgKGlmIChsaXN0cCB2 YWx1ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZQorICAgICAgICAgICAgICAg ICAgICAgICAgICAobGlzdCB2YWx1ZSkpKSkpCisgICAgICgoc3RyaW5ncCBpbmRpY2F0b3ItY2Fy KQorICAgICAgKHByb3BlcnRpemUgIiEiCisgICAgICAgICAgICAgICAgICAnZGlzcGxheQorICAg ICAgICAgICAgICAgICAgYCgobWFyZ2luICxmbHltYWtlLW1hcmdpbi1pbmRpY2F0b3ItcG9zaXRp b24pCisgICAgICAgICAgICAgICAgICAgICwocHJvcGVydGl6ZQorICAgICAgICAgICAgICAgICAg ICAgIGluZGljYXRvci1jYXIKKyAgICAgICAgICAgICAgICAgICAgICAnZmFjZQorICAgICAgICAg ICAgICAgICAgICAgIGAoOmluaGVyaXQgKCxpbmRpY2F0b3ItY2RyCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZGVmYXVsdCkpKSkpKSkpKQogCiAoZGVmdW4gZmx5bWFrZS0tZXF1 YWwtZGlhZ25vc3RpYy1wIChhIGIpCiAgICJUZWxsIGlmIEEgYW5kIEIgYXJlIGVxdWl2YWxlbnQg YGZseW1ha2UtLWRpYWcnIG9iamVjdHMuIgpAQCAtODQzLDcgKzkwNSwxMCBAQCBSZXR1cm4gbmls IG9yIHRoZSBvdmVybGF5IGNyZWF0ZWQuIgogICAgICAgICAoZmx5bWFrZS0tZnJpbmdlLW92ZXJs YXktc3BlYwogICAgICAgICAgKGZseW1ha2UtLWxvb2t1cC10eXBlLXByb3BlcnR5CiAgICAgICAg ICAgdHlwZQotICAgICAgICAgICdmbHltYWtlLWJpdG1hcAorICAgICAgICAgIChjb25kICgoZXEg Zmx5bWFrZS1pbmRpY2F0b3ItdHlwZSAnZnJpbmdlcykKKyAgICAgICAgICAgICAgICAgJ2ZseW1h a2UtYml0bWFwKQorICAgICAgICAgICAgICAgICgoZXEgZmx5bWFrZS1pbmRpY2F0b3ItdHlwZSAn bWFyZ2lucykKKyAgICAgICAgICAgICAgICAgJ2ZseW1ha2UtbWFyZ2luLXN0cmluZykpCiAgICAg ICAgICAgKGFsaXN0LWdldCAnYml0bWFwIChhbGlzdC1nZXQgdHlwZSA7IGJhY2t3YXJkIGNvbXBh dAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZseW1ha2UtZGlhZ25v c3RpYy10eXBlcy1hbGlzdCkpKSkpCiAgICAgICA7OyAoZGVmYXVsdC1tYXliZSAnYWZ0ZXItc3Ry aW5nCi0tIAoyLjQ0LjAud2luZG93cy4xCgo= --0000000000005cd8aa0613952069--