From: Steven Degutis <sbdegutis@gmail.com>
To: emacs-devel@gnu.org
Subject: Patch to ido.el
Date: Fri, 5 Apr 2013 01:31:57 -0500 [thread overview]
Message-ID: <CACeWA3ieWhLBsiNuscdJfBH-fPVC9L=Oc=cviSF=5XqCAoXrwA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2228 bytes --]
Disclaimer: I have absolutely no idea how this process works.
This patch makes ido.el slightly more configurable.
In particular, when using ido-decorations that make ido-mode display
vertically (per http://emacswiki.org/emacs/InteractivelyDoThings#toc20), a
pair of decorations are being used in two different places with two
different meanings, even though by happenstance they look the same. This
patch splits them out into two different pairs of decorations (which
currently have the same value), allowing the user to customize them with
greater precision.
diff --git ido.el ido2.el
index cda4021..dfb5b0a 100644
--- ido.el
+++ ido2.el
@@ -763,7 +763,7 @@ Obsolete. Set 3rd element of `ido-decorations'
instead."
:type '(choice string (const nil))
:group 'ido)
-(defcustom ido-decorations '( "{" "}" " | " " | ..." "[" "]" " [No match]"
" [Matched]" " [Not readable]" " [Too big]" " [Confirm]")
+(defcustom ido-decorations '( "{" "}" " | " " | ..." "[" "]" " [No match]"
" [Matched]" " [Not readable]" " [Too big]" " [Confirm]" "[" "]")
"List of strings used by ido to display the alternatives in the
minibuffer.
There are 11 elements in this list:
1st and 2nd elements are used as brackets around the prospect list,
@@ -4570,9 +4570,9 @@ For details of keybindings, see `ido-find-file'."
(ido-name (car comps))))
""
;; when there is one match, show the matching file
name in full
- (concat (nth 4 ido-decorations) ;; [ ... ]
+ (concat (nth 11 ido-decorations) ;; [ ... ]
(ido-name (car comps))
- (nth 5 ido-decorations)))
+ (nth 12 ido-decorations)))
(if (not ido-use-faces) (nth 7 ido-decorations)))) ;; [Matched]
(t ;multiple matches
(let* ((items (if (> ido-max-prospects 0) (1+ ido-max-prospects) 999))
So, now that I've said everything that can probably be said on the topic,
how do I go about submitting this patch for review to the official emacs
repo? Does this email count? Or maybe someone in here knows how to do it in
like 3 seconds flat and wouldn't mind?
-Steven
[-- Attachment #2: Type: text/html, Size: 3310 bytes --]
next reply other threads:[~2013-04-05 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 6:31 Steven Degutis [this message]
2013-04-05 10:30 ` Patch to ido.el Óscar Fuentes
2013-04-05 11:07 ` Xue Fuqiao
2013-04-05 15:55 ` Steven Degutis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACeWA3ieWhLBsiNuscdJfBH-fPVC9L=Oc=cviSF=5XqCAoXrwA@mail.gmail.com' \
--to=sbdegutis@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).