unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Carsten Mattner <carstenmattner@gmail.com>
To: Leo <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: ido regression in trunk?
Date: Fri, 28 Sep 2012 10:33:37 +0200	[thread overview]
Message-ID: <CACY+Hvqq0V0gUywmDougKKOnfNuoO0Gp86seDT-FAvVQNgiYVA@mail.gmail.com> (raw)
In-Reply-To: <m2y5jux1mn.fsf@gmail.com>

On Fri, Sep 28, 2012 at 5:33 AM, Leo <sdl.web@gmail.com> wrote:
> On 2012-09-28 02:19 +0800, Carsten Mattner wrote:
>> Did anyone else notice that opening files with ido enabled
>> doesn't work as it did last week in current trunk?
>>
>> The fuzzy match of file/dir to open always open the first
>> item of the list even if I continue typing a more precise
>> different sub-directory which is not the first entry of the list.
>>
>> I cannot imagine this to go unnoticed.
>
> On 2012-09-28 07:05 +0800, Christopher Monsanto wrote:
>> I've noticed this problem as well, very irritating. If the maintainer
>> of ido doesn't know what's up, I can do a bisect to find the problem.
>>
>> Christopher Monsanto
>> chris@monsan.to  --  http://monsan.to/
>
> Sorry to all. It is my fault. I will install the following fix later
> today:
>
> diff --git a/lisp/ido.el b/lisp/ido.el
> index d48e7ba8..f511dbbf 100644
> --- a/lisp/ido.el
> +++ b/lisp/ido.el
> @@ -3701,14 +3701,14 @@ (defun ido-set-matches-1 (items &optional do-full)
>          (rexq (concat rex0 (if slash ".*/" "")))
>          (re (if ido-enable-prefix (concat "\\`" rexq) rexq))
>          (full-re (and do-full
> -                      (and (eq ido-cur-item 'buffer)
> -                           (not ido-buffer-disable-smart-matches))
> +                      (not (and (eq ido-cur-item 'buffer)
> +                                ido-buffer-disable-smart-matches))
>                        (not ido-enable-regexp)
>                        (not (string-match "\$\\'" rex0))
>                        (concat "\\`" rex0 (if slash "/" "") "\\'")))
>          (suffix-re (and do-full slash
> -                        (and (eq ido-cur-item 'buffer)
> -                             (not ido-buffer-disable-smart-matches))
> +                        (not (and (eq ido-cur-item 'buffer)
> +                                  ido-buffer-disable-smart-matches))
>                          (not ido-enable-regexp)
>                          (not (string-match "\$\\'" rex0))
>                          (concat rex0 "/\\'")))

Thanks.



  reply	other threads:[~2012-09-28  8:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 18:19 ido regression in trunk? Carsten Mattner
2012-09-27 23:05 ` Christopher Monsanto
2012-09-28  3:33 ` Leo
2012-09-28  8:33   ` Carsten Mattner [this message]
2012-09-28 14:51   ` Leo
2012-09-28 16:58     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACY+Hvqq0V0gUywmDougKKOnfNuoO0Gp86seDT-FAvVQNgiYVA@mail.gmail.com \
    --to=carstenmattner@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).