From: Andrea Cardaci <cyrus.and@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Zoom: a window management minor mode -- best practices and questions
Date: Thu, 3 May 2018 11:47:40 +0200 [thread overview]
Message-ID: <CACMsj9PA6B3yof4J=8QSOYfsKNA+t9zb20a6eQ0d9Ye6njdDbw@mail.gmail.com> (raw)
In-Reply-To: <5AEAB616.4040900@gmx.at>
> There are probably other ones like when a window gets deleted or the
> configuration changes but all these should get caught by your code.
Yep, I forgot to mention when a window gets deleted.
> I'm not sure why hooking 'minibuffer-setup-hook' is needed, I suppose
> it is not, at least for Emacs 26. Other than that your code seems
> valid to me (even disabling 'window-configuration-change-hook' in
> 'balance-windows' is OK, that hook should not get called there any
> more).
`minibuffer-setup-hook` is needed to detect when the minibuffer is
selected because there's an option to preserve the currently zoomed
window in that case to avoid quick and useless layout changes.
> Obviously, 'window-size-change-functions' is meant for applications to
> react to size changes and possibly readjust buffer text shown in a
> window whose size changed. You should warn other applications to make
> sure they _append_ their functions to this hook in order to be aware
> of your adjustments. Maybe you should re-prepend your function when
> you find out that other ones have been prepended in between.
That's a interesting advice.
> Otherwise, I would use 'buffer-list-update-hook' instead of advising
> 'select-window' to make sure that all occurences of selecting a window
> get caught. And I would experimentally try to not zoom immediately in
> 'buffer-list-update-hook' and 'window-configuration-change-hook' but
> simply feed these occurrencs to 'pre-redisplay-function' to reduce the
> number of times you zoom. 'window-pixel-height-before-size-change'
> and 'window-pixel-width-before-size-change' should allow to easily do
> the 'window-size-change-functions' part in 'pre-redisplay-function' as
> well. Though my personal experiences with 'pre-redisplay-function'
> are not bright enough to recommend it for sure.
I will try this approach, thanks.
next prev parent reply other threads:[~2018-05-03 9:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 16:31 Zoom: a window management minor mode -- best practices and questions Andrea Cardaci
2018-05-02 17:32 ` Eli Zaretskii
2018-05-02 18:41 ` Andrea Cardaci
2018-05-02 18:58 ` Eli Zaretskii
2018-05-03 7:11 ` martin rudalics
2018-05-03 9:50 ` Andrea Cardaci
2018-05-03 9:46 ` Andrea Cardaci
2018-05-03 7:11 ` martin rudalics
2018-05-03 9:47 ` Andrea Cardaci [this message]
2018-05-07 12:32 ` Andrea Cardaci
2018-05-07 18:19 ` Eli Zaretskii
2018-05-08 10:40 ` Andrea Cardaci
2018-05-08 14:53 ` Noam Postavsky
2018-05-08 15:03 ` Andrea Cardaci
2018-05-09 12:33 ` Stefan Monnier
2018-05-08 17:52 ` Eli Zaretskii
2018-05-09 7:00 ` martin rudalics
2018-05-09 16:06 ` Andrea Cardaci
2018-05-10 6:27 ` martin rudalics
2018-05-10 10:11 ` Andrea Cardaci
2018-05-10 10:27 ` martin rudalics
2018-05-10 10:34 ` Andrea Cardaci
2018-05-10 10:37 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACMsj9PA6B3yof4J=8QSOYfsKNA+t9zb20a6eQ0d9Ye6njdDbw@mail.gmail.com' \
--to=cyrus.and@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).