* Should `ido-everywhere` override `completing-read-function`?
@ 2017-04-22 1:23 Tianxiang Xiong
2017-04-22 2:45 ` Noam Postavsky
0 siblings, 1 reply; 3+ messages in thread
From: Tianxiang Xiong @ 2017-04-22 1:23 UTC (permalink / raw)
To: Emacs developers
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
In `ido.el`, the `ido-everywhere` minor mode overrides
`read-file-name-function` and `read-buffer-function`. However, it does
*not* override
`completing-read-function` with `ido-completing-read`.
Should it? This is what Helm
<https://github.com/emacs-helm/helm/blob/v2.6.1/helm-mode.el#L1247> does,
and it is convenient for the user.
[-- Attachment #2: Type: text/html, Size: 415 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Should `ido-everywhere` override `completing-read-function`?
2017-04-22 1:23 Should `ido-everywhere` override `completing-read-function`? Tianxiang Xiong
@ 2017-04-22 2:45 ` Noam Postavsky
2017-04-22 2:54 ` Tianxiang Xiong
0 siblings, 1 reply; 3+ messages in thread
From: Noam Postavsky @ 2017-04-22 2:45 UTC (permalink / raw)
To: Tianxiang Xiong; +Cc: Emacs developers
On Fri, Apr 21, 2017 at 9:23 PM, Tianxiang Xiong
<tianxiang.xiong@gmail.com> wrote:
> In `ido.el`, the `ido-everywhere` minor mode overrides
> `read-file-name-function` and `read-buffer-function`. However, it does not
> override `completing-read-function` with `ido-completing-read`.
>
> Should it? This is what Helm does, and it is convenient for the user.
ido-completing-read currently does not entirely replace completing-read,
see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=15430
https://github.com/DarwinAwardWinner/ido-ubiquitous
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Should `ido-everywhere` override `completing-read-function`?
2017-04-22 2:45 ` Noam Postavsky
@ 2017-04-22 2:54 ` Tianxiang Xiong
0 siblings, 0 replies; 3+ messages in thread
From: Tianxiang Xiong @ 2017-04-22 2:54 UTC (permalink / raw)
To: Noam Postavsky; +Cc: Emacs developers
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hmm, interesting. I'll investigate further if time permits.
On Fri, Apr 21, 2017 at 7:45 PM, Noam Postavsky <
npostavs@users.sourceforge.net> wrote:
> On Fri, Apr 21, 2017 at 9:23 PM, Tianxiang Xiong
> <tianxiang.xiong@gmail.com> wrote:
> > In `ido.el`, the `ido-everywhere` minor mode overrides
> > `read-file-name-function` and `read-buffer-function`. However, it does
> not
> > override `completing-read-function` with `ido-completing-read`.
> >
> > Should it? This is what Helm does, and it is convenient for the user.
>
> ido-completing-read currently does not entirely replace completing-read,
> see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=15430
> https://github.com/DarwinAwardWinner/ido-ubiquitous
>
[-- Attachment #2: Type: text/html, Size: 1383 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-22 2:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-22 1:23 Should `ido-everywhere` override `completing-read-function`? Tianxiang Xiong
2017-04-22 2:45 ` Noam Postavsky
2017-04-22 2:54 ` Tianxiang Xiong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).