From: Pranshu Sharma <pranshusharma198@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: hideshow support for treesitter
Date: Fri, 6 Sep 2024 11:18:57 +1000 [thread overview]
Message-ID: <CACKBRFnS7ZdPs9chpBxyYbf5XXaYyf2qvuOgpBW40F1WzMsjhA@mail.gmail.com> (raw)
In-Reply-To: <86v7zaukn3.fsf@mail.linkov.net>
[-- Attachment #1: Type: text/plain, Size: 2437 bytes --]
I am working to try get the hide show working for tree sitter, however one
thing that is missing in treesit is sexp navigation functions, hideshow
requires sexp function.
On Fri, 6 Sept 2024 at 03:04, Juri Linkov <juri@linkov.net> wrote:
> >>>>> Are there any plans to add treesitter support for hideshow, it seems
> easy
> >>>>> enough to do and also very helpful, especially for langs that don't
> >>>>> excessively use parens, such as python
> >>>>
> >>>> Indeed, it's easy to do this. You just need to override
> >>>> hs-find-block-beginning-func, hs-find-next-block-func, etc.
> >>>> with treesit functions like 'treesit-outline-search'.
> >>>
> >>> Ah I see, then I think treesit.el should contain code for this, because
> >>> this seems extremely useful task that would not make sense if each tree
> >>> sitter based major mode was to implement this separately
> >>
> >> Or hideshow code for treesit could be in hideshow.el as well.
> >> The reason why 'treesit-outline-search' was added to treesit.el
> >> was because treesit.el already contained imenu support. But
> >> imenu support could be in imenu.el as well.
> >
> > Is there a preferred way to handle this treesit wise. I know some
> packages
> > (eg imenu) require major modes to define their support for it, but others
> > like ispell do it themselves. I personally thing the latter would be
> better
> > in this case.
>
> I looked at hideshow.el and found such a list:
>
> (defvar hs-special-modes-alist
> (mapcar #'purecopy
> '((c-mode "{" "}" "/[*/]" nil nil)
> (c-ts-mode "{" "}" "/[*/]" nil nil)
> (c++-mode "{" "}" "/[*/]" nil nil)
> (c++-ts-mode "{" "}" "/[*/]" nil nil)
> (bibtex-mode ("@\\S(*\\(\\s(\\)" 1))
> (java-mode "{" "}" "/[*/]" nil nil)
> (java-ts-mode "{" "}" "/[*/]" nil nil)
> (js-mode "{" "}" "/[*/]" nil)
> (js-ts-mode "{" "}" "/[*/]" nil)
> (lua-ts-mode "{\\|\\[\\[" "}\\|\\]\\]" "--" nil)
> (mhtml-mode "{\\|<[^/>]*?" "}\\|</[^/>]*[^/]>" "<!--" mhtml-forward
> nil)
>
> But this is useless for tree-sitter.
>
> Line-oriented treesit-outline-search relied on
> treesit-simple-imenu-settings
> that defines header lines for imenu. And every ts-mode sets own value of
> treesit-simple-imenu-settings. But this can't be used for hideshow.
>
> So whoever will implement hideshow support for treesitter
> will need to design a setting like buffer-local
> treesit-simple-imenu-settings for ts-modes.
>
[-- Attachment #2: Type: text/html, Size: 3431 bytes --]
next prev parent reply other threads:[~2024-09-06 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 4:48 hideshow support for treesitter Pranshu Sharma
2024-09-04 16:08 ` Juri Linkov
[not found] ` <CACKBRFm65s1itFf3YAm=yGaxT-11hbPGR_eu9sgVKtQQZE2fKQ@mail.gmail.com>
[not found] ` <8634mey5us.fsf@mail.linkov.net>
2024-09-05 12:33 ` Pranshu Sharma
2024-09-05 16:42 ` Juri Linkov
2024-09-06 1:18 ` Pranshu Sharma [this message]
2024-09-08 3:41 ` Yuan Fu
2024-09-15 14:28 ` pranshu sharma
2024-09-16 4:39 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKBRFnS7ZdPs9chpBxyYbf5XXaYyf2qvuOgpBW40F1WzMsjhA@mail.gmail.com \
--to=pranshusharma198@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).