From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dalanicolai Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: toc-mode Date: Wed, 21 Sep 2022 09:19:39 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004636d305e92ac552" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28455"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 21 09:37:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oauIF-0007DQ-No for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Sep 2022 09:37:15 +0200 Original-Received: from localhost ([::1]:49136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oauIE-0004be-CN for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Sep 2022 03:37:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oau1W-0005W7-2l for emacs-devel@gnu.org; Wed, 21 Sep 2022 03:20:02 -0400 Original-Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:46592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oau1R-0003Dl-Aq for emacs-devel@gnu.org; Wed, 21 Sep 2022 03:19:55 -0400 Original-Received: by mail-ej1-x633.google.com with SMTP id bj12so11453035ejb.13 for ; Wed, 21 Sep 2022 00:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=bImEYnYiIWKd4JHnyJDf1Dx1yAJXY4HWT4T5r2rPNBo=; b=JbMVIHLegRtjDlTGOvyh+BxhwSKkQ7H19LN5G4i9u0ogFMorvCSxB0UICdm++EagW5 XvTeNXusxkfZFtvXFm7ba0L7TX5qNM9MmZyn2D9i4BQGu1hJs6zJgFrrE2Ob+S+S81F4 FmVA2ioMIdGsIiPbyDvvclymDeAitqvAiJojDVozrc/FigsLSPYlBKnUdahI6o02nLOU 4QWvRHyZRZTf42eYfiqZHk199xZv9dUJ2klYe3r+wowD57WRfe0TV1oaRGoVERn/onsx iw3AUVCb6qqlEelc/SbqLw73uqMQWRP1G8K+uQ6i6iP8kAJEtQaLHwmykBgdwfV3UGxB GdtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=bImEYnYiIWKd4JHnyJDf1Dx1yAJXY4HWT4T5r2rPNBo=; b=2+2kmQYJMGY38bz9pDITycKfE+G6rKulV8RXcG0M0scO+wVrLpyDXXlYso/81G2sQk quRDz2t6jE7V1DuJuJ+Va2Li2HE55txZl2mTMOJVDf0spJCIeeCmCpOalZAp2bN1N1bk 7lwgRQa3ZNguYV49aM6aCofO1wPXqBppESBfjVujHkLuz2SklykSOSEZd3Qc/H+2EPrL mrv46oyGWNbxJD7T/0Hat1DbZg/En5a+TjfW5hEIPxxSruFTHSptWU0B9Ez6TepBos4K Jy5LGnJHz72WakxixaUypF7XoWyf3B9HxvNHCAJDidKmjnzb3+0Bj5NHpIJUeRLY+Ojo TT8Q== X-Gm-Message-State: ACrzQf2diti/1DaqNho1QeS4myrBkQrF0uFtGnSTNfJLX/eIK8jmNDGF 7ztnYzvn9UAxp/r/ToXZrFtvUYN3J5mB1XZzqTxqqcFWKAo= X-Google-Smtp-Source: AMsMyM579FDo0xiQrkcN2a2s4FnzzxeRAFO+o1mBHr+GYAx/+ktvlpg2Afr5UYYDU+6O4f4FvEI+CC0HUzoxmPVNIfE= X-Received: by 2002:a17:907:e8b:b0:779:8ae0:eecf with SMTP id ho11-20020a1709070e8b00b007798ae0eecfmr19981833ejc.735.1663744791162; Wed, 21 Sep 2022 00:19:51 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=dalanicolai@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295865 Archived-At: --0000000000004636d305e92ac552 Content-Type: text/plain; charset="UTF-8" Thanks you all for your answers! On Wed, 21 Sept 2022 at 09:18, dalanicolai wrote: > It seems that somehow I did not receive the answer by Jean, but the > feedback about the name sounds useful. I will think about and rename > the package. > > Actually, I adjusted that copyright line already and got rid of the > compiler > warnings, but indeed I see now that I did not push those 'fixes' yet. > > On Wed, 21 Sept 2022 at 00:03, Stefan Monnier > wrote: > >> > This package has been for a while on MELPA now, but it would be nice if >> it >> > could be moved to ELPA. The source can be found at >> > https://github.com/dalanicolai/toc-mode. >> > >> > I would like to mention that the PDF functionalities largely depend on >> > pdf-tools, which is not on ELPA of course (doc-view unfortunately does >> > not provide the right features). I am not sure if that somehow is >> > a problem. >> >> Since pdf-tools is in NonGNU ELPA, this is not a problem, no. >> >> > The package description is: >> > >> > Create, cleanup, add and manage Table Of Contents (TOC) of pdf and djvu >> > documents with Emacs >> >> Sounds handy, thanks. FWIW, I tend to agree with Jean that the name >> suggests its purpose is more general (more like a kind of speedbar/imenu >> maybe). Furthermore the "-mode" part of the name suggests it's a major >> mode to edit some standard "toc" files rather than an actual tool to >> extract things for non-toc files and then edit those files. >> >> So I'd support a renaming (in case you're out of ideas, maybe >> "toc-edit/edit-doc-toc", tho maybe "create-doc-toc" is more precise >> since it doesn't seem to care very much about editing an existing toc), >> but I don't have a strong opinion about it. >> >> Once you've made up your mind about the package name, let me know so >> I can add it to `elpa.git`. >> >> > ready for ELPA (although I guess it is already ready for publishing on >> > ELPA). >> >> Indeed, except for the copyright line which needs to be adjusted. >> >> The patch below does that along with the obligatory cosmetic tweaks. >> I also include the remaining compilation warnings. >> >> >> Stefan >> > --0000000000004636d305e92ac552 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks you all for your answers!

On Wed, 21 Sept 2022= at 09:18, dalanicolai <dalanic= olai@gmail.com> wrote:
It seems that somehow I did not receive= the answer by Jean, but the
feedback about the name sounds usefu= l. I will think about and rename
the package.

Actually, I adjusted that copyright line already and got rid of the c= ompiler
warnings, but indeed I see now that I did not push those = 'fixes' yet.

On Wed, 21 Sept 2022 at 00:03, Stefan Monnie= r <monnier= @iro.umontreal.ca> wrote:
> This package has been for a while on MELPA now, but i= t would be nice if it
> could be moved to ELPA. The source can be found at
> https://github.com/dalanicolai/toc-mode.
>
> I would like to mention that the PDF functionalities largely depend on=
> pdf-tools, which is not on ELPA of course (doc-view unfortunately does=
> not provide the right features). I am not sure if that somehow is
> a problem.

Since pdf-tools is in NonGNU ELPA, this is not a problem, no.

> The package description is:
>
> Create, cleanup, add and manage Table Of Contents (TOC) of pdf and djv= u
> documents with Emacs

Sounds handy, thanks.=C2=A0 FWIW, I tend to agree with Jean that the name suggests its purpose is more general (more like a kind of speedbar/imenu maybe).=C2=A0 Furthermore the "-mode" part of the name suggests i= t's a major
mode to edit some standard "toc" files rather than an actual tool= to
extract things for non-toc files and then edit those files.

So I'd support a renaming (in case you're out of ideas, maybe
"toc-edit/edit-doc-toc", tho maybe "create-doc-toc" is = more precise
since it doesn't seem to care very much about editing an existing toc),=
but I don't have a strong opinion about it.

Once you've made up your mind about the package name, let me know so I can add it to `elpa.git`.

> ready for ELPA (although I guess it is already ready for publishing on=
> ELPA).

Indeed, except for the copyright line which needs to be adjusted.

The patch below does that along with the obligatory cosmetic tweaks.
I also include the remaining compilation warnings.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan
--0000000000004636d305e92ac552--