From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dalanicolai Newsgroups: gmane.emacs.devel Subject: Re: Request for review `image-roll.el` for Emacs core (or ELPA) Date: Tue, 19 Apr 2022 09:18:11 +0200 Message-ID: References: <87k0bl4k7v.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000095c3ef05dcfcae01" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13181"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 19 10:02:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngioN-0003EG-ML for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 10:02:11 +0200 Original-Received: from localhost ([::1]:47588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngioM-0003l3-In for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 04:02:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngi82-00069U-51 for emacs-devel@gnu.org; Tue, 19 Apr 2022 03:18:30 -0400 Original-Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]:42587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngi80-0007qu-0i for emacs-devel@gnu.org; Tue, 19 Apr 2022 03:18:25 -0400 Original-Received: by mail-yb1-xb30.google.com with SMTP id p65so29446636ybp.9 for ; Tue, 19 Apr 2022 00:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UF0K2t329H1j9oZpJ/CD7AE8Ka7tuCqNIl73S6g9c7Q=; b=F7i4opXHPqBwvZ3SlgUJFnPQjmoFQcZJGL9bWvg/MOpV3ZAj+ScZ6jbt92iko9sBeK 1bJavdnVsb/oYAtfkAUddo59Jlq2d+0Pnor+HCYxIsnz3JwI6vis5jNIYVvMGQHx++Da L5eYRaNwHhbrTKMzju9WnEGl8rviPPZl6/ZveEDMEAzIxi4bG3TexY5MpxxjJ0r/me1f AbKaVy4T6hUZs6wqIsggtWr06StR6ulyyizZlFkspKj//c2B6Xw0bQeAuf3wGcxLP7+E yy3SAUs38hG/JCDAiGgSSK8i7XiL8/RnXBQLuzAbO0oU9FIDp7KhrDxA1R8LTW4lL2Fa tBIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UF0K2t329H1j9oZpJ/CD7AE8Ka7tuCqNIl73S6g9c7Q=; b=n3JEjmpIVPxZkxH5YhlO74EMCixzqidpCs6XB1j5SAutTwpb08u6xCb1GRg5URPPu+ wYhrL4qemjltydWcmbJJNOMtW1eGmFd2+eIVpFORPb43jkMn55waWg78PIK+G55E2uYm B+03Zq3eNHKuwlfKmrOfw5PzTdnLwoSwk4gjCVlXKuQ4lfYN7erR7X3HEVrJbh3J53w+ Qwwva1cIVyqh9vlIIC2L1ni9268NXXQSGZKhrjc9hUtNI3q/cXO6noHFX8LOsF7MFOq/ LFXVb+RyZ+YRLOzdi4UPMh3behHSQdPevRWOL8t3YoXCXDo/+BydDoLmBLiwlEFE1M36 tPlw== X-Gm-Message-State: AOAM533HmzAudaUQedgrm4avBwdjroivqCNnM1Zyi6h63nrMrbsDxQ2m oLCguAtyHFWja+cRp/epbOQDJgX5eANF3qr9HrY= X-Google-Smtp-Source: ABdhPJyF4PhoDPGWKhyXii4VSki1hdNBM9V9CozMkxH5lHJdEWK+v2I50CoyytJB9mkduWwOd9KDYPfhJ11WZQdzUaA= X-Received: by 2002:a05:6902:1083:b0:63e:5325:d6b0 with SMTP id v3-20020a056902108300b0063e5325d6b0mr13023033ybu.431.1650352702471; Tue, 19 Apr 2022 00:18:22 -0700 (PDT) In-Reply-To: <87k0bl4k7v.fsf@posteo.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::b30; envelope-from=dalanicolai@gmail.com; helo=mail-yb1-xb30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288654 Archived-At: --00000000000095c3ef05dcfcae01 Content-Type: text/plain; charset="UTF-8" I forgot to add the link but have added it in one of my replies On Tue, 19 Apr 2022 at 09:15, Philip Kaludercic wrote: > dalanicolai writes: > > > I have written a 'scroll/image roll' package that could be considered an > > extension to image-mode. > > The package provides a 'displaying' mechanism for displaying > > images/documents as a single 'virtual scroll'. The main feature/advantage > > of the package is that it allows for the 'much requested' continuous > > scrolling. > > Have I missed something or where can I see the source code? ELPA would > ideally require a public Git repository to mirror and built the packages > from. > > > In the package I have extracted (and improved) the 'display engine' (or > > whatever to call it), from some earlier experiments of implementing > > continuous scroll into doc-view and pdf-tools. > > > > The current package can be used for displaying documents like books, but > > also for displaying a selection of images. I first thought of calling it > > papyrus.el (because scroll and bookroll, would clutter too much the Emacs > > namespaces), but finally I thought, as it can be used to show images on a > > toll, and can be considered an extension to image-mode, it would be > better > > to call it image-roll.el (or maybe just roll), opinions and suggestions > > about the name are very welcome. > > > > For testing, he package contains a `papyrus-demo` function that can > simply > > be called after loading the package (best after starting from emacs -Q). > > Additionally, as a final step, and as an example of how the package can > be > > used, I have included an `image-roll-directory` function in the last > > section (of 38 lines only) in the file, to provide an example of how the > > package can be used to display all images within some directory on a > 'roll'. > > This is only a minimal example; as this does not have my priority, I did > > not bother to make it 'fit/scale' the images. > > > > However, I have written also an extension for `pdf-tools`, that provides > a > > toggle function so that users can toggle between the 'single' page > > displaying, or the `image-roll` displaying. That file can be found here > > < > https://github.com/dalanicolai/pdf-tools/blob/papyrus-version/lisp/pdf-scroll.el > >. > > That file can simply be downloaded and loaded (after first setting the > path > > to image-roll.el at the top of the file, of course this requires > pdf-tools > > to be installed). > > > > I would be happy with any feedback, and info about if and how (what is > > required) this could be added to Emacs core. If you think this package is > > not a good candidate for core (after the required modifications), then I > > would also be happy if it could be added to ELPA (although the package on > > itself is not very interesting, it should get used by 'extensions' e.g. > for > > pdf-tools, dired, doc-view, djvu.el etc.). > > dalanicolai writes: > > > (I should really switch to Emacs for mail, the above mail probably looks > > terrible on the archive, anyway...) > > Looks fine using Gnus, I'm guessing the archive is using the HTML part > of the message. > > > As a short comment, on pdf-scroll.el. That file contains only a few lines > > of 'new' code. The major part of that > > file contains copies of 'original' pdf-tools function, but with some > minor > > modifications. I will add comments > > behind the lines containing modifications. > > -- > Philip Kaludercic > --00000000000095c3ef05dcfcae01 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I forgot to add the link but have added it in one of my re= plies

On Tue, 19 Apr 2022 at 09:15, Philip Kaludercic <philipk@posteo.net> wrote:
dalanicolai <dalanicolai@gmail.com> wri= tes:

> I have written a 'scroll/image roll' package that could be con= sidered an
> extension to image-mode.
> The package provides a 'displaying' mechanism for displaying > images/documents as a single 'virtual scroll'. The main featur= e/advantage
> of the package is that it allows for the 'much requested' cont= inuous
> scrolling.

Have I missed something or where can I see the source code?=C2=A0 ELPA woul= d
ideally require a public Git repository to mirror and built the packages from.

> In the package I have extracted (and improved) the 'display engine= ' (or
> whatever to call it), from some earlier experiments of implementing > continuous scroll into doc-view and pdf-tools.
>
> The current package can be used for displaying documents like books, b= ut
> also for displaying a selection of images. I first thought of calling = it
> papyrus.el (because scroll and bookroll, would clutter too much the Em= acs
> namespaces), but finally I thought, as it can be used to show images o= n a
> toll, and can be considered an extension to image-mode, it would be be= tter
> to call it image-roll.el (or maybe just roll), opinions and suggestion= s
> about the name are very welcome.
>
> For testing, he package contains a `papyrus-demo` function that can si= mply
> be called after loading the package (best after starting from emacs -Q= ).
>=C2=A0 Additionally, as a final step, and as an example of how the pack= age can be
> used, I have included an `image-roll-directory` function in the last > section (of 38 lines only) in the file, to provide an example of how t= he
> package can be used to display all images within some directory on a &= #39;roll'.
> This is only a minimal example; as this does not have my priority, I d= id
> not bother to make it 'fit/scale' the images.
>
> However, I have written also an extension for `pdf-tools`, that provid= es a
> toggle function so that users can toggle between the 'single' = page
> displaying, or the `image-roll` displaying. That file can be found her= e
> <https://git= hub.com/dalanicolai/pdf-tools/blob/papyrus-version/lisp/pdf-scroll.el&g= t;.
> That file can simply be downloaded and loaded (after first setting the= path
> to image-roll.el at the top of the file, of course this requires pdf-t= ools
> to be installed).
>
> I would be happy with any feedback, and info about if and how (what is=
> required) this could be added to Emacs core. If you think this package= is
> not a good candidate for core (after the required modifications), then= I
> would also be happy if it could be added to ELPA (although the package= on
> itself is not very interesting, it should get used by 'extensions&= #39; e.g. for
> pdf-tools, dired, doc-view, djvu.el etc.).

dalanicolai <= dalanicolai@gmail.com> writes:

> (I should really switch to Emacs for mail, the above mail probably loo= ks
> terrible on the archive, anyway...)

Looks fine using Gnus, I'm guessing the archive is using the HTML part<= br> of the message.

> As a short comment, on pdf-scroll.el. That file contains only a few li= nes
> of 'new' code. The major part of that
> file contains copies of 'original' pdf-tools function, but wit= h some minor
> modifications. I will add comments
> behind the lines containing modifications.

--
=C2=A0 =C2=A0 =C2=A0 =C2=A0 Philip Kaludercic
--00000000000095c3ef05dcfcae01--