From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dalanicolai Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add epub support to doc-view Date: Tue, 11 Jan 2022 11:01:35 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008c953a05d54b8a76" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3740"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Emacs Devel To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 11:06:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7E2z-0000je-HX for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 11:06:33 +0100 Original-Received: from localhost ([::1]:33096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7E2y-0007k0-4f for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 05:06:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7DyQ-0005yZ-9A for emacs-devel@gnu.org; Tue, 11 Jan 2022 05:01:50 -0500 Original-Received: from [2607:f8b0:4864:20::932] (port=40789 helo=mail-ua1-x932.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7DyO-0008Tm-8E for emacs-devel@gnu.org; Tue, 11 Jan 2022 05:01:49 -0500 Original-Received: by mail-ua1-x932.google.com with SMTP id v12so28615770uar.7 for ; Tue, 11 Jan 2022 02:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YHBbe7z52Zar5+w5Z0nj8GtKExTF1yvcd3WFTxns5Y4=; b=NKvbAdtRlRx3asROZ3of2A7wJbhWvAMmVKz4yYGfQhs0hoMURMy1ghlCUFSGiV2ey+ AnJWKe2RVLBEw+OlPadkJPe56fvFXYydtXa30lnu/clrltNhEXsPdcdY1kzqxaMFIJ1v pvCs3SInc3JF9GHQpBI02GoFng4wSpNJXytf/YxgY2YP3hBBnwe9Fd8KI73uTlHut+2F /kBw5Z7uKI55q644Qp50aeR3F6zsOHhq6z8v+UPdXcT+mIDVgF0QmD1l5TeiqEkQ2esV ckgXSNSDSUjiiviNyMW+NHi/LPLykAGho73VMn4GlxNIYsJMbyPaO0hRIv6StEFUe/82 PyeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YHBbe7z52Zar5+w5Z0nj8GtKExTF1yvcd3WFTxns5Y4=; b=liBERL76K7flKtTZxCLwYaUYUBcdJUjzCYHAU/mEvXwaavidBVqxkSfq7EgDIWmIhm gaKXMcFAati3c0xCi+LZXYNQcasgHB9EqQVrHeiRJo/2Ww4NkS5CjUxko4hlR7nrUSWM kfzVr65/8gkgske4o4JrzKjZlSLncYyKan/Wr41MdYL3CQ6rvSSEVs0qPUQIoiSVtnbS bHmi5/mYNjiVkzMeTLhpavjvUPnAQliE5/OEvMSAEnZGZhoIQq18vffHWx2dT7XOCCi6 DPPLf0I/ffntzyvztnoSIffDC7zOJb3RYTRGa9Fu3XFaoNF/zstSJDo1KKUD8cWY9nmc Es2A== X-Gm-Message-State: AOAM530mEQAfFguQz3y3kBlkVKxmjApZlFRxQbq5xa8qBppC/mTyjC2F pcRxgTdxSRM4SD0zH4qnMy7Nc+6T1d+uuWX73lU= X-Google-Smtp-Source: ABdhPJy2WJU4GBlRQ8hlYFDDRsXFZbq/GXhfbSabFaWkhpxuMHHvcPagwsU1Nq2bwuNgjd0wnmNtSkuiYATxhI60LZ4= X-Received: by 2002:a67:1783:: with SMTP id 125mr1602790vsx.85.1641895307284; Tue, 11 Jan 2022 02:01:47 -0800 (PST) In-Reply-To: X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::932 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::932; envelope-from=dalanicolai@gmail.com; helo=mail-ua1-x932.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284584 Archived-At: --0000000000008c953a05d54b8a76 Content-Type: text/plain; charset="UTF-8" Haha, okay. It is still not clear to me where. But I guess that will become clear then. Anyway, thanks for the tip. On Tue, 11 Jan 2022 at 04:30, Stefan Kangas wrote: > Stefan Monnier writes: > > > Regarding the changelog, we just need you to give us something like > > > > doc-view.el: Add support for EPub > > > > > > > > * lisp/doc-view.el (): . > > (): . > > ... > > > > * lisp/files.el (auto-mode-alist): Extend doc-view-mode-maybe > > regexp to match `.epub` files. > > I recommend using `C-x 4 a' (`add-change-log-entry-other-window') to > save you some typing. > --0000000000008c953a05d54b8a76 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Haha, okay. It is still not clear to me where. But I = guess that will become clear then.
Anyway, thanks for the tip.

On Tue, 11 Jan 2022 at 04:30, Stefan Kangas <stefankangas@gmail.com> wrote:
Stefan Monnier <monnier@iro.umontreal.ca<= /a>> writes:

> Regarding the changelog, we just need you to give us something like >
>=C2=A0 =C2=A0 =C2=A0doc-view.el: Add support for EPub
>
>=C2=A0 =C2=A0 =C2=A0<Some explanation for the general idea>
>
>=C2=A0 =C2=A0 =C2=A0* lisp/doc-view.el (<fun1>): <Do this>.=
>=C2=A0 =C2=A0 =C2=A0(<var2>): <Do that>.
>=C2=A0 =C2=A0 =C2=A0...
>
>=C2=A0 =C2=A0 =C2=A0* lisp/files.el (auto-mode-alist): Extend doc-view-= mode-maybe
>=C2=A0 =C2=A0 =C2=A0regexp to match `.epub` files.

I recommend using `C-x 4 a' (`add-change-log-entry-other-window') t= o
save you some typing.
--0000000000008c953a05d54b8a76--