(doc-view.el) Tabs or spaces convention?

(doc-view.el) Tabs or spaces convention?

[dalanicolai]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

It seems that doc-view.el is (still) full of tabs (I only discovered when I
wanted to make a commit,
and git errored). I will just convert all tabs to spaces unless that would
make me deviate from
some 'hidden' convention. In that case, please inform me about it. I wasn't
able to find any info
about it.

Thanks!

[-- Attachment #2: Type: text/html, Size: 417 bytes --]

Re: (doc-view.el) Tabs or spaces convention?

[Robert Pluim]

>>>>> On Wed, 19 Jan 2022 14:22:48 +0100, dalanicolai <dalanicolai@gmail.com> said:

    dalanicolai> It seems that doc-view.el is (still) full of tabs (I only discovered when I
    dalanicolai> wanted to make a commit,
    dalanicolai> and git errored).

I think the Emacs git hooks only trigger on trailing whitespace, but
of course git also checks stuff like that.

    dalanicolai> I will just convert all tabs to spaces unless that would
    dalanicolai> make me deviate from
    dalanicolai> some 'hidden' convention. In that case, please inform me about it. I wasn't
    dalanicolai> able to find any info
    dalanicolai> about it.

If itʼs on lines that youʼre changing anyway, itʼs not an issue, just
donʼt mass replace tabs with spaces in the whole file.

Robert
-- 

Re: (doc-view.el) Tabs or spaces convention?

[Stefan Monnier]

> It seems that doc-view.el is (still) full of tabs (I only discovered
> when I wanted to make a commit, and git errored). I will just convert
> all tabs to spaces unless that would make me deviate from some
> 'hidden' convention. In that case, please inform me about it. I wasn't
> able to find any info about it.

Lots and lots of Emacs files are full of TABs.  We don't want to change
all of that just because some coders are hang up on such largely
irrelevant details: SPCs are not clearly superiors and (more
importantly) the change would introduce painful merge conflicts.

Feel free to use whichever mix of SPC and TABs you prefer in the lines
that you do change for other reasons, but please don't change only the
TAB/SPC part.

Instead of worrying about TABs-vs-SPCs I recommend throwing snowballs or
cooking lentils (tho I'm sure you can come up with better options),


        Stefan

Re: (doc-view.el) Tabs or spaces convention?

[Stefan Kangas]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Feel free to use whichever mix of SPC and TABs you prefer in the lines
> that you do change for other reasons, but please don't change only the
> TAB/SPC part.

I recommend the ws-butler package (on NonGNU ELPA), which automatically
fixes spaces and tabs to follow the project settings, but only on the
lines you have changed.