unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: yyoncho <yyoncho@gmail.com>
To: monnier@iro.umontreal.ca
Cc: emacs-devel@gnu.org
Subject: Re: Running process filters in another thread
Date: Sat, 29 Sep 2018 22:23:33 +0300	[thread overview]
Message-ID: <CACCVLQWSTx+OjciwTm+huR7qfiPQb0a0tf5P03KNBQxT-RJRHg@mail.gmail.com> (raw)
In-Reply-To: <jwvva6ouqmm.fsf-monnier+gmane.emacs.devel@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Hi Stefan,

> E.g. why would the LSP servers send us
> megabytes of data?

Some of the responses/notifications might be big e. g.
1. Diagnostics
2. Semantic highlight data(proportional to file size)

and these combined with several concurrent LSP/DAP servers sending async
notifications. But as Eli mentioned I will have to prepare some test
results and
also with emacs 27 native json support to see how it behaves. I have
started the discussion assuming that the reading of the process output is
not
performed in the emacs UI thread but in OS thread and I was thinking that
adding
a filter to that pipeline won't be a problem. One we (lsp-mode
contributors) move
it to native json I will resume the discussion if with some concrete
testing data.

Thank you for your time.

Thanks,
Ivan





On Sat, Sep 29, 2018 at 9:11 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> >> It shouldn't be too hard to use a separate (OS-level) Emacs *process*
> >> if you want to do the parsing without blocking the normal UI thread.
> >> But it comes with other performance tradeoffs.
> >
> > Please correct me if I am wrong but I believe that I will still have
> > to parse the input on UI thread but from a different
> > format (e. g. using built-in print1/read) which in the end will have
> > the same result.
>
> The idea is that the other process would do the bulk of the "digestion"
> so the amount of data it would send to the main Emacs (the "UI thread")
> would hopefully be much smaller.
>
> But I must admit not being sufficiently familiar with the details to be
> able to discuss it seriously.  E.g. why would the LSP servers send us
> megabytes of data?  Is it because it sends us back the whole file with
> lots of detailed annotations everywhere (e.g. the kind of info we'd use
> for font-lock-like purposes rather than for flymake-like purposes)?
>
>
>         Stefan
>
>
>

[-- Attachment #2: Type: text/html, Size: 2664 bytes --]

  reply	other threads:[~2018-09-29 19:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 18:21 Running process filters in another thread yyoncho
2018-09-28 21:14 ` Eli Zaretskii
     [not found]   ` <CACCVLQUrpxuhKwaHbFfCSzYLfucL8x+tJOkwgKwK8bzb0VZaWg@mail.gmail.com>
2018-09-29  6:54     ` Fwd: " yyoncho
2018-09-29  7:37       ` Eli Zaretskii
2018-09-28 23:03 ` Stefan Monnier
2018-09-29  7:35   ` yyoncho
2018-09-29  8:15     ` Eli Zaretskii
2018-09-29 18:10     ` Stefan Monnier
2018-09-29 19:23       ` yyoncho [this message]
2018-09-29 20:30         ` Stefan Monnier
2018-09-30  7:08           ` yyoncho
2018-09-30 13:01             ` Stefan Monnier
2018-09-30 15:01               ` yyoncho
2018-10-01 21:12 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACCVLQWSTx+OjciwTm+huR7qfiPQb0a0tf5P03KNBQxT-RJRHg@mail.gmail.com \
    --to=yyoncho@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).