unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: yyoncho <yyoncho@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Tramp and conversion of \r\n into \n
Date: Wed, 9 Dec 2020 09:34:27 +0200	[thread overview]
Message-ID: <CACCVLQUqhQ=OW5jCH+m9pQpR9D24aMfttuxwT1hsPWAoN0M3vA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

Hi Michael,

I am writing this regarding the following issue on lsp-mode's bug tracker:
https://github.com/emacs-lsp/lsp-mode/issues/2375 . The issue is that \r\n
are converted to \n but only when connecting to linux from mac.

Using (set-process-coding-system result 'no-conversion 'no-conversion) and
settinginhibit-eol-conversion to t does not work(or at least this is what
was reported by the users).

Can you suggest what the issue might be?

Let me know if you need more information: Here it is the relevant code
which we use for opening the connection:

 (let* ((final-command (lsp-resolve-final-function local-command))
                          ;; wrap with stty to disable converting \r to \n
                          (process-name (generate-new-buffer-name name))
                          (wrapped-command (append '("stty" "raw" ";")
                                                   final-command
                                                   (list
                                                    (concat "2>"
                                                            (or (when
generate-error-file-fn
                                                                  (funcall
generate-error-file-fn name))
                                                                (format
"/tmp/%s-%s-stderr" name

(cl-incf lsp--stderr-index)))))))
                          (process-environment
                           (lsp--compute-process-environment
environment-fn)))
                     (let ((proc (apply 'start-file-process-shell-command
process-name
                                        (format "*%s*" process-name)
wrapped-command)))
                       (set-process-sentinel proc sentinel)
                       (set-process-filter proc filter)
                       (set-process-query-on-exit-flag proc nil)
                       (set-process-coding-system proc 'binary 'binary)
                       (cons proc proc)))

Thanks,
Ivan

[-- Attachment #2: Type: text/html, Size: 3711 bytes --]

             reply	other threads:[~2020-12-09  7:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09  7:34 yyoncho [this message]
2020-12-10 13:44 ` Tramp and conversion of \r\n into \n Michael Albinus
2020-12-11 14:11   ` yyoncho
  -- strict thread matches above, loose matches on Subject: below --
2020-12-11  7:46 APEL Martin
2020-12-11  9:15 ` Michael Albinus
2020-12-11  9:59   ` APEL Martin
2020-12-11 10:26     ` Michael Albinus
2020-12-11 11:29       ` APEL Martin
2020-12-11 11:52         ` Michael Albinus
2020-12-13 16:04           ` Michael Albinus
2020-12-15 11:37         ` Michael Albinus
2020-12-15 12:45           ` APEL Martin
2020-12-15 14:37             ` Michael Albinus
2020-12-15 18:45               ` Michael Albinus
2020-12-16  6:44                 ` APEL Martin
2020-12-16 15:34         ` Michael Albinus
2020-12-16 15:55           ` APEL Martin
2020-12-17 11:35           ` APEL Martin
2020-12-17 12:50             ` Michael Albinus
2020-12-18  7:48               ` APEL Martin
2020-12-18 12:35                 ` Michael Albinus
2020-12-18 12:56                   ` APEL Martin
2020-12-18 13:04                     ` Michael Albinus
2020-12-18 14:54                       ` APEL Martin
2020-12-18 15:00                         ` Michael Albinus
2020-12-18 15:10                           ` APEL Martin
2020-12-18 15:18                             ` Michael Albinus
2020-12-22 14:57                             ` Michael Albinus
2021-01-07 11:13                               ` APEL Martin
2020-12-19  9:18             ` yyoncho
2020-12-19 16:48               ` Michael Albinus
2020-12-20 14:03                 ` Michael Albinus
2021-08-05  1:46                 ` Thomas Ross
2021-08-05  6:16                   ` Eli Zaretskii
2021-08-07  2:08                     ` Thomas Ross
2021-08-05 14:10                   ` Stefan Monnier
2021-08-05 15:40                     ` Michael Albinus
2021-08-05 16:25                       ` Stefan Monnier
2021-08-06  7:13                         ` Michael Albinus
2021-08-06 14:46                           ` Stefan Monnier
2021-08-07 13:51                             ` Michael Albinus
2021-08-07 22:04                               ` Stefan Monnier
2021-08-08 14:25                                 ` Michael Albinus
2021-08-12 18:47                                   ` Michael Albinus
2021-08-13 12:16                                     ` Michael Albinus
2021-08-07  2:07                     ` Thomas Ross
2021-08-07 13:54                       ` Michael Albinus
2021-08-08 14:29                         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACCVLQUqhQ=OW5jCH+m9pQpR9D24aMfttuxwT1hsPWAoN0M3vA@mail.gmail.com' \
    --to=yyoncho@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).