From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tim Cross Newsgroups: gmane.emacs.devel Subject: Re: Git master head build failure? Date: Thu, 1 Apr 2021 19:57:58 +1100 Message-ID: References: <875z16en2o.fsf@gmail.com> <8735waelo4.fsf@gmail.com> <83lfa2h327.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003a88f305bee56ec9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16789"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 01 10:59:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRtAh-0004Gd-5g for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 10:59:23 +0200 Original-Received: from localhost ([::1]:33996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRtAg-0000fx-7v for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 04:59:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRt9Z-0000EH-Pn for emacs-devel@gnu.org; Thu, 01 Apr 2021 04:58:13 -0400 Original-Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:42897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRt9Y-0000vM-0v; Thu, 01 Apr 2021 04:58:13 -0400 Original-Received: by mail-oi1-x234.google.com with SMTP id n140so1080419oig.9; Thu, 01 Apr 2021 01:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y5xvoIUrPCGYCc5/w7ag8PISSda0vrhirxi23+g/Xtk=; b=n9vi3GgvjZvnlhhLb/4YFD5RLr/gtzKxlILciB9ZGXExusepbdbOXQspmSxpPyklxb QuKxrFdxOZ+ae5I396oJV1CMWUcZs29z52hAdPWNcSd6xeu8dvuukOB+gqB+3uE/S88m kczRl5+No/9nET2Cr7GDv0T453oCY0skyEzpafOo0b6IgG6rp3e6G5Iod6SHZbMPFUcU Plcabqdn81QndqvNiXF9GENS3eg5Rak8TkldGH58kgV+Qa/sowtGrUEjxctmxZ6ar3v2 agTe0IQjz52Jr0W5QDXIfuPzYMXVaBXRrAUj6JK6v5rOXJ7OBp5FRVhiNteRx/3c+wWW KLng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y5xvoIUrPCGYCc5/w7ag8PISSda0vrhirxi23+g/Xtk=; b=DRaDNa+9ZJfXcCWwY8r7JJor54/uW4iyS/ck0Q6Rlrr2fbODqUQlTULGFy99U6ASvp WQp/JHj1gfUuT2S+TIEOjDXN+Lqst6AkNnVpYpn2HNDoHIA5D3fns4PjYzq5Q0VTzmSt swBzpmvkEZ5pQGacp7JRtBZ1b4/gpiaqKHFJXxBi3kQQa8Mj7JohJF1oXtijv4WQKJNV B6bITM2PZ9RSOFyJgL3VgAjbk3VLuun9azt6vCY8BJtX1JCVxhpAlpya5/s168mU7E1N gkMyJhVsciHvyhKnHgFLShWEoCSd3cARPa5D78TCSYzdETCyJiyNtuUsxR0WjAZ9J5KX hJOw== X-Gm-Message-State: AOAM532yh4/GsSckIvoXOdUCGg73L2pVYZVldAuihKw9uXQ+9nCutAsT RFMkaFVvwlA4UAu2zBLwqe6ZG7qUNqafIh6MU2RdDE2d X-Google-Smtp-Source: ABdhPJz/J0aodQjazJwC4SSLVz1nmhGUeJUreQf2TdXJ4wJilrZdVGoeIfXMkEG0AhpzEi/JcvWY84Y8wXm2IwHnG0g= X-Received: by 2002:aca:1c14:: with SMTP id c20mr5099729oic.146.1617267489670; Thu, 01 Apr 2021 01:58:09 -0700 (PDT) In-Reply-To: <83lfa2h327.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=theophilusx@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267242 Archived-At: --0000000000003a88f305bee56ec9 Content-Type: text/plain; charset="UTF-8" On Thu, 1 Apr 2021 at 18:33, Eli Zaretskii wrote: > > From: Tim Cross > > Date: Thu, 01 Apr 2021 14:10:50 +1100 > > Cc: emacs-devel@gnu.org > > > > I wonder if it would be possible for make maintainer-clean to somehow > > look at what is in .gitignore and ensure anything in there is also > > removed? Would be good if at least that target returned the repo to an > > exact replica of what you would get if you did a fresh clone. > > First, you should be using extraclean, not maintainer-clean; see the > top-level Makefile.in for the documentation of the various clean > targets. > > And second, we should simply make sure extraclean removes all the > generated files, as documented, and keep it that way. Looking into > .gitignore means either building its interpreter into our build system > (a non-trivial job, AFAIU), or using Git itself to do the job, which > would mean the job cannot be done without Git -- a disadvantage, IMO. > In that case, either extraclean should be added to the make help output or if the preferred mechanism is to read Makefile.in, then remove make help. -- regards, Tim -- Tim Cross --0000000000003a88f305bee56ec9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, 1 Apr 2021 at 18:33, Eli Zare= tskii <eliz@gnu.org> wrote:
> From: Tim Cross = <theophilusx@= gmail.com>
> Date: Thu, 01 Apr 2021 14:10:50 +1100
> Cc: emacs-dev= el@gnu.org
>
> I wonder if it would be possible for make maintainer-clean to somehow<= br> > look at what is in .gitignore and ensure anything in there is also
> removed? Would be good if at least that target returned the repo to an=
> exact replica of what you would get if you did a fresh clone.

First, you should be using extraclean, not maintainer-clean; see the
top-level Makefile.in for the documentation of the various clean
targets.

And second, we should simply make sure extraclean removes all the
generated files, as documented, and keep it that way.=C2=A0 Looking into .gitignore means either building its interpreter into our build system
(a non-trivial job, AFAIU), or using Git itself to do the job, which
would mean the job cannot be done without Git -- a disadvantage, IMO.

In that case, either extraclean s= hould be added to the make help output or if the preferred mechanism is to = read Makefile.in, then remove make help.=C2=A0

--
<= div dir=3D"ltr" class=3D"gmail_signature">
regards,

Tim

--
Tim Cross

--0000000000003a88f305bee56ec9--