* ido regression in trunk?
@ 2012-09-27 18:19 Carsten Mattner
2012-09-27 23:05 ` Christopher Monsanto
2012-09-28 3:33 ` Leo
0 siblings, 2 replies; 6+ messages in thread
From: Carsten Mattner @ 2012-09-27 18:19 UTC (permalink / raw)
To: emacs-devel
Did anyone else notice that opening files with ido enabled
doesn't work as it did last week in current trunk?
The fuzzy match of file/dir to open always open the first
item of the list even if I continue typing a more precise
different sub-directory which is not the first entry of the list.
I cannot imagine this to go unnoticed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ido regression in trunk?
2012-09-27 18:19 ido regression in trunk? Carsten Mattner
@ 2012-09-27 23:05 ` Christopher Monsanto
2012-09-28 3:33 ` Leo
1 sibling, 0 replies; 6+ messages in thread
From: Christopher Monsanto @ 2012-09-27 23:05 UTC (permalink / raw)
To: Carsten Mattner; +Cc: emacs-devel
I've noticed this problem as well, very irritating. If the maintainer
of ido doesn't know what's up, I can do a bisect to find the problem.
Christopher Monsanto
chris@monsan.to -- http://monsan.to/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ido regression in trunk?
2012-09-27 18:19 ido regression in trunk? Carsten Mattner
2012-09-27 23:05 ` Christopher Monsanto
@ 2012-09-28 3:33 ` Leo
2012-09-28 8:33 ` Carsten Mattner
2012-09-28 14:51 ` Leo
1 sibling, 2 replies; 6+ messages in thread
From: Leo @ 2012-09-28 3:33 UTC (permalink / raw)
To: emacs-devel
On 2012-09-28 02:19 +0800, Carsten Mattner wrote:
> Did anyone else notice that opening files with ido enabled
> doesn't work as it did last week in current trunk?
>
> The fuzzy match of file/dir to open always open the first
> item of the list even if I continue typing a more precise
> different sub-directory which is not the first entry of the list.
>
> I cannot imagine this to go unnoticed.
On 2012-09-28 07:05 +0800, Christopher Monsanto wrote:
> I've noticed this problem as well, very irritating. If the maintainer
> of ido doesn't know what's up, I can do a bisect to find the problem.
>
> Christopher Monsanto
> chris@monsan.to -- http://monsan.to/
Sorry to all. It is my fault. I will install the following fix later
today:
diff --git a/lisp/ido.el b/lisp/ido.el
index d48e7ba8..f511dbbf 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -3701,14 +3701,14 @@ (defun ido-set-matches-1 (items &optional do-full)
(rexq (concat rex0 (if slash ".*/" "")))
(re (if ido-enable-prefix (concat "\\`" rexq) rexq))
(full-re (and do-full
- (and (eq ido-cur-item 'buffer)
- (not ido-buffer-disable-smart-matches))
+ (not (and (eq ido-cur-item 'buffer)
+ ido-buffer-disable-smart-matches))
(not ido-enable-regexp)
(not (string-match "\$\\'" rex0))
(concat "\\`" rex0 (if slash "/" "") "\\'")))
(suffix-re (and do-full slash
- (and (eq ido-cur-item 'buffer)
- (not ido-buffer-disable-smart-matches))
+ (not (and (eq ido-cur-item 'buffer)
+ ido-buffer-disable-smart-matches))
(not ido-enable-regexp)
(not (string-match "\$\\'" rex0))
(concat rex0 "/\\'")))
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: ido regression in trunk?
2012-09-28 3:33 ` Leo
@ 2012-09-28 8:33 ` Carsten Mattner
2012-09-28 14:51 ` Leo
1 sibling, 0 replies; 6+ messages in thread
From: Carsten Mattner @ 2012-09-28 8:33 UTC (permalink / raw)
To: Leo; +Cc: emacs-devel
On Fri, Sep 28, 2012 at 5:33 AM, Leo <sdl.web@gmail.com> wrote:
> On 2012-09-28 02:19 +0800, Carsten Mattner wrote:
>> Did anyone else notice that opening files with ido enabled
>> doesn't work as it did last week in current trunk?
>>
>> The fuzzy match of file/dir to open always open the first
>> item of the list even if I continue typing a more precise
>> different sub-directory which is not the first entry of the list.
>>
>> I cannot imagine this to go unnoticed.
>
> On 2012-09-28 07:05 +0800, Christopher Monsanto wrote:
>> I've noticed this problem as well, very irritating. If the maintainer
>> of ido doesn't know what's up, I can do a bisect to find the problem.
>>
>> Christopher Monsanto
>> chris@monsan.to -- http://monsan.to/
>
> Sorry to all. It is my fault. I will install the following fix later
> today:
>
> diff --git a/lisp/ido.el b/lisp/ido.el
> index d48e7ba8..f511dbbf 100644
> --- a/lisp/ido.el
> +++ b/lisp/ido.el
> @@ -3701,14 +3701,14 @@ (defun ido-set-matches-1 (items &optional do-full)
> (rexq (concat rex0 (if slash ".*/" "")))
> (re (if ido-enable-prefix (concat "\\`" rexq) rexq))
> (full-re (and do-full
> - (and (eq ido-cur-item 'buffer)
> - (not ido-buffer-disable-smart-matches))
> + (not (and (eq ido-cur-item 'buffer)
> + ido-buffer-disable-smart-matches))
> (not ido-enable-regexp)
> (not (string-match "\$\\'" rex0))
> (concat "\\`" rex0 (if slash "/" "") "\\'")))
> (suffix-re (and do-full slash
> - (and (eq ido-cur-item 'buffer)
> - (not ido-buffer-disable-smart-matches))
> + (not (and (eq ido-cur-item 'buffer)
> + ido-buffer-disable-smart-matches))
> (not ido-enable-regexp)
> (not (string-match "\$\\'" rex0))
> (concat rex0 "/\\'")))
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ido regression in trunk?
2012-09-28 3:33 ` Leo
2012-09-28 8:33 ` Carsten Mattner
@ 2012-09-28 14:51 ` Leo
2012-09-28 16:58 ` Glenn Morris
1 sibling, 1 reply; 6+ messages in thread
From: Leo @ 2012-09-28 14:51 UTC (permalink / raw)
To: emacs-devel; +Cc: Carsten Mattner
On 2012-09-28 11:33 +0800, Leo wrote:
> Sorry to all. It is my fault. I will install the following fix later
> today:
Installed as r108149 in emacs-24 (see
http://permalink.gmane.org/gmane.emacs.diffs/116492).
It might take a few days to merge into trunk. (I tried doing it myself
but bzrmerge.el complaint about uncommitted changes when I have none.)
Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-28 16:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 18:19 ido regression in trunk? Carsten Mattner
2012-09-27 23:05 ` Christopher Monsanto
2012-09-28 3:33 ` Leo
2012-09-28 8:33 ` Carsten Mattner
2012-09-28 14:51 ` Leo
2012-09-28 16:58 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).