From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pittman Newsgroups: gmane.emacs.devel Subject: Re: some accept-process-output races fixed; Tramp FIXMEs Date: Wed, 23 Jan 2019 17:19:38 -0500 Message-ID: References: <46ce72ef-c4cb-1cd1-566a-c305ca92e68c@cs.ucla.edu> <80d86b5a-efb7-87cc-a3db-0a6ad356274d@cs.ucla.edu> <875zujlkhv.fsf@gmx.de> <87tvi0tipl.fsf@gmx.de> <83imyf8hzj.fsf@gnu.org> <87ef93kyri.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008323a20580277fe8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238610"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , eggert@cs.ucla.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 23 23:21:32 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmQtn-000zwK-9d for ged-emacs-devel@m.gmane.org; Wed, 23 Jan 2019 23:21:31 +0100 Original-Received: from localhost ([127.0.0.1]:42753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmQtm-0005BE-9z for ged-emacs-devel@m.gmane.org; Wed, 23 Jan 2019 17:21:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmQsd-00056F-Ex for emacs-devel@gnu.org; Wed, 23 Jan 2019 17:20:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmQsb-00016F-UM for emacs-devel@gnu.org; Wed, 23 Jan 2019 17:20:19 -0500 Original-Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:34435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmQsb-00010s-4A for emacs-devel@gnu.org; Wed, 23 Jan 2019 17:20:17 -0500 Original-Received: by mail-oi1-x230.google.com with SMTP id r62so3246694oie.1 for ; Wed, 23 Jan 2019 14:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z2uEAnPr2XbXTNurkOMRbj9MOPh4dw9o7Y3slyuHI9c=; b=T/koP5AwWZTYeozYGDmYcU7EYPbXSrgvz3Vf2LOjlorPBRghSnly+Hai66DcEy1LU2 51AkfNLs2RgWAS6YugtF8p8WK9SdsQnOmYyNbcf3x4TVOfqEQptNS/arypbMem927o61 qqtl961QFT/umAJHHhPJjlmDRAj/7diAfPMm7/FhbBAx6sjOtvw4s58lWGIDJt+tXtpI jRAHSkpsAH7xUfMMnKokrtnw/RoFXYJ/FGiZ8XeQBSWy+mA9xJbcUyHDnIzVPu8pryQV ulp5ZrZ1H7bYxmvPqWlYZqCUuQDWq2WiiQKiA45a0syUL0iaukUCW++FcD8L/GkGvmom vHdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z2uEAnPr2XbXTNurkOMRbj9MOPh4dw9o7Y3slyuHI9c=; b=tHliUTXc2hfKdX0dGGggKDB5zx4B8sWi3W+fFpwr7XmDBID/SikhfNpOcd/7c8B40q AJfJhFw/As6ToY2ftnzk9cUY42TMPDyUDVy3aFZzUIHP0GfYbIBpR62homUwmY8yiuD0 YuI6W/Pk1KAeZTZ2euiwWcdXeRRXbOifpNKMbAodsApwpZUMN0wfefhT4b7jitM84Axz 1PYCKCUuXkOgVfxap7hiohXkYHz9MNFQlo8H4uYbE1x2hgOt+fnAHTq6IRCTvQTAqu9V Cs1PkesONvq9iSJcdPT6lR2xjfUWUCHFXvYXbLbGgRK+Hj50sSeWlaTgaeF3ALsU/Ba6 oWVA== X-Gm-Message-State: AJcUukdSKjQ9+1K4pP7PjcW0xFLMr0HfAxcqUpgvdRhgzL1tyJffaOjc 24QzcIRbv/k6vHsxcwRTnu+r/7zeuRVI9XOdN32ZkQ== X-Google-Smtp-Source: ALg8bN781znqfaAVIlKeezw2IR2dtmiDnAKCpTX1+JgC3s4Pd9e5fTfJ1HAaPTccInVXtl/iCrd0OG/TBhahTpPLUVw= X-Received: by 2002:aca:dd88:: with SMTP id u130mr2452447oig.204.1548282014904; Wed, 23 Jan 2019 14:20:14 -0800 (PST) In-Reply-To: <87ef93kyri.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232658 Archived-At: --0000000000008323a20580277fe8 Content-Type: text/plain; charset="UTF-8" For what it is worth, that explanation more or less mirrors my recollection of why that wasn't a zero to poll, or infinite, timeout. Working around broken something; I would have said more likely MacOS-X of the period, which I think still has a broken implementation of the `poll` syscall, but I don't fully recall. (That was still in the era I payed significant attention to TRAMP development) On Wed, Jan 23, 2019 at 1:38 PM Michael Albinus wrote: > Eli Zaretskii writes: > > Hi Eli, > > >> At least the w32 version of accept-process-output was broken in the > >> past, see the comment in tramp-accept-process-output. But this was Emacs > >> 22 time, so hopefully it is fixed now. > > > > That comment doesn't tell much about the problem, so I couldn't verify > > that the problem it mentioned is no longer relevant. > > Archeology has uncovered > , > which relates to that comment. Sorry, I haven't anything else. > > The respective commit in the Tramp repository was CVS 2.516 from > 10-Dec-06, if that matters :-) > > In that message thread, the OP has mentioned another problem after I've > added the timeout and the comment; this seems to be unrelated. > > Best regards, Michael. > > --0000000000008323a20580277fe8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
For what it is worth, that explanation more or less m= irrors my recollection of why that wasn't a zero to poll, or infinite, = timeout.=C2=A0 Working around broken something; I would have said more like= ly MacOS-X of the period, which I think still has a broken implementation o= f the `poll` syscall, but I don't fully recall.

(That was still in the era I payed significant=C2=A0attention to TRAMP de= velopment)



On Wed, Jan 23, 2019 at 1= :38 PM Michael Albinus <michae= l.albinus@gmx.de> wrote:
Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> At least the w32 version of accept-process-output was broken in th= e
>> past, see the comment in tramp-accept-process-output. But this was= Emacs
>> 22 time, so hopefully it is fixed now.
>
> That comment doesn't tell much about the problem, so I couldn'= t verify
> that the problem it mentioned is no longer relevant.

Archeology has uncovered
<http://lists.gnu.org/archive/= html/tramp-devel/2006-12/msg00007.html>,
which relates to that comment. Sorry, I haven't anything else.

The respective commit in the Tramp repository was CVS 2.516 from
10-Dec-06, if that matters :-)

In that message thread, the OP has mentioned another problem after I've=
added the timeout and the comment; this seems to be unrelated.

Best regards, Michael.

--0000000000008323a20580277fe8--