unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Pittman <slippycheeze@google.com>
To: Alan Third <alan@idiocy.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Native image rotation
Date: Tue, 26 Feb 2019 12:01:24 -0500	[thread overview]
Message-ID: <CAC45yQsag4wBWBjRz4m5RgKKeR36Suhb+U-SViPyU6a=X80chg@mail.gmail.com> (raw)
In-Reply-To: <20190225192102.GA3060@breton.holly.idiocy.org>

[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]

As others, I'd certainly like to be able to perform arbitrary rotations.
Working with photos to extract, eg, document contents from a scanned image,
and displaying a graphical "busy" spinner, are the use cases I have handled
before.

If performance was too poor, I'd be more inclined to look at how to improve
performance in Emacs than to abandon the approach in favor of a large
number of barely changed images.  That would, after all, make life better
for everyone, and I have confidence that it *would* be possible to make
that efficient enough to work.

After all, I don't need 60FPS rendering of this, and that is definitely
achievable for vastly more complex 2D and 3D layouts on the display layers
on all the platforms Emacs supports, thanks to browsers among other tools.

On Mon, Feb 25, 2019 at 2:21 PM Alan Third <alan@idiocy.org> wrote:

> On Mon, Feb 25, 2019 at 05:36:46AM +0200, Eli Zaretskii wrote:
> > > Date: Sun, 24 Feb 2019 23:22:28 +0000
> > > From: Alan Third <alan@idiocy.org>
> > > Cc: emacs-devel@gnu.org
> > >
> > > And I guess we maybe wouldn’t have to worry about clearing under the
> > > image any more in X: rotating can leave transparent sections.
> > >
> > > But the maths is performed only once, when the image is loaded, so I
> > > doubt we’d find a significant improvement.
> >
> > It's indeed the clearing that bothered me,
>
> Would it be better if it was done by another XRender composite rather
> than x_clear_area?
>
> If this really is a problem then I think we have to allow only 90
> degree multiples. I can’t see any other reasonable solution.
>
> > and also the increase in the screen estate taken by a rotated image.
>
> I think that would be less of an issue with the addition of cropping,
> as an image could be rotated then cropped down to size. Besides, if
> someone wants to rotate at 45 degrees they’ve got to expect the size
> of the image to change, there’s no other reasonable option.
>
> > I'm asking whether it's worth it.
>
> Limiting to 90 degree increments feels like an arbitrary limitation,
> but I don’t feel strongly about it either way.
> --
> Alan Third
>
>

[-- Attachment #2: Type: text/html, Size: 2786 bytes --]

  reply	other threads:[~2019-02-26 17:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-24 11:30 Native image rotation Alan Third
2019-02-24 16:14 ` Eli Zaretskii
2019-02-24 17:34   ` Clément Pit-Claudel
2019-02-24 17:49     ` Eli Zaretskii
2019-02-24 18:06       ` Clément Pit-Claudel
2019-02-24 18:28         ` Eli Zaretskii
2019-02-24 18:51           ` Stefan Monnier
2019-02-24 19:13             ` Eli Zaretskii
2019-02-24 19:23               ` Eli Zaretskii
2019-02-24 20:08                 ` Stefan Monnier
2019-02-24 23:00                   ` Alan Third
2019-02-25  3:32                   ` Eli Zaretskii
2019-02-24 23:22   ` Alan Third
2019-02-25  3:36     ` Eli Zaretskii
2019-02-25  5:11       ` Van L
2019-02-25 13:47       ` Stefan Monnier
2019-02-25 19:21       ` Alan Third
2019-02-26 17:01         ` Daniel Pittman [this message]
2019-03-02 13:29         ` Alan Third
2019-05-19 20:29           ` Basil L. Contovounesios
2019-05-20 18:18             ` Alan Third
2019-05-21 20:11               ` Alan Third
2019-06-02 18:11                 ` Alan Third
2019-06-02 18:24                   ` Lars Ingebrigtsen
2019-06-05 21:39                     ` Alan Third
2019-06-06  9:03                       ` Andy Moreton
2019-06-06 12:57                         ` Eli Zaretskii
2019-05-22  6:45             ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2019-02-25 12:48 Evgeny Zajcev
2019-02-25 15:43 ` Clément Pit-Claudel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC45yQsag4wBWBjRz4m5RgKKeR36Suhb+U-SViPyU6a=X80chg@mail.gmail.com' \
    --to=slippycheeze@google.com \
    --cc=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).