From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mathias Dahl Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New command to invert lines in region Date: Sun, 16 Oct 2016 13:03:25 +0200 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c07ce82c99f80053ef96927 X-Trace: blaine.gmane.org 1476615846 20465 195.159.176.226 (16 Oct 2016 11:04:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Oct 2016 11:04:06 +0000 (UTC) Cc: Emacs developers , Tino Calancha To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 16 13:04:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvjEO-0003aX-HQ for ged-emacs-devel@m.gmane.org; Sun, 16 Oct 2016 13:03:52 +0200 Original-Received: from localhost ([::1]:55763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvjEQ-0005AC-HZ for ged-emacs-devel@m.gmane.org; Sun, 16 Oct 2016 07:03:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvjEK-00059w-7l for emacs-devel@gnu.org; Sun, 16 Oct 2016 07:03:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvjEJ-0006QZ-Do for emacs-devel@gnu.org; Sun, 16 Oct 2016 07:03:48 -0400 Original-Received: from mail-vk0-x242.google.com ([2607:f8b0:400c:c05::242]:34469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bvjEJ-0006QM-6N for emacs-devel@gnu.org; Sun, 16 Oct 2016 07:03:47 -0400 Original-Received: by mail-vk0-x242.google.com with SMTP id 2so6608273vkb.1 for ; Sun, 16 Oct 2016 04:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iKsrJYDyF+bwV+FHDXHz2iFCblhmVdxIjMzYgUcYdv8=; b=Strv5CkO3HOkIL+M5mPQURtwwxU6vb5CimdVJNP8zJq0GuWkfhxuO+EE/JScdjqEve eTBAsDm+KrnLTY831k6nuROJmQBc3bavBald8B2oCWU33dMn2gZ1uAlxbb1FpoQec+yB ii2t4BMDt53MDWxF7ndPAf3p02HIh1ENTc4WZ6PIgPLz1EXzZHG3+1KCnCBNpUi7I9ZZ y/Gu+vx2qXiXwiK2dWF2WoAlaCYL02amCCRWjEUaujXR2HJJ8oKbmEF75DbIweKRKE8T GOE5Gq6t+cnctTlYSFDyv7R0SWA1uFuaegvb7YjCxEURfs7cLP6LkwsCe3ikUerLB7MI C3kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iKsrJYDyF+bwV+FHDXHz2iFCblhmVdxIjMzYgUcYdv8=; b=T4r0558JcQ7uYSW5utessELhlLUdZ4Nq0ZU9X0CdQmfNHrW6wAeaDMpa3TTZg0gdEK bpvB+mpachPuSO9Fj4Ag4nLZki2BlDfOsBAr0BAaRRnOb8rt1zSAeNO7d2oxcHSbrAmB 4t+ZQXc7RAJC0gJyGk2sWvqgy+XCaxv7QW6FfT1wy2XhHF2WA2COptdsH+9bvyjeUbQV 1cvkr3L76bgmM0Um1WisxYfq//BLG5SPNPsYzX3n/kKk7h2qZDH2Cj1pQOJyGD5mpfPf 5Py69TVkRqXGzl6op/qEuDnOXvwefe2CuIvJF0uYliQl6Bz6c4duHMtBBSYlV8/G4Xbo Ep8g== X-Gm-Message-State: AA6/9RmkwSW4+WQva2BwqO03yNCHwALhTLSSV40GcKBG83C0iI5X+1axamcxXitlgTGuDEiMDPulRmmL0C9hTw== X-Received: by 10.31.221.65 with SMTP id u62mr13759227vkg.71.1476615826151; Sun, 16 Oct 2016 04:03:46 -0700 (PDT) Original-Received: by 10.159.55.134 with HTTP; Sun, 16 Oct 2016 04:03:25 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c05::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208327 Archived-At: --94eb2c07ce82c99f80053ef96927 Content-Type: text/plain; charset=UTF-8 > > Out of curiosity I had a look at the current implementation of >> `reverse-region' and found it quite complicated and hard to understand what >> it does. >> > > I don't have any for or against opinion on this (may be a slight against, > based on the "if it's not broken, why 'fix'" motto). I have been using > `reverse-region` for many years and it works just fine. > Probably it works just fine, as you say. I agree there is a risk fixing something that is not broken. I also think it is generally a good thing to make code more readable and if code can be made more readable and at the same time be made smaller (which often increase readability), without any negative side effects, it is a win for maintainability of that code base, in my opinion. At any rate, this was just something I happened to notice and I thought it would be fun to have a go at it. --94eb2c07ce82c99f80053ef96927 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Out of curiosity I had a look at the current implemen= tation of `reverse-region' and found it quite complicated and hard to u= nderstand what it does.
I don't have any for or against opinion on this (may= be a slight against, based on the "if it's not broken, why 'f= ix'" motto). I have been using `reverse-region` for many years and= it works just fine.=C2=A0

Probably i= t works just fine, as you say. I agree there is a risk fixing something tha= t is not broken. I also think it is generally a good thing to make code mor= e readable and if code can be made more readable and at the same time be ma= de smaller (which often increase readability), without any negative side ef= fects, it is a win for maintainability of that code base, in my opinion.

At any rate, this was just something I happened to n= otice and I thought it would be fun to have a go at it.



--94eb2c07ce82c99f80053ef96927--