unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathias Dahl <mathias.dahl@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Abbrev suggestions - feedback appreciated
Date: Sun, 17 May 2020 20:43:23 +0200	[thread overview]
Message-ID: <CABrcCQ4c_k3b7OenMU6xBgfO_mQgGST-7cj-T6JZ2N4fS_j6mA@mail.gmail.com> (raw)
In-Reply-To: <83mu66bm60.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

>
>
> > I defined 10,000 dummy abbrevs (a1 .. a10000) and used the profiler to
> compare
> > memory usage and... I did not get any conclusive results. And between
> runs I get different
> > memory values reported.
>
> The "memory" profiler doesn't really measure memory consumption, it
> just uses memory-allocation calls as a poor-man's timer that ticks
> frequently enough.
>
> IOW, don't use the "memory" profiler if you need to profile memory
> consumption.  We don't (yet) have such a beast in Emacs.
>

Hi Eli,

Thanks for the input.

I also did a benchmark-run (100 laps) on the two versions as well. Here are
the results:

Old version

(20.113209378 361 11.676905440000002)

New version

(19.808761477999997 356 11.392537358999999)

I'll leave it up to Stefan and others to decide which of the versions of
abbrev-suggest
we should keep, if we want to include this in Emacs.

I'll send a new patch here soon.

Thanks!

/Mathias

[-- Attachment #2: Type: text/html, Size: 1485 bytes --]

  reply	other threads:[~2020-05-17 18:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-16  7:51 Abbrev suggestions - feedback appreciated Mathias Dahl
2017-09-16  8:46 ` Eli Zaretskii
2017-09-17 13:15   ` Mathias Dahl
2017-09-16 13:22 ` Stefan Monnier
2017-09-17 13:22   ` Mathias Dahl
2017-09-17 14:03     ` Mathias Dahl
2017-09-17 21:23     ` Stefan Monnier
2017-09-17 21:56       ` Mathias Dahl
2017-10-03 12:51         ` Kaushal Modi
2017-10-07 15:13           ` Mathias Dahl
2017-10-07 15:29             ` Stefan Monnier
2017-10-07 17:18               ` Mathias Dahl
2017-10-07 18:40                 ` Mathias Dahl
2017-10-07 22:29                   ` Ian Dunn
2017-10-07 22:44                     ` Stefan Monnier
2017-10-08 16:38                       ` Ian Dunn
2018-09-17 21:48                         ` Mathias Dahl
2018-09-18  2:05                           ` Stefan Monnier
2020-05-11 21:37                             ` Mathias Dahl
2020-05-11 22:39                               ` Mathias Dahl
2020-05-11 22:58                               ` Stefan Monnier
2020-05-16 22:10                                 ` Mathias Dahl
2020-05-16 22:22                                   ` Mathias Dahl
2020-05-17  3:13                                     ` Stefan Monnier
2020-05-17 14:59                                       ` Mathias Dahl
2020-05-17 15:45                                         ` Eli Zaretskii
2020-05-17 18:43                                           ` Mathias Dahl [this message]
2020-05-17 21:20                                             ` Stefan Monnier
2020-05-18 22:00                                               ` Mathias Dahl
2020-06-04 20:14                                                 ` Mathias Dahl
2017-10-07 22:40                 ` Stefan Monnier
2017-10-08 15:28                   ` Mathias Dahl
  -- strict thread matches above, loose matches on Subject: below --
2017-10-08  8:15 Seweryn Kokot
2017-10-08 15:25 ` Mathias Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABrcCQ4c_k3b7OenMU6xBgfO_mQgGST-7cj-T6JZ2N4fS_j6mA@mail.gmail.com \
    --to=mathias.dahl@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).