From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.devel Subject: Re: Mac OS Sierra tab feature breaks C-x 5 2 Date: Mon, 10 Jul 2017 21:17:58 +0200 Message-ID: References: <191BFCA3-3C5B-4A75-8985-A958E638ADCE@gmail.com> <20170706174204.GA19121@breton.holly.idiocy.org> <20170706221637.GA19607@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1144fa22da1e1e0553fb701e" X-Trace: blaine.gmane.org 1499714403 19359 195.159.176.226 (10 Jul 2017 19:20:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 10 Jul 2017 19:20:03 +0000 (UTC) Cc: Paul Michael Reilly , Jean-Christophe Helary , Emacs-Devel devel To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 10 21:19:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUeDp-00049n-59 for ged-emacs-devel@m.gmane.org; Mon, 10 Jul 2017 21:19:53 +0200 Original-Received: from localhost ([::1]:42604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUeDo-0006qo-LE for ged-emacs-devel@m.gmane.org; Mon, 10 Jul 2017 15:19:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUeD2-0006qh-LK for emacs-devel@gnu.org; Mon, 10 Jul 2017 15:19:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUeCz-0005TW-G8 for emacs-devel@gnu.org; Mon, 10 Jul 2017 15:19:04 -0400 Original-Received: from mail-vk0-f44.google.com ([209.85.213.44]:33911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUeCz-0005Sk-97 for emacs-devel@gnu.org; Mon, 10 Jul 2017 15:19:01 -0400 Original-Received: by mail-vk0-f44.google.com with SMTP id r125so53280141vkf.1 for ; Mon, 10 Jul 2017 12:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DQUMlzoZ8aByeSqxxSgwOJax/iHUdSb2uDEczYP+FQ0=; b=Z2EafP9TqdXk5GOXDtRPQjlS8fdAQ6m5BItVhXiVMdPIH3lKD1AtlwgBjlSTAu5I5n in+ap3uq8hDeHGGlfjXwJnBzqiNUmkMS15KyLFYNsO/k9Lyd9uIHGUmVUcTRbxHFlfeD OrBKVDDapjAUxwlWHXAdJ4ehLUnUOz8hydFK/H0VTC3C4VCWyOsf38lqFm5WF02LKknI w3BnwNDyq5S8lXH9C8THUILsN+BCq5v3GqlE0/Wckc2RFjJlPvJ5XLpVUUQB6X/H4fBt To0FaOqtqJktE0BKWD0HCq4XVKjBXNli/iRm/V8FXbfUiMqRbd0xrN5jD+y+a9ynx1SZ ZD2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DQUMlzoZ8aByeSqxxSgwOJax/iHUdSb2uDEczYP+FQ0=; b=d7vZAj2nLhvcnTIvA8bZiibkWrzpufRkbHHwuqJ1oYMwTmjAzgXiTdWq9+mpweqMfI 5jxiVO/Ck4i1ynIuiDaG8fLeFMGGVk6yItN2zJBozWZXQIFoMdyEMpJGb6lezbiFxghL PDbucrH05JzbZZy7R4xwrL34v4bLSqFI5yBU9pgAKD8QTwYMs7SrpbDoxE6HExEy1+5U EdMNVLoanR6TJUeTdni172HakoijxWf0SUoWxf9pPVxapQq64Sx7d2vgxtqm+lvnIk00 BGUoMp0Z36KeS/T0bQdSfrwQj6vawZEkJMuufve8JrO11i7iiHEEWHIdOW+vRxqkM4bm rj4A== X-Gm-Message-State: AIVw110LUbEnU8KhviEOgozkaiouO/4R2HNiWxeMuu/sO1hfY2lU8mKb UqKiYlOwFbsyn6EY68OjbwsCTx5MnA== X-Received: by 10.31.137.208 with SMTP id l199mr5851774vkd.32.1499714278791; Mon, 10 Jul 2017 12:17:58 -0700 (PDT) Original-Received: by 10.31.180.65 with HTTP; Mon, 10 Jul 2017 12:17:58 -0700 (PDT) In-Reply-To: <20170706221637.GA19607@breton.holly.idiocy.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.213.44 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216435 Archived-At: --001a1144fa22da1e1e0553fb701e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi! Unfortunately, it doesn't compile. I get the following error when I build on 10.10.5: nsterm.m:7078:26: error: use of undeclared identifier 'NSWindowTabbingModeDisallowed' [win setTabbingMode: NSWindowTabbingModeDisallowed]; Fortunately, the fix is simple. If we build on an older system, we can define the NSWindowTabbingModeXxx constants ourselves. -- Anders On Fri, Jul 7, 2017 at 12:16 AM, Alan Third wrote: > On Thu, Jul 06, 2017 at 06:42:04PM +0100, Alan Third wrote: > > We can make it a run time check, which would look something like > > > > if ([win respondsToSelector: @selector(setTabbingMode)]) > > [win setTabbingMode: NSWindowTabbingModeDisallowed]; > > > > but this will throw up compiler warnings on pre=E2=80=90Sierra versions= of > > macOS. I guess that=E2=80=99s maybe just the price to be paid. > > I=E2=80=99ve attached a patch to master for this. Can someone on macOS 10= .11 > or below give it a try and confirm that it compiles and runs? > -- > Alan Third > --001a1144fa22da1e1e0553fb701e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

Unfortunately, it doesn't compi= le. I get the following error when I build on 10.10.5:

<= div>nsterm.m:7078:26: error: use of undeclared identifier 'NSWindowTabb= ingModeDisallowed'
=C2=A0 =C2=A0 [win setTabbingMode: NSWindo= wTabbingModeDisallowed];

Fortunately, the fi= x is simple. If we build on an older system, we can define the NSWindowTabb= ingModeXxx constants ourselves.

=C2=A0 =C2=A0 -- A= nders


On Fri, Jul 7, 2017 at 12:16 AM, Alan Third <alan@idio= cy.org> wrote:
On Thu, Jul 06, 2017 at 06:42:04PM +0100, Alan Third wrote:
> We can make it a run time check, which would look something like
>
>=C2=A0 =C2=A0 =C2=A0if ([win respondsToSelector: @selector(setTabbingMo= de)])
>=C2=A0 =C2=A0 =C2=A0 =C2=A0[win setTabbingMode: NSWindowTabbingModeDisa= llowed];
>
> but this will throw up compiler warnings on pre=E2=80=90Sierra version= s of
> macOS. I guess that=E2=80=99s maybe just the price to be paid.

I=E2=80=99ve attached a patch to master for this. Can someone on mac= OS 10.11
or below give it a try and confirm that it compiles and runs?
--
Alan Third

--001a1144fa22da1e1e0553fb701e--