From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thiago Melo Newsgroups: gmane.emacs.devel Subject: Reversed tmm-prompt items when tmm-mid-prompt is nil Date: Sun, 28 May 2023 14:59:37 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21309"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 29 04:20:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3SVF-0005Qi-9g for ged-emacs-devel@m.gmane-mx.org; Mon, 29 May 2023 04:20:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3SUS-0007DH-RK; Sun, 28 May 2023 22:20:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3Hsb-0007kO-5a for emacs-devel@gnu.org; Sun, 28 May 2023 11:00:21 -0400 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3HsZ-0000P2-IH for emacs-devel@gnu.org; Sun, 28 May 2023 11:00:20 -0400 Original-Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5147a478c38so3371663a12.0 for ; Sun, 28 May 2023 08:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685286015; x=1687878015; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=8ksd6rHd1jdDyoyG52CmIWN9yq9qrevVecNI1mFTiKg=; b=kDBLOEGQ5N6Wp5OBE5rVKhzQ4tKGcSk/8djEyD0IUlE3DNX0p9sE8Yb7IxVQ+BRocC eWQZeklfw+IRrcgpqcbVOjuLpw+cjEnvxSHmb9g02wZhdhgC+EgAGyvdob6QBLL7ODZH T9yGGIjesrvraX6uF5qbwgCNdYyEAjh763teUKfAOiiPLaB7yYmVRm8SMXqvLBr1W40c bGrG1aJdbgm8/B6CwDZOxeS/4+Z+KPGvclUNyErPT/ouJzj0IKJhFvn0rm8WoRa1s9P6 T4S55NbHddrBzxvCZM2ebEp5hIXsIgJ0GYyZQy9N38QfiTDVClTxrzzSxIsVBAyujuZJ 9xMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685286015; x=1687878015; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8ksd6rHd1jdDyoyG52CmIWN9yq9qrevVecNI1mFTiKg=; b=clPbJOWCJeXd3ma+2ywhfDBOHCbMqp8sef8NTS3EMyVQrML5Gjd/CRdkun1k3Rb4Cn V7aBeguniPDJ+QBbB2BcU4YZpTBCX6tSolOnxAy+MQRhBowrH7cwZ48jxtS0vAo5yhub WJP3zy7IFQrTVrbNOsBclTUj/MezrLhYO/PD3/PFabomUtqEAvfd7poSNQUh4bZ2ZXjf 5C273sbSnY1AATUZbC6cQFb7EZl2MMVeOenqD5eL9gPu4AmwBT4kVtkCB79DeMmgtIoM TRw2U8A1GU9MSZMrDc1u1gQ50bd+eOxamnJPcUv36+sYL/kvE2UHhdcw1l/9o1BoD8AV YwFw== X-Gm-Message-State: AC+VfDzFvwlxyj2Re6Vfn5r/NC0On4CgPLq+NdK96BuNpuhOl64tHcTV I9E81KYpoMmjqF0w8oWLieHJ0eVfRAHuFJTrV2O3MKAv4YM= X-Google-Smtp-Source: ACHHUZ6zZSRJKIijLlyXF90b6rCkYlVznvPe58KpoYayH7LfXWeJsG3p9a71DGAl43fIEztLucp/+2y48IPnVzC0IYs= X-Received: by 2002:aa7:da96:0:b0:50d:dba8:c64a with SMTP id q22-20020aa7da96000000b0050ddba8c64amr5542639eds.18.1685286015256; Sun, 28 May 2023 08:00:15 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=tmdmelo@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 28 May 2023 22:20:08 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306382 Archived-At: Commit #5d844e1 fixed `tmm-prompt' for Emacs 29 (Bug#63754. Thanks, Eli!) and even made the `tmm-mid-prompt' = nil option work again. The fix also surfaced one inconsistency between nil and non-nil `tmm-mid-prompt'. When nil, the items shown by `tmm-prompt' are reversed. Compare these two cases: (let ((tmm-mid-prompt "==>") (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3))))) (tmm-prompt test-menu)) (let ((tmm-mid-prompt nil) (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3))))) (tmm-prompt test-menu)) It seems innocuous and not worth a bug report. Still, here's a way to make this behavior more consistent: --- a/lisp/tmm.el 2023-05-27 21:26:44.594743965 +0200 +++ b/lisp/tmm.el 2023-05-28 01:44:53.850880002 +0200 @@ -172,7 +172,7 @@ (defun tmm-prompt (menu &optional in-pop (let ((index-of-default 0)) (if tmm-mid-prompt (setq tmm-km-list (tmm-add-shortcuts tmm-km-list)) - t) + (setq tmm-km-list (reverse tmm-km-list))) ;; Find the default item's index within the menu bar. ;; We use this to decide the initial minibuffer contents ;; and initial history position.