unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 6924320: Take care of a FIXME in cus-edit-tests.el
Date: Fri, 20 Nov 2020 19:16:43 -0300	[thread overview]
Message-ID: <CABczVwe+ZKh+5BF-XFJSMe6sM=sgSE7Bz8Fwc8yQ9v4OJ+XrAg@mail.gmail.com> (raw)
In-Reply-To: <jwvmtzbzoag.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

> > -    (customize-saved)
> > -    (should (search-forward cus-edit-tests--obsolete-option-tag nil
t))))
> > +    (unwind-protect
> > +        (progn
> > +          (put 'cus-edit-tests--obsolete-option-tag 'saved-value '(t))
> > +          (customize-saved)
> > +          (should (search-forward cus-edit-tests--obsolete-option-tag
nil t)))
> > +      (put 'cus-edit-tests--obsolete-option-tag 'saved-value nil))))
>
> These are (fairly rare) good use-cases for `cl-letf`:
>
>     (cl-letf (((get 'cus-edit-tests--obsolete-option-tag 'saved-value)
'(t)))
>       (customize-saved)
>       (should (search-forward cus-edit-tests--obsolete-option-tag nil t)))

Indeed.  I didn't know about cl-letf, thanks.

BTW, C-h f cl-letf RET
shows a link to the info node (cl) Function Bindings.  Maybe a better
link is (cl) Modify Macros.

[-- Attachment #2: Type: text/html, Size: 1055 bytes --]

      reply	other threads:[~2020-11-20 22:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201120213804.8196.42565@vcs0.savannah.gnu.org>
     [not found] ` <20201120213806.0C179209DE@vcs0.savannah.gnu.org>
2020-11-20 21:57   ` master 6924320: Take care of a FIXME in cus-edit-tests.el Stefan Monnier
2020-11-20 22:16     ` Mauro Aranda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABczVwe+ZKh+5BF-XFJSMe6sM=sgSE7Bz8Fwc8yQ9v4OJ+XrAg@mail.gmail.com' \
    --to=maurooaranda@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).