unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 527413f: Go back to not using custom-push-theme when enabling a theme
Date: Fri, 6 Nov 2020 12:30:41 -0300	[thread overview]
Message-ID: <CABczVwcpCOdUuD6R+EjszMb0_iVVMtdYK2W2+suFE_E1ywvSOw@mail.gmail.com> (raw)
In-Reply-To: <jwvtuu2edg0.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hi, could you explain what's the motivation behind this change?
> Is it an optimization (i.e. with hopefully no visible effect), or does
> it fix an actual problem?  If it fixes an actual problem, could you try
> and add a corresponding regression test for it?

I made a dumb mistake while fixing Bug#34027.  When enabling a theme we
need to change the theme-value or theme-face property of the symbols
the theme customizes, and also save a "changed" value, in case there is
any.  Since custom-push-theme did that, I thought it was fine to call
custom-push-theme here and in disable-theme (I haven't had the time yet
to test if something bad happens in disable-theme).

As a result, theme settings, saved under the theme-settings property of
THEME, got duplicated (you can see the code that adds each setting, at
the end of custom-push-theme).  So, this change fixes that bug I
introduced.  Since the test for Bug#34027, custom--test-theme-variables,
still pass after the change, I didn't consider adding a test for this.
But sure, it should be easy to add one.

[-- Attachment #2: Type: text/html, Size: 1373 bytes --]

  reply	other threads:[~2020-11-06 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201106123610.24601.8123@vcs0.savannah.gnu.org>
     [not found] ` <20201106123612.2172F20B2C@vcs0.savannah.gnu.org>
2020-11-06 15:04   ` master 527413f: Go back to not using custom-push-theme when enabling a theme Stefan Monnier
2020-11-06 15:30     ` Mauro Aranda [this message]
2020-11-06 16:47       ` Stefan Monnier
2020-11-07 13:01         ` Mauro Aranda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABczVwcpCOdUuD6R+EjszMb0_iVVMtdYK2W2+suFE_E1ywvSOw@mail.gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).