From: Trey Jackson <bigfaceworm@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs 24.4 and advice
Date: Fri, 31 Oct 2014 12:26:19 -0700 [thread overview]
Message-ID: <CABainDy8gLSWr0oYqo43NRZFQkLSPs4+uJYdVD+WQVPR+8D9uQ@mail.gmail.com> (raw)
In-Reply-To: <jwvioj0xe92.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
Thanks!
I was just a bit surprised by no mention of it anywhere in the mailing list
or NEWS. It's an easy fix and no big deal. Next time I'll have to start
perusing the commit logs...
On Fri, Oct 31, 2014 at 12:02 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> >> What do you use them for?
> > It's left over code, I presume they were there because, upon first read
> of
> > the documentation, it looked as though you needed to call
> (ad-start-advice)
> > to get things going.
>
> Right, and I think this documentation was a left from Emacs-18.
>
> Calling ad-start-advice has been unnecessary since at least Emacs-19.28
> (the first "official" Emacs-19 release), i.e. about 20 years now ;-)
>
> If more people bump into it, we'll have to add an obsolete dummy
> ad-start-advice for people who followed the tutorial.
>
> >> Which tutorial are you referring to?
> > ;; @ Foo games: An advice tutorial
>
> Oh, indeed, the advice.el Commentary: includes a tutorial. Sorry,
> I didn't remember.
>
>
> Stefan
>
--
Trey Jackson
bigfaceworm@gmail.com
"Like any truly useful program, `hello' contains a built-in mail reader."
-- GNU's Bulletin, July 1996
[-- Attachment #2: Type: text/html, Size: 1903 bytes --]
prev parent reply other threads:[~2014-10-31 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 16:26 Emacs 24.4 and advice Trey Jackson
2014-10-31 17:47 ` Stefan Monnier
2014-10-31 18:02 ` Trey Jackson
2014-10-31 19:02 ` Stefan Monnier
2014-10-31 19:26 ` Trey Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABainDy8gLSWr0oYqo43NRZFQkLSPs4+uJYdVD+WQVPR+8D9uQ@mail.gmail.com \
--to=bigfaceworm@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).