From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Bug#23924 - crashes on next OS X release Date: Tue, 2 Aug 2016 15:59:30 +0100 Message-ID: References: <83shv70zn5.fsf@gnu.org> <20160718190346.GA11206@breton.holly.idiocy.org> <20160722215416.GA17147@breton.holly.idiocy.org> NNTP-Posting-Host: blaine Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1143f26cc82a7d053917f675 X-Trace: blaine.gmane.org 1470150022 17987 195.159.176.226 (2 Aug 2016 15:00:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Aug 2016 15:00:22 +0000 (UTC) To: Eli Zaretskii , Emacs-Devel devel , John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 02 17:00:14 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUbAz-0004AP-Aj for ged-emacs-devel@m.gmane.org; Tue, 02 Aug 2016 17:00:13 +0200 Original-Received: from localhost ([::1]:57160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUbAv-0007cu-Rz for ged-emacs-devel@m.gmane.org; Tue, 02 Aug 2016 11:00:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUbAO-0007bx-MS for emacs-devel@gnu.org; Tue, 02 Aug 2016 10:59:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUbAM-0001px-EH for emacs-devel@gnu.org; Tue, 02 Aug 2016 10:59:35 -0400 Original-Received: from mail-vk0-x229.google.com ([2607:f8b0:400c:c05::229]:36330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUbAJ-0001pl-FE; Tue, 02 Aug 2016 10:59:31 -0400 Original-Received: by mail-vk0-x229.google.com with SMTP id n129so123992921vke.3; Tue, 02 Aug 2016 07:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=rQtgCvd+XuYURxAjmH8PmCWkF/sF22V0O8G2h3r9TCQ=; b=gVHpujSkHOnmzwEEU40b5d0YO2UyAzrBDd0PmEjaI+ASzjABPcigk1MogrFhs9In+n r3e0lv0cWvIRQKhgGe16unfFGIVb0HkJEsLwNtP35D3NjlrVsWZoBLnAd/O2vTlYNFqa 0aYFYMvXrlsu5nmKquxDU/aH/5lJkXyU+1U+Y/4HkpL/F4/c6QvhhmFuHxPnwBJ1LVKl hHvBZsPLcRw1NDv3tBX2GED9i7rK+wuVziFYu2tYcY2J9DvKgXRzf+sebyAFdc87Qnr9 cY7QoV8p/ZUSoZeowRDWXJSmqDpFKCobUuO0Pee98hz65fHiZlc/zOs/KZnzESgCw3uC 1VfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=rQtgCvd+XuYURxAjmH8PmCWkF/sF22V0O8G2h3r9TCQ=; b=h66gI9tqe9xfmnfqpEzGmSocjac8xlGHp6eEf5hSn5kQhd6gTD89h1DLB6XsU7Sfba Ub3R05bppeicOvii3uBS8X8bkE9jInPEiru88ywDNxez89Ub5we77VM+d3YisSeL4oef Z+/jByj7cj2mJAnxGI7aNrUg7qy2bF+ZIsvnt5YIU57a/8NgFg5ttFFIUU+AEOXa4WAN C1wwzvwTUs+IvrbRuSew3LhbqcrjErMs8hqT3S1gxnTnK9VPVzvfHNCiaEoR0oTYgwte wsXLHR2zDXtwKX31Dt4+NC4JHO89V0Ot4srAN8JfnXP0DcCkSeCceBeohqO+eG+RpGZv C2Mw== X-Gm-Message-State: AEkoout/AqRH87HE2iHSYIF5jlW9K6g4Hwdok7/5kaQSePiHLRMaDAa40qxbCvqPr5/x+rakI9oqaqzWWDp+mA== X-Received: by 10.31.5.213 with SMTP id 204mr26024173vkf.60.1470149970895; Tue, 02 Aug 2016 07:59:30 -0700 (PDT) Original-Received: by 10.176.65.41 with HTTP; Tue, 2 Aug 2016 07:59:30 -0700 (PDT) In-Reply-To: <20160722215416.GA17147@breton.holly.idiocy.org> X-Google-Sender-Auth: vTA0HBU5jkqjnFeb6SdVaCqEvds X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c05::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206354 Archived-At: --001a1143f26cc82a7d053917f675 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi John, are you OK with the patch? On 22 July 2016 at 22:54, Alan Third wrote: > On Mon, Jul 18, 2016 at 08:03:46PM +0100, Alan Third wrote: > > On Mon, Jul 18, 2016 at 09:16:09AM -0700, John Wiegley wrote: > > > >>>>> "EZ" =3D=3D Eli Zaretskii writes: > > > > > > EZ> If you are confident that it won't do any trouble, and that 10.10= , > and > > > EZ> only that version, needs this fix, feel free to push to emacs-25. > > > > > > Before you do, can you show us the patch here so that I can have a > sense of > > > what it changes? I've been running emacs-25 crash-free on 10.11 for > many > > > months now. > > > > I=E2=80=99m not that confident as I couldn=E2=80=99t find anything abou= t the bug in > > question except what was in the bug report and comment in the code. I > > tried removing the fix and can=E2=80=99t reproduce the original problem= on > > 10.11. It=E2=80=99s possible it=E2=80=99s actually been fixed in later = releases of > > 10.10 too. > > I=E2=80=99ve got a new patch. One of the testers of the first patch ran i= nto > bug#18993, so it=E2=80=99s clearly still an issue, and further investigat= ion > leaves me suspecting that, contrary to the bug report thread, it=E2=80=99= s not > an OS X bug, but something to do with how Emacs is handling events. > > The new patch leaves the fix in place and uses an existing GNUStep fix > to ensure that postEvent always runs in the main thread. That fixes > bug#23924. > > There=E2=80=99s probably an argument to be made that we should fix 18993 > properly, but I don=E2=80=99t think we have anyone who knows the NS port = well > enough to do it, as it would require a substantial rewrite of the > event loop. > > If this is to be applied to Emacs 25, let me know if it=E2=80=99s to go t= o > master too. I=E2=80=99m unsure how it=E2=80=99s handled. > -- > Alan Third > --=20 Alan Third --001a1143f26cc82a7d053917f675 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi John, are you OK with the patch?

On 22 July 2016 at 22:54, Alan Thi= rd <alan@idiocy.org> wrote:
= On Mon, Jul 18, 2016 at 08:03:46PM +0100, Alan Third wrote= :
> On Mon, Jul 18, 2016 at 09:16:09AM -0700, John Wiegley wrote:
> > >>>>> "EZ" =3D=3D Eli Zaretskii <eliz@gnu.org> writes:
> >
> > EZ> If you are confident that it won't do any trouble, and= that 10.10, and
> > EZ> only that version, needs this fix, feel free to push to em= acs-25.
> >
> > Before you do, can you show us the patch here so that I can have = a sense of
> > what it changes?=C2=A0 I've been running emacs-25 crash-free = on 10.11 for many
> > months now.
>
> I=E2=80=99m not that confident as I couldn=E2=80=99t find anything abo= ut the bug in
> question except what was in the bug report and comment in the code. I<= br> > tried removing the fix and can=E2=80=99t reproduce the original proble= m on
> 10.11. It=E2=80=99s possible it=E2=80=99s actually been fixed in later= releases of
> 10.10 too.

I=E2=80=99ve got a new patch. One of the testers of the first patch = ran into
bug#18993, so it=E2=80=99s clearly still an issue, and further investigatio= n
leaves me suspecting that, contrary to the bug report thread, it=E2=80=99s = not
an OS X bug, but something to do with how Emacs is handling events.

The new patch leaves the fix in place and uses an existing GNUStep fix
to ensure that postEvent always runs in the main thread. That fixes
bug#23924.

There=E2=80=99s probably an argument to be made that we should fix 18993 properly, but I don=E2=80=99t think we have anyone who knows the NS port we= ll
enough to do it, as it would require a substantial rewrite of the
event loop.

If this is to be applied to Emacs 25, let me know if it=E2=80=99s to go to<= br> master too. I=E2=80=99m unsure how it=E2=80=99s handled.
--
Alan Third



--
Alan Th= ird
--001a1143f26cc82a7d053917f675--