unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: David Reitter <david.reitter@gmail.com>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: macOS: Cursor leaving traces when scrolling
Date: Sun, 7 Oct 2018 20:31:33 +0100	[thread overview]
Message-ID: <CABGBtwkDWd16c2to0sKkv1ZhUOUoFkf6eaegDrRJTnLZ_pW4gg@mail.gmail.com> (raw)
In-Reply-To: <A97DE9EC-BA9F-4DE6-BD91-7391FE0DED5E@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

On Sun, 7 Oct 2018, 19:36 David Reitter, <david.reitter@gmail.com> wrote:

> On Oct 7, 2018, at 7:14 AM, Alan Third <alan@idiocy.org> wrote:
>
> > The attached patch fixes it, but it marks the whole area dirty instead
> > of copying it, so it will be redrawn at the next expose event. I can’t
> > see any difference in simple testing, but it may slow down scrolling
> > on very complex buffers.
>
> Thank you.
> I can’t see any obvious difference in speed either on a modern laptop.
>
> NSView scrollRect has been deprecated, so replacing it is a good thing all
> other things being equal. Implementing true scrolling rather than redrawing
> would still be worth a try, as display doesn’t seem particularly fast.
>
> I’ll apply it to my own branch and report back if users complain.
>

I did eventually find this was a fair bit slower if I made the frame quite
large and zoomed the text out quite a lot, so I suppose it might affect
people using sublimetext style "maps".

I have come up with a possible work around continuing to use scrollRect,
but I've not had time to try implementing it yet.

As you say it would be better to use proper scrolling without scrollRect,
but I don't see any obvious way to do it. I suspect I just don't have
enough knowledge of the cocoa APIs.

[-- Attachment #2: Type: text/html, Size: 1859 bytes --]

  reply	other threads:[~2018-10-07 19:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2D30F998-9417-4B47-955E-702503BF191F@gmail.com>
     [not found] ` <20181004215834.GB15008@breton.holly.idiocy.org>
2018-10-06 12:06   ` macOS: Cursor leaving traces when scrolling David Reitter
2018-10-07 11:14     ` Alan Third
2018-10-07 18:36       ` David Reitter
2018-10-07 19:31         ` Alan Third [this message]
2018-10-07 21:30           ` David Reitter
2018-10-07 21:35             ` Alan Third
2018-10-07 21:40               ` David Reitter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABGBtwkDWd16c2to0sKkv1ZhUOUoFkf6eaegDrRJTnLZ_pW4gg@mail.gmail.com \
    --to=alan@idiocy.org \
    --cc=david.reitter@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).