From: Jesse Medeiros <jessenzr@gmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Kangas <stefan@marxist.se>,
emacs-devel@gnu.org
Subject: Re: Patch to vertically center line content when using line-spacing variable
Date: Thu, 12 Sep 2019 09:08:38 -0300 [thread overview]
Message-ID: <CABDXFDmnx3nmbOFP6qa259BAHoBV4vFpo3bg5CyXqf0JbC4zyg@mail.gmail.com> (raw)
In-Reply-To: <m2k1ah7tha.fsf@gmail.com>
> Hmm, should this be customizable, like 'line-spacing' is? In any case,
> I think the doc string of 'line-spacing' should refer to this new
> variable as well.
Yes, it's supposed to be customizable like line-spacing. Personally I
think center vertically should be the default behaviour, but I created
this new variable so it won't change with default to nil the setup of
other people.
> Also: could this not work as a new type of value for 'line-spacing'
> instead? Something like
>
> '(both . 5)
>
> to mean 5 pixels above and below?
I guess it could, but does that make sense? I think one would expect
the line to be centered by default. That's how it works on other
editors.
> I donʼt think you implemented this as a frame parameter, which means the
> documentation should go in "@node Line Height" in display.texi, or you
> could implement the frame parameter as well. [1]
My bad. I searched for currencies of line-spacing at the docs and I
though I had found the right place. I'll change this to display.texi.
> Jesse> if (extra_line_spacing > 0)
> Jesse> {
> Jesse> - it->descent += extra_line_spacing;
> Jesse> + if (! BVAR (XBUFFER (it->w->contents), line_spacing_vertical_center))
>
> I think this currently works because Qnil == 0, for now, but you should
> probably use NILP.
Good catch, thanks.
PS: Sorry for the late reply, it's been a busy week.
next prev parent reply other threads:[~2019-09-12 12:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 21:53 Patch to vertically center line content when using line-spacing variable Jesse Medeiros
2019-08-31 22:36 ` Stefan Kangas
2019-09-01 0:01 ` Jesse Medeiros
2019-09-03 0:01 ` Jesse Medeiros
2019-09-07 9:50 ` Eli Zaretskii
2019-09-08 23:24 ` Jesse Medeiros
2019-09-09 7:39 ` martin rudalics
2019-09-09 8:40 ` Robert Pluim
2019-09-12 12:08 ` Jesse Medeiros [this message]
2019-09-12 14:26 ` Robert Pluim
2019-09-12 20:49 ` Jesse Medeiros
2019-09-13 9:35 ` Robert Pluim
2019-09-29 23:54 ` Jesse Medeiros
2019-09-30 7:07 ` Robert Pluim
-- strict thread matches above, loose matches on Subject: below --
2020-01-23 16:32 조성빈
2020-01-23 19:22 ` Eli Zaretskii
2020-02-07 17:06 ` Jesse Medeiros
2020-02-07 18:26 ` Eli Zaretskii
2020-04-05 18:55 ` 조성빈 via "Emacs development discussions.
2020-04-06 21:13 ` Jesse Medeiros
2020-04-07 14:17 ` Eli Zaretskii
2021-04-12 20:24 email
2021-04-25 19:41 ` Lars Ingebrigtsen
2021-04-25 20:15 ` john muhl
2021-04-25 20:21 ` Eli Zaretskii
2021-04-25 23:25 ` Fu Yuan
2021-04-25 23:28 ` Stefan Kangas
2021-04-25 23:56 ` Clément Pit-Claudel
2021-04-26 1:00 ` Stefan Kangas
2021-04-26 14:00 ` Clément Pit-Claudel
2021-04-25 23:56 ` Clément Pit-Claudel
2021-04-26 12:35 ` Eli Zaretskii
2021-04-26 20:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABDXFDmnx3nmbOFP6qa259BAHoBV4vFpo3bg5CyXqf0JbC4zyg@mail.gmail.com \
--to=jessenzr@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).