From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jesse Medeiros Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Sat, 31 Aug 2019 21:01:44 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000003c11590591729044" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="123489"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 01 02:02:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i4DKK-000VyU-9j for ged-emacs-devel@m.gmane.org; Sun, 01 Sep 2019 02:02:40 +0200 Original-Received: from localhost ([::1]:46790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4DKI-00051v-Hw for ged-emacs-devel@m.gmane.org; Sat, 31 Aug 2019 20:02:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57659) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4DJe-00051o-2b for emacs-devel@gnu.org; Sat, 31 Aug 2019 20:01:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4DJc-0003CI-Iz for emacs-devel@gnu.org; Sat, 31 Aug 2019 20:01:57 -0400 Original-Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:34255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i4DJc-0003C2-Dw for emacs-devel@gnu.org; Sat, 31 Aug 2019 20:01:56 -0400 Original-Received: by mail-qk1-x731.google.com with SMTP id q203so294088qke.1 for ; Sat, 31 Aug 2019 17:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZxqiAODMbZzKwl2Du6/HpDZdvGW/pPFNYe/cVgyBNpw=; b=Z2yiMNsr0W4FoQoKLNuvQ4u6A9p4nt9kjCc0/1GxpEddWT9CHS/gl+YTs71bHHcmPp yi2o1i0L5uLjI/kERYpoq6ow3NmdLVcenUeTbdBH0syqSoXqBtGfoWBvtMRQdmI/J/+n N5vfCS3LCbH6riADIRJzGQnRUpcT8AXBfKdCycZYVBlJtlyqml/gryPSa67sELS7sdXh ZKAcV98T6thZeBOg9Wsanqsr2zLk9dhfGStIEjJIm0IpwE337UpI9y5pNXmZ0YeWRIA/ EMnAK51evWz0LEXAKocrdh5fMLft2d+RnXoJqSRJQINX+rTcAtC61wEk+SdqizXBwbrP aW8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZxqiAODMbZzKwl2Du6/HpDZdvGW/pPFNYe/cVgyBNpw=; b=HBBA4ea76AZmpiK8JH44CGn7ypBtRMfPUyQcAc3FW22oLZzQ/vhuF31s+t8yN4zega h57DzQZd7U1laOgbiro1Le4i0eLZ4PZJV2FOGjLO0vRzPD4VqTpvb0spIfnhb91sq2+k qByf/ssNxJmZimHQQ7d+VtynXD+6eqFnC+wF3Oazpk/4IvGvxOvp2Euj2J1BK5e7xxwP qYpkJkxdGZ+bYbQwx1vjcytR6mUI3fi16mCEyz9ucqOWxgkec5z+agOhMt9uVs6eGapm 6Hl7t8gAf5ACfW+6f885MH/TORipuWtA3MuJNf7+OKCs3pF7uJTaxMqRUGrSace5XlPF +I8A== X-Gm-Message-State: APjAAAWptpz3GekfS4/qnBdqZhxhxHDsj0lWkvMWqH/qKeeaOwbo4bBc VgA8S0ent4dyQlXxrgPqn4dv0l8bV/2Fw5OXL4T2X/ZhCx0= X-Google-Smtp-Source: APXvYqwc1NOk2Uiwg5euTOUUYT/kzl08MAkZ+G0a0LHlHjVJmOF4lJqwyiSfcuNaStTmTQ46Ae/fWd60hS5RRbhtpYU= X-Received: by 2002:a37:6144:: with SMTP id v65mr5650483qkb.465.1567296115700; Sat, 31 Aug 2019 17:01:55 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::731 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239738 Archived-At: --0000000000003c11590591729044 Content-Type: text/plain; charset="UTF-8" > The preferred format for patches is to have a commit message in the > form of a ChangeLog entry, and to send it as an attached file produced > with e.g. "git format-patch -1". Oh, sorry I missed that. I'm sending the patch in the attachment. Thanks for the tips. On Sat, Aug 31, 2019 at 7:36 PM Stefan Kangas wrote: > > Jesse Medeiros : > > > Here's the link for the patch: > > > > https://github.com/sollidsnake/emacs/commit/aff5c59d10001e1161884ef3d0725eda86fa3ea0 > > Hi Jesse, > > Thanks, and welcome to Emacs. > > The preferred format for patches is to have a commit message in the > form of a ChangeLog entry, and to send it as an attached file produced > with e.g. "git format-patch -1". If you could re-send your patch in > that format, it would help others to review your changes. > > You can find the details in the CONTRIBUTE file in the source > repository. One tip is also to have a look at the git log to see how > others have formatted their commit messages. > > Best regards, > Sefan Kangas --0000000000003c11590591729044 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Center-lines-vertically-with-line-spacing-vertical-c.patch" Content-Disposition: attachment; filename="0001-Center-lines-vertically-with-line-spacing-vertical-c.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k007m0pd0 RnJvbSA2MDUzMmY2MDg3ZDBmM2NjMjAxOTdkYTE3OTBkMmY1Y2VjMGVjYmVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXNzZSBOYXphcmlvIDxqZXNzZW56ckBnbWFpbC5jb20+CkRh dGU6IFNhdCwgMzEgQXVnIDIwMTkgMTU6MzU6MzQgLTAzMDAKU3ViamVjdDogW1BBVENIXSBDZW50 ZXIgbGluZXMgdmVydGljYWxseSB3aXRoIGxpbmUtc3BhY2luZy12ZXJ0aWNhbC1jZW50ZXIKCldo ZW4gdXNpbmcgbGluZS1zcGFjaW5nLCB0aGUgbmV3IHZhcmlhYmxlIGxpbmUtc3BhY2luZy12ZXJ0 aWNhbC1jZW50ZXIKY2FuIGJlIHNldCB0byBub24tbmlsIHRvIGNlbnRlciB0aGUgbGluZSBjb250 ZW50IHZlcnRpY2FsbHkuCi0tLQogc3JjL2J1ZmZlci5jIHwgMTMgKysrKysrKysrKysrKwogc3Jj L2J1ZmZlci5oIHwgIDQgKysrKwogc3JjL3hkaXNwLmMgIHwgIDggKysrKysrKy0KIDMgZmlsZXMg Y2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3Ny Yy9idWZmZXIuYyBiL3NyYy9idWZmZXIuYwppbmRleCA2MmEzZDY2YzhiLi4xYjlmOTZkNjFiIDEw MDY0NAotLS0gYS9zcmMvYnVmZmVyLmMKKysrIGIvc3JjL2J1ZmZlci5jCkBAIC0yMTksNiArMjE5 LDExIEBAIGJzZXRfZXh0cmFfbGluZV9zcGFjaW5nIChzdHJ1Y3QgYnVmZmVyICpiLCBMaXNwX09i amVjdCB2YWwpCiAgIGItPmV4dHJhX2xpbmVfc3BhY2luZ18gPSB2YWw7CiB9CiBzdGF0aWMgdm9p ZAorYnNldF9saW5lX3NwYWNpbmdfdmVydGljYWxfY2VudGVyIChzdHJ1Y3QgYnVmZmVyICpiLCBM aXNwX09iamVjdCB2YWwpCit7CisgIGItPmxpbmVfc3BhY2luZ192ZXJ0aWNhbF9jZW50ZXJfID0g dmFsOworfQorc3RhdGljIHZvaWQKIGJzZXRfZmlsZV9mb3JtYXQgKHN0cnVjdCBidWZmZXIgKmIs IExpc3BfT2JqZWN0IHZhbCkKIHsKICAgYi0+ZmlsZV9mb3JtYXRfID0gdmFsOwpAQCAtOTU2LDYg Kzk2MSw3IEBAIHJlc2V0X2J1ZmZlciAocmVnaXN0ZXIgc3RydWN0IGJ1ZmZlciAqYikKICAgICAo YiwgQlZBUiAoJmJ1ZmZlcl9kZWZhdWx0cywgZW5hYmxlX211bHRpYnl0ZV9jaGFyYWN0ZXJzKSk7 CiAgIGJzZXRfY3Vyc29yX3R5cGUgKGIsIEJWQVIgKCZidWZmZXJfZGVmYXVsdHMsIGN1cnNvcl90 eXBlKSk7CiAgIGJzZXRfZXh0cmFfbGluZV9zcGFjaW5nIChiLCBCVkFSICgmYnVmZmVyX2RlZmF1 bHRzLCBleHRyYV9saW5lX3NwYWNpbmcpKTsKKyAgYnNldF9saW5lX3NwYWNpbmdfdmVydGljYWxf Y2VudGVyIChiLCBCVkFSICgmYnVmZmVyX2RlZmF1bHRzLCBsaW5lX3NwYWNpbmdfdmVydGljYWxf Y2VudGVyKSk7CiAKICAgYi0+ZGlzcGxheV9lcnJvcl9tb2RpZmYgPSAwOwogfQpAQCAtNTE5MCw2 ICs1MTk2LDcgQEAgaW5pdF9idWZmZXJfb25jZSAodm9pZCkKICAgWFNFVEZBU1RJTlQgKEJWQVIg KCZidWZmZXJfbG9jYWxfZmxhZ3MsIGhlYWRlcl9saW5lX2Zvcm1hdCksIGlkeCk7ICsraWR4Owog ICBYU0VURkFTVElOVCAoQlZBUiAoJmJ1ZmZlcl9sb2NhbF9mbGFncywgY3Vyc29yX3R5cGUpLCBp ZHgpOyArK2lkeDsKICAgWFNFVEZBU1RJTlQgKEJWQVIgKCZidWZmZXJfbG9jYWxfZmxhZ3MsIGV4 dHJhX2xpbmVfc3BhY2luZyksIGlkeCk7ICsraWR4OworICBYU0VURkFTVElOVCAoQlZBUiAoJmJ1 ZmZlcl9sb2NhbF9mbGFncywgbGluZV9zcGFjaW5nX3ZlcnRpY2FsX2NlbnRlciksIGlkeCk7ICsr aWR4OwogICBYU0VURkFTVElOVCAoQlZBUiAoJmJ1ZmZlcl9sb2NhbF9mbGFncywgY3Vyc29yX2lu X25vbl9zZWxlY3RlZF93aW5kb3dzKSwgaWR4KTsgKytpZHg7CiAKICAgLyogYnVmZmVyX2xvY2Fs X2ZsYWdzIGNvbnRhaW5zIG5vIHBvaW50ZXJzLCBzbyBpdCdzIHNhZmUgdG8gdHJlYXQgaXQKQEAg LTUyNTksNiArNTI2Niw3IEBAIGluaXRfYnVmZmVyX29uY2UgKHZvaWQpCiAgIGJzZXRfYmlkaV9w YXJhZ3JhcGhfc2VwYXJhdGVfcmUgKCZidWZmZXJfZGVmYXVsdHMsIFFuaWwpOwogICBic2V0X2N1 cnNvcl90eXBlICgmYnVmZmVyX2RlZmF1bHRzLCBRdCk7CiAgIGJzZXRfZXh0cmFfbGluZV9zcGFj aW5nICgmYnVmZmVyX2RlZmF1bHRzLCBRbmlsKTsKKyAgYnNldF9saW5lX3NwYWNpbmdfdmVydGlj YWxfY2VudGVyICgmYnVmZmVyX2RlZmF1bHRzLCBRbmlsKTsKICAgYnNldF9jdXJzb3JfaW5fbm9u X3NlbGVjdGVkX3dpbmRvd3MgKCZidWZmZXJfZGVmYXVsdHMsIFF0KTsKIAogICBic2V0X2VuYWJs ZV9tdWx0aWJ5dGVfY2hhcmFjdGVycyAoJmJ1ZmZlcl9kZWZhdWx0cywgUXQpOwpAQCAtNjI0OCw2 ICs2MjU2LDExIEBAIGZyb20gKGFicyBQT1NJVElPTikuICBJZiBQT1NJVElPTiBpcyBwb3NpdGl2 ZSwgcG9pbnQgd2FzIGF0IHRoZSBmcm9udAogSWYgdmFsdWUgaXMgYSBmbG9hdGluZyBwb2ludCBu dW1iZXIsIGl0IHNwZWNpZmllcyB0aGUgc3BhY2luZyByZWxhdGl2ZQogdG8gdGhlIGRlZmF1bHQg ZnJhbWUgbGluZSBoZWlnaHQuICBBIHZhbHVlIG9mIG5pbCBtZWFucyBhZGQgbm8gZXh0cmEgc3Bh Y2UuICAqLyk7CiAKKyAgREVGVkFSX1BFUl9CVUZGRVIgKCJsaW5lLXNwYWNpbmctdmVydGljYWwt Y2VudGVyIiwKKwkJICAgICAmQlZBUiAoY3VycmVudF9idWZmZXIsIGxpbmVfc3BhY2luZ192ZXJ0 aWNhbF9jZW50ZXIpLCBRbmlsLAorICAgICAgICAgICAgICAgICAgICAgZG9jOiAvKiBOb24tbmls IHdpbGwgY2VudGVyIHRoZSBsaW5lIGNvbnRlbnQgdmVydGljYWxseQord2hlbiB1c2luZyBgbGlu ZS1zcGFjaW5nJyB2YXJpYWJsZS4gICovKTsKKwogICBERUZWQVJfUEVSX0JVRkZFUiAoImN1cnNv ci1pbi1ub24tc2VsZWN0ZWQtd2luZG93cyIsCiAJCSAgICAgJkJWQVIgKGN1cnJlbnRfYnVmZmVy LCBjdXJzb3JfaW5fbm9uX3NlbGVjdGVkX3dpbmRvd3MpLCBRbmlsLAogCQkgICAgIGRvYzogLyog Tm9uLW5pbCBtZWFucyBzaG93IGEgY3Vyc29yIGluIG5vbi1zZWxlY3RlZCB3aW5kb3dzLgpkaWZm IC0tZ2l0IGEvc3JjL2J1ZmZlci5oIGIvc3JjL2J1ZmZlci5oCmluZGV4IDIwODBhNmY0MGIuLjQ4 Y2YwNmQwNmYgMTAwNjQ0Ci0tLSBhL3NyYy9idWZmZXIuaAorKysgYi9zcmMvYnVmZmVyLmgKQEAg LTc0MCw2ICs3NDAsMTAgQEAgI2RlZmluZSBCVkFSKGJ1ZiwgZmllbGQpICgoYnVmKS0+ZmllbGQg IyMgXykKICAgICAgaW4gdGhlIGRpc3BsYXkgb2YgdGhpcyBidWZmZXIuICAqLwogICBMaXNwX09i amVjdCBleHRyYV9saW5lX3NwYWNpbmdfOwogCisgIC8qIFdoZW4gbm9uLW5pbCB3aWxsIGNlbnRl ciB0aGUgbGluZSBjb250ZW50IHZlcnRpY2FsbHkuIFRvIGJlIHVzZWQKKyAgICAgYWxvbmcgd2l0 aCBgbGluZS1zcGFjaW5nJy4gICovCisgIExpc3BfT2JqZWN0IGxpbmVfc3BhY2luZ192ZXJ0aWNh bF9jZW50ZXJfOworCiAgIC8qIEN1cnNvciB0eXBlIHRvIGRpc3BsYXkgaW4gbm9uLXNlbGVjdGVk IHdpbmRvd3MuCiAgICAgIHQgbWVhbnMgdG8gdXNlIGhvbGxvdyBib3ggY3Vyc29yLgogICAgICBT ZWUgYGN1cnNvci10eXBlJyBmb3Igb3RoZXIgdmFsdWVzLiAgKi8KZGlmZiAtLWdpdCBhL3NyYy94 ZGlzcC5jIGIvc3JjL3hkaXNwLmMKaW5kZXggNzViYzUzNmNiOS4uMGRkYWJlNmUwOSAxMDA2NDQK LS0tIGEvc3JjL3hkaXNwLmMKKysrIGIvc3JjL3hkaXNwLmMKQEAgLTI5Mjk0LDcgKzI5Mjk0LDEz IEBAIGd1aV9wcm9kdWNlX2dseXBocyAoc3RydWN0IGl0ICppdCkKIAogICBpZiAoZXh0cmFfbGlu ZV9zcGFjaW5nID4gMCkKICAgICB7Ci0gICAgICBpdC0+ZGVzY2VudCArPSBleHRyYV9saW5lX3Nw YWNpbmc7CisgICAgICBpZiAoISBCVkFSIChYQlVGRkVSIChpdC0+dy0+Y29udGVudHMpLCBsaW5l X3NwYWNpbmdfdmVydGljYWxfY2VudGVyKSkgeworICAgICAgICBpdC0+ZGVzY2VudCArPSBleHRy YV9saW5lX3NwYWNpbmc7CisgICAgICB9IGVsc2UgeworICAgICAgICBpbnQgc3BhY2luZyA9IGV4 dHJhX2xpbmVfc3BhY2luZyAvIDI7CisgICAgICAgIGl0LT5hc2NlbnQgKz0gc3BhY2luZzsKKyAg ICAgICAgaXQtPmRlc2NlbnQgKz0gc3BhY2luZzsKKyAgICAgIH0KICAgICAgIGlmIChleHRyYV9s aW5lX3NwYWNpbmcgPiBpdC0+bWF4X2V4dHJhX2xpbmVfc3BhY2luZykKIAlpdC0+bWF4X2V4dHJh X2xpbmVfc3BhY2luZyA9IGV4dHJhX2xpbmVfc3BhY2luZzsKICAgICB9Ci0tIAoyLjIzLjAKCg== --0000000000003c11590591729044--