It's a shame that packages included in Emacs cannot use the current test
suite. Specially in this case since the tests are very good.

I don't think there's any idea to write these in Ert since the mode is
interactive and it would require a lot of mocking and stuff. On the other
hand, there are some tricky regexes that I would never touch without good
tests.


On Sun, Aug 11, 2013 at 3:08 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 11.08.2013 14:54, Bozhidar Batsov wrote:
>
>> The interpolate functionality seems redundant to me, so I'd suggest
>> dropping it.
>>
>
> Ok, good.
>
>      Here's another issue: ruby-tools comes with a suite of tests written
>>     using ecukes, which is not included with Emacs, and would be
>>     incompatible with the current test directory layout anyway.
>>
>>     Should they be rewritten using ERT? Or do we drop them and risk
>>     divergence from upstream and code breakage?
>>
>>
>> Having ERT tests is never a bad idea. That said I don't think there will
>> be a risk of upstream divergence, since I'm pretty sure after ruby-tools
>> is merged into ruby-mode the existing project will be decommissioned.
>>
>
> It was my own understanding also, but I'd rather have confirmation from
> Johan.
>
> Then the risk is just code breakage down the line. The functionality is
> relatively simple, so maybe it won't even be a problem.
>
> To be clear:
> Would you like to port the tests to ERT yourself?
> Do you suggest we just drop them?
>