From: Johan Andersson <johan.rejeep@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Bozhidar Batsov <bozhidar@batsov.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Small improvements to ruby-mode
Date: Sun, 11 Aug 2013 17:18:41 +0200 [thread overview]
Message-ID: <CAB6RKMvJH8RQPBx-pOZA89NrbhGAmxdooyvdJ4158NiqJ5fv3w@mail.gmail.com> (raw)
In-Reply-To: <52079FC3.7010702@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
Allright, that looks fine. I think some basic tests like that would be
great to have. I try to catch everything in my tests, but that might not be
necessary. Take a look at the tests I have written and migrate the ones you
seem useful.
On Sun, Aug 11, 2013 at 4:29 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
> On 11.08.2013 17:08, Johan Andersson wrote:
>
>> It's a shame that packages included in Emacs cannot use the current test
>> suite. Specially in this case since the tests are very good.
>>
>> I don't think there's any idea to write these in Ert since the mode is
>> interactive and it would require a lot of mocking and stuff.
>>
>
> I don't think it would be that hard. For example, see
> `ruby-toggle-block-to-brace' and other tests, here:
>
> http://bzr.savannah.gnu.org/**lh/emacs/trunk/annotate/head:/**
> test/automated/ruby-mode-**tests.el#L288<http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/test/automated/ruby-mode-tests.el#L288>
>
> Sure, they don't test keybindings, but I'd say it's not the most important
> part.
>
[-- Attachment #2: Type: text/html, Size: 1596 bytes --]
next prev parent reply other threads:[~2013-08-11 15:18 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 16:00 Small improvements to ruby-mode Bozhidar Batsov
2013-06-21 19:10 ` Stefan Monnier
2013-06-21 23:31 ` Dmitry Gutov
2013-06-21 23:45 ` Glenn Morris
2013-06-22 0:12 ` Dmitry Gutov
2013-06-22 7:05 ` Bozhidar Batsov
2013-06-22 13:28 ` Dmitry Gutov
2013-06-22 15:30 ` Stefan Monnier
2013-06-23 6:20 ` Bozhidar Batsov
2013-06-23 12:30 ` Dmitry Gutov
2013-06-24 13:49 ` Bozhidar Batsov
2013-07-01 18:32 ` Dmitry Gutov
2013-07-01 21:41 ` Bozhidar Batsov
2013-07-01 21:50 ` Dmitry Gutov
[not found] ` <CAM9Zgm3Uw-TfW9aT7zdA1r=etsb26xAcW7DHJ_7=NfArFE8e5A@mail.gmail.com>
2013-07-02 18:38 ` Dmitry Gutov
2013-07-03 15:46 ` Dmitry Gutov
[not found] ` <CAM9Zgm1_Jmn7Z4ZwSkPURAFOdTCURQP-TEDeys0dR4Uqyr8mfw@mail.gmail.com>
2013-07-05 10:30 ` Dmitry Gutov
2013-07-05 11:08 ` Stefan Monnier
2013-07-05 11:55 ` Dmitry Gutov
2013-07-05 22:18 ` Stefan Monnier
2013-07-05 13:01 ` Bozhidar Batsov
2013-07-05 14:15 ` Dmitry Gutov
2013-07-06 5:31 ` Bozhidar Batsov
2013-07-06 9:37 ` Dmitry Gutov
2013-07-06 12:23 ` Bozhidar Batsov
2013-07-06 15:47 ` Dmitry Gutov
2013-07-07 21:56 ` Stefan Monnier
2013-07-07 23:22 ` Dmitry Gutov
2013-07-08 9:22 ` Stefan Monnier
2013-07-09 0:40 ` Dmitry Gutov
2013-07-09 8:50 ` Stefan Monnier
2013-07-09 12:57 ` Bozhidar Batsov
2013-07-08 9:33 ` Bozhidar Batsov
2013-07-08 9:37 ` Bozhidar Batsov
2013-07-09 1:19 ` Dmitry Gutov
2013-07-09 12:55 ` Bozhidar Batsov
2013-07-09 14:36 ` Bozhidar Batsov
2013-07-09 16:07 ` Bozhidar Batsov
2013-07-09 17:18 ` Dmitry Gutov
2013-07-10 6:23 ` Bozhidar Batsov
2013-07-09 17:09 ` Dmitry Gutov
2013-07-10 6:09 ` Bozhidar Batsov
2013-07-10 18:09 ` Dmitry Gutov
2013-07-11 11:23 ` Bozhidar Batsov
2013-07-12 20:31 ` Dmitry Gutov
[not found] ` <CAM9Zgm2NbtNkm8p+SL=kYd-u90r5ELTvJrj4rxm8_Yk5QVN4WA@mail.gmail.com>
2013-07-13 10:24 ` Bozhidar Batsov
2013-07-13 19:10 ` Dmitry Gutov
2013-07-15 13:53 ` Bozhidar Batsov
2013-07-16 13:18 ` Bozhidar Batsov
2013-07-16 14:47 ` Dmitry Gutov
2013-08-08 15:56 ` Bozhidar Batsov
2013-08-08 21:21 ` Dmitry Gutov
2013-08-08 22:47 ` Stefan Monnier
2013-08-08 23:54 ` Dmitry Gutov
2013-08-09 14:52 ` Stefan Monnier
2013-08-10 11:45 ` Dmitry Gutov
2013-08-10 13:23 ` Stefan Monnier
2013-08-11 11:54 ` Bozhidar Batsov
2013-08-11 13:08 ` Dmitry Gutov
2013-08-11 14:08 ` Johan Andersson
2013-08-11 14:29 ` Dmitry Gutov
2013-08-11 15:18 ` Johan Andersson [this message]
2013-08-11 16:56 ` Stefan Monnier
2013-08-11 20:55 ` Johan Andersson
2013-08-12 1:52 ` Stefan Monnier
2013-09-13 9:10 ` Bozhidar Batsov
2013-09-13 9:26 ` Johan Andersson
2013-09-13 13:24 ` Stefan Monnier
2013-09-13 13:27 ` Johan Andersson
2013-07-05 22:35 ` Stefan Monnier
2013-07-06 5:14 ` Bozhidar Batsov
2013-07-06 9:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB6RKMvJH8RQPBx-pOZA89NrbhGAmxdooyvdJ4158NiqJ5fv3w@mail.gmail.com \
--to=johan.rejeep@gmail.com \
--cc=bozhidar@batsov.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).