From: Vladimir Kazanov via "Emacs development discussions." <emacs-devel@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Daniele Nicolodi <daniele@grinta.net>, emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/beancount bdd71c570d 3/3: Implement xref backend
Date: Thu, 6 Jun 2024 08:47:10 +0100 [thread overview]
Message-ID: <CAAs=0-3iP6E=Kmgj0-=kOLgKQE81s_CJ=H6LR4PUxx3xVbAdUw@mail.gmail.com> (raw)
In-Reply-To: <jwvmso1n4u8.fsf-monnier+emacs@gnu.org>
Thanks Stefan!
I'll add a pull request on Github
On Mon, 3 Jun 2024 at 21:34, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > + ;; Pre Emacs-28.1, defclass was used for
> > + ;; xref-buffer-location.
> > + (pos (if (version< emacs-version "28.1")
> > + (oref loc position)
> > + (xref-buffer-location-position loc))))
>
> A significantly faster test is (< emacs-major-version 28)
>
>
> Stefan
>
--
Regards,
Vladimir Kazanov
prev parent reply other threads:[~2024-06-06 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171744476130.7473.9271118063901097030@vcs2.savannah.gnu.org>
[not found] ` <20240603195922.72477C1F9E7@vcs2.savannah.gnu.org>
2024-06-03 20:34 ` [nongnu] elpa/beancount bdd71c570d 3/3: Implement xref backend Stefan Monnier
2024-06-06 7:47 ` Vladimir Kazanov via Emacs development discussions. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAs=0-3iP6E=Kmgj0-=kOLgKQE81s_CJ=H6LR4PUxx3xVbAdUw@mail.gmail.com' \
--to=emacs-devel@gnu.org \
--cc=daniele@grinta.net \
--cc=monnier@iro.umontreal.ca \
--cc=vkazanov@inbox.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).