From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Kazanov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: ert-font-lock Date: Sun, 19 Nov 2023 09:39:01 +0000 Message-ID: References: <87v89zz4v4.fsf@posteo.net> <87v89zjmcx.fsf@yahoo.com> <83fs13mduq.fsf@gnu.org> <87r0knjj9r.fsf@yahoo.com> <87a5rbqfs8.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4450"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 19 10:40:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4eHt-0000wP-L3 for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Nov 2023 10:40:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4eGu-0004pP-1Y; Sun, 19 Nov 2023 04:39:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4eGs-0004pC-9N for emacs-devel@gnu.org; Sun, 19 Nov 2023 04:39:18 -0500 Original-Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4eGq-0004t0-NQ for emacs-devel@gnu.org; Sun, 19 Nov 2023 04:39:18 -0500 Original-Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c8790474d5so8518811fa.2 for ; Sun, 19 Nov 2023 01:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700386755; x=1700991555; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iHYL8obeTz+VCdH+qPL3T8InJ/7Ni4gxXFd+7gC6LIE=; b=bPuRHsIW1BUJnSUWD6p6vcnGum8zqo65kbezRb/J6UWXzQ+cqcHQFD3dTwEBjTMyus cgtajzm40wG9qDwOU6durSelwqaFGL6ZEqJxkiZCTgoFQJEtR9bm1kQN1QOoh1JfkuaJ PJl8Gs0N2ZNUIGkA39oaUS8ysrYh86+ThRE3RlN6F7u8Yb/WS+KcVOI1+j7B5o4L4f94 s5Ac/Nz8azSZDr8sDzPJ/l+AWZGStZPJM868a91+X0UM1chHDz7JM05c1G43o5VRVFdF rQNFNzXuHOtL+iPkQR2jdGu4Xu3fbN/2t/yKvM2qIl3bi7IvGL+VYToBu+xAOx57QOI+ 45rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700386755; x=1700991555; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iHYL8obeTz+VCdH+qPL3T8InJ/7Ni4gxXFd+7gC6LIE=; b=nrib7rENWoOGLdyMn7zMiwUNFlzJyCdr9cZ0PUICVG42Kr8c5mmxuQl211SzwHN+ms LB6/+RGS/of0LSd1ZVlNZPUggZGP4SvwyIX/VvVucqP5aPiGtgYQdqClBa27i+nmr0pf 3yTs7bgSu1/HPuAY2Qs86k/F60LbxVzuRJDPMB6vLWSng4iYZp1RDZA6qCSDoz8Zv/+O jQ5S2uUbkP3lkkSmiQyVKOR33K/9R4moA/gio9u4Q2v2hfxUCphPg+dpsPzEKJVJkfB7 aIQSfdrMV7F0IN6tfNY/1/35d10xAsn+7mtsOWg3U14f+qSY2bCk+XR4MFM32UxuyCSq Cq1Q== X-Gm-Message-State: AOJu0YzOPMBzOW7AjutAHs7BDnWoY0FMND1aMEnYOO7AioErODcq7Igs YHSDEbLWtyQ6QbtwMmN38JwJ0VxsV1vJE4CWGg== X-Google-Smtp-Source: AGHT+IHBL5u0wD3/ZLbU1hjvCx9AX3uBidplCAu1QhhquBJIztxPeTRa0OJ+JhFI3mXrJDG2fWIvktfEigJpeyv322Y= X-Received: by 2002:a2e:3a12:0:b0:2c7:4220:56f3 with SMTP id h18-20020a2e3a12000000b002c7422056f3mr2658388lja.42.1700386754411; Sun, 19 Nov 2023 01:39:14 -0800 (PST) In-Reply-To: <87a5rbqfs8.fsf@posteo.net> Received-SPF: pass client-ip=2a00:1450:4864:20::235; envelope-from=vekazanov@gmail.com; helo=mail-lj1-x235.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312960 Archived-At: Hi Philip, Thank you for taking a look at this! I've integrated most of the changes but the ones below: > + ;; Or would it be possible to define a function that calls `ert-set-test'? Sure, not a problem. But wouldn't the test implementation on this level be just a replication of the already existing ert-deftest macro? And ert-deftest, btw, does use half of cl-lib. Removing cl-incf just stops making sense. Admittedly, I don't have a bigger picture on Emacs Lisp idioms and good practices so I'll just do whatever is suggested. > + (user-error "Invalid test comment syntax at line %d. Expected a line to test before the comment line" curline)) ;is this a user error? Well, I am on the fence about this one. My line of thought was that submitting invalid test cases is very much a user error, isn't it? > + (or > + ;; skip empty lines > + (eolp) I like the trick. But on empty lines this would return t instead of only reporting comment lines. On Sat, 18 Nov 2023 at 14:47, Philip Kaludercic wrote: > > Po Lu writes: > > > Eli Zaretskii writes: > > > >> Doesn't this library require ert? if it does, cl-lib is already > >> loaded by ert. > > > > That's a disappointment, but let's not double the problem. > > The problem, as in the usage of cl-lib? You are probably referring to > the other thread about using CL in Elisp, right? > > >> But if people like cl-incf so much, we could just add incf to subr.el > >> or something. > > > > Fine by me, thanks. (Don't we have incf elsewhere in core? Or was it > > in the old cl.el?) > > That is part of cl, and is aliased to cl-incf. > > -- > Philip Kaludercic -- Regards, Vladimir Kazanov