From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Kazanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] User-defined fringe tooltips (a request for review) Date: Wed, 27 Mar 2024 12:48:38 +0000 Message-ID: References: <83sf3xgimq.fsf@gnu.org> <83plyzfoe4.fsf@gnu.org> <83plyxca0t.fsf@gnu.org> <8334vrczig.fsf@gnu.org> <86frwejkxe.fsf@gnu.org> <875xx76hnf.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18425"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 27 13:49:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpSiL-0004en-05 for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Mar 2024 13:49:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpSi6-0007OI-N8; Wed, 27 Mar 2024 08:48:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpSi5-0007Nz-7R for emacs-devel@gnu.org; Wed, 27 Mar 2024 08:48:53 -0400 Original-Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpSi3-0004GI-OT; Wed, 27 Mar 2024 08:48:52 -0400 Original-Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-51588f70d2dso7998258e87.3; Wed, 27 Mar 2024 05:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711543730; x=1712148530; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QYkbchJJZc1HafcYGNJuoj3j8qEhvQHSSApfgxpo+88=; b=WSTQ/mcyiHYd1yKPf7byWEUFHGfUZIKlTi4TpzMuBdza/YhNnEuQzUIDvM4ezx4va2 Jf/N1fwEmoPRVmbU7FeR8HMqN53UPoFgVry3l+MejNCx5pAlH7Y1IQM2LsNGfpn1oogU KwaOcSjPlpU4bTWs1LGb2x57VIewKOUhnoxafNlTsgdzn/sYKf+msFC0vqlnLP9wMV0+ j92cXrXSX1a37gGadUvNrJ+dGcKB8qS70n4CyNfxDjIgDDRSlLJ8g9pZSdNd+WI0/zxg rM29XkGROmlgniBAhPxJfiinjbiLCVkUqeZUQqOS+IhYekMcFKY5LE3NBzGCPqJsdjzw qszw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711543730; x=1712148530; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QYkbchJJZc1HafcYGNJuoj3j8qEhvQHSSApfgxpo+88=; b=jt8D0Od5RisXIudMU2rX/y8v5Ga+/Fp+LgRsWPMgWnIbYbeEbbLQ5WX2Dy8vwmEShP tSWy5BvwrvyLG5/TJmohXQ6HMk7toBmfsBnBP4bkxMt4hxmcTUC25AZmltE4CrnxnaWs 47m6MFBZ6eULjyLsaEkAMpl077gLAPxBA8i8+i4HW9x0rXRSWNGAPyPfzP44b01bwv/0 gWXzv2hfPaNlpUvM+RONWJdaF6rt+eawtmaNSenJ5O/9DD76QEtA8UZnszESdnnHH7z0 aEX6ZA+qblpJ2mVgy7CeRnG612wbblLbBYtG5Du9h3hPejvkqjeRyZeOmyXPTVIP08mK 9a4g== X-Forwarded-Encrypted: i=1; AJvYcCU2ryc+DKl79HYTbw76JTPmCj02nor+oHIZmOxoohyOfmu1BzgL4U1Wp5yCb5Ae7eNiVsMroBPe3aX9WLVU7RFqKYkP X-Gm-Message-State: AOJu0YxA7v568IfvOK6Bop8JUUkmK+F8o7kNgW08EQ48PxIdpmZknECD q0Bxr5nOFDGGDZaOzkvso9N003moe3HpF3/wJWA5uZCge+hpXsC4atsL3Ilufl/zf841QsSgO9L 2lnVN7XhZS3A4Edpm7Oqgqwfvhbbd52ddGQ== X-Google-Smtp-Source: AGHT+IEbjTGUsG/J6V5aU1aPXz9jMlDQcpueK/q7lvtVobeKqBuV1hE/SyALDHk5nz/xV0hBOwXxSg8yVW3UpAvITgY= X-Received: by 2002:ac2:4142:0:b0:515:a523:d38c with SMTP id c2-20020ac24142000000b00515a523d38cmr2753041lfi.63.1711543729373; Wed, 27 Mar 2024 05:48:49 -0700 (PDT) In-Reply-To: <875xx76hnf.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::12f; envelope-from=vekazanov@gmail.com; helo=mail-lf1-x12f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317338 Archived-At: Po, Thanks for looking at the patch! Sure, I will fix things in the final version of the patch, the code is in flux right now. On Wed, 27 Mar 2024 at 11:25, Po Lu wrote: > > There are a number of general stylistic issues with this code, viz. the > use of spaces for indentation, to columns beyond the tab width, the > presence of redundant braces in if/else statements, and that of lines > exceeding 80 columns. Please see that they are addressed before it is > installed in Emacs, and thanks in advance. -- Regards, Vladimir Kazanov