Re: [PATCH] Support for Sqlite Archive files

[Vladimir Kazanov <vekazanov@gmail.com>]

Thanks for looking into this!

On Fri, 21 Jun 2024 at 12:26, Eli Zaretskii <eliz@gnu.org> wrote:

> Thanks, but why do we need a cli utility when we have built-in SQLite
> support?  Can't we access the SQLite Archive files via that built-in
> support?  I'd prefer to have that instead of relying on external
> utility.

That's what I thought. I began exploring SQLite Archives in the
context of some other idea of mine related to buffers backed by
databases instead of files
(https://mail.gnu.org/archive/html/emacs-devel/2024-06/msg00344.html).

But it turns out that archive-mode has rather strong assumptions about
having to run external utilities. Nothing impossible but code-wise it
is just easier.

> In any case, the code you posted should at least bind
> coding-system-for-read and coding-system-for-write to utf-8 (and
> perhaps also file-name-coding-system if necessary), since AFAIU SQLite
> databases use UTF-8 encoding for text.  Suggest to try your code in a
> non-UTF-8 locale to see if it works or not.
>

Well, it works on all Linux flavours :-) Archive-mode expects default
system-wide file name encoding. I found a problem with archive file
names by forcing non utf-8 encodings.

Anyways, will fix it and try to come up with a test for the case.

>
> The doc string seems like a copy/paste mistake.

Got it.

> The version should be 31.1, I think (as Emacs 30 will start its
> release cycle very soon).

Can I make it in time for Emacs 30 by any chance?

-- 
Regards,

Vladimir Kazanov