From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Kazanov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: ert-font-lock Date: Sun, 19 Nov 2023 10:08:22 +0000 Message-ID: References: <87v89zz4v4.fsf@posteo.net> <87v89zjmcx.fsf@yahoo.com> <83fs13mduq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20197"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , philipk@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 19 11:09:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4ejo-000532-85 for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Nov 2023 11:09:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4ejI-0001IY-JH; Sun, 19 Nov 2023 05:08:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4ejH-0001IB-1A for emacs-devel@gnu.org; Sun, 19 Nov 2023 05:08:39 -0500 Original-Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4ejE-0007qk-LH; Sun, 19 Nov 2023 05:08:37 -0500 Original-Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2c594196344so43364491fa.3; Sun, 19 Nov 2023 02:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388514; x=1700993314; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3s29qjj0qtiqxCqRrJou2Ke2pp5MuhiUb6l/BodRTq0=; b=EVv85Wf9TQrGm8y/KqNa/pDvpTHL4jSVyuvZOB7BkbaNHo3FGUqMJvA/jt8Af9T7OC jTjT91jDDn86EuRZ9bPqj1CZdUmim0knfnavphsxkqLQYsOksrYNwhi879nxwOSueMsZ ZsASVNSwsVeNinr9lr59knIfZ98qIX4tb79WthDLqS6f/v7FjoP3VCSILsypI8y298Ez q800VERca/2CznjKft+q5fbHi5SJrmAEG3F/CXvEcxTzEHErox8WWEQ/tbFaTeKRV0vI /+r8BcOlmewHTqlFmTOM3frK4mOv4F4G7dFhTPL1YrWqMUyo/aJM8AvWewAMWoHB89Bo LE7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388514; x=1700993314; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3s29qjj0qtiqxCqRrJou2Ke2pp5MuhiUb6l/BodRTq0=; b=TUsYyFxv74hesTt7SMeDkTPQjkXQ1Y5Bb+1iBUcec1jTXaycdvdlfXAkA2LCONLp6s tvUTQedQZS1udqnNI6F6gOEtYhL23meGc6UMdmjliHOnRuK9yaeNFhkgbwrlZozhSrXb sdBRc4trefqQDhoXOHzwIdQrDmWZays6s5/0l15Bfmqz1agrH2GzbrGxdYwjk5ZXTBb2 inL1rBfy+Z3Mx6WINFfvU8y5Ulv796Np19CseZQh97nOHgmtsiTB7kHJmP1xBX0kGwYZ YnTwRoBSc70UULB5Xxe7MrD5uuW3ERp4SfJTOWA6LDN0As7U1IOzNa4d0uqkDuGlEipD iQnA== X-Gm-Message-State: AOJu0Ywr64s9rJwirXSMgXwqxNHDrpmH211zJGR3U8EXF2B67ON6Rwrp 2mX71CP5LbdkO7kX/viJ3euY82DC8OLV4gvJb6M/WErnIA== X-Google-Smtp-Source: AGHT+IGoirOTzrxLJiOGd0F74C/m1r9dxtJdgb5GnhUxCoxS1vUlyNCXLmSvfnZwdSxTshWT7IfSTdxr/I4l/cxxB9A= X-Received: by 2002:a2e:954a:0:b0:2b9:aa4d:3728 with SMTP id t10-20020a2e954a000000b002b9aa4d3728mr2416546ljh.29.1700388513683; Sun, 19 Nov 2023 02:08:33 -0800 (PST) In-Reply-To: <83fs13mduq.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::22a; envelope-from=vekazanov@gmail.com; helo=mail-lj1-x22a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312962 Archived-At: > I won't object to including this, FWIW. Would this require any additional changes to the way the code is structured? There were also some questions around ert-font-lock.el being similar to faceup.el. I covered these elsewhere. On Sat, 18 Nov 2023 at 12:43, Eli Zaretskii wrote: > > > From: Po Lu > > Cc: Vladimir Kazanov , emacs-devel@gnu.org > > Date: Sat, 18 Nov 2023 20:07:42 +0800 > > > > Philip Kaludercic writes: > > > > > ELPA shouls be fine. > > > > Since this is an adjunct to ERT, which is plausibly useful for the unit > > testing of Emacs fontification code itself, I think such code should be > > part of Emacs proper. > > I won't object to including this, FWIW. > > > BTW, this code requires cl-lib for a meager one macro. Please replace > > > > (cl-incf curline) > > > > with > > > > (setq curline (1+ curline)) > > > > that cl-lib might not be loaded either at compile-time or runtime. > > There is no rationale for requiring cl-lib so as to employ a single > > macro once. > > Doesn't this library require ert? if it does, cl-lib is already > loaded by ert. > > But if people like cl-incf so much, we could just add incf to subr.el > or something. -- Regards, Vladimir Kazanov