From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Kazanov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: ert-font-lock Date: Tue, 21 Nov 2023 07:43:40 +0000 Message-ID: References: <87v89zz4v4.fsf@posteo.net> <87v89zjmcx.fsf@yahoo.com> <83fs13mduq.fsf@gnu.org> <87zfz7k8ya.fsf@thelio.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16117"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Po Lu , philipk@posteo.net, emacs-devel@gnu.org To: john muhl Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 21 08:44:43 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5LR4-000415-BW for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Nov 2023 08:44:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5LQL-0002Bh-84; Tue, 21 Nov 2023 02:43:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5LQJ-0002Ax-JL for emacs-devel@gnu.org; Tue, 21 Nov 2023 02:43:55 -0500 Original-Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5LQI-0002P7-4L; Tue, 21 Nov 2023 02:43:55 -0500 Original-Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c87adce180so29225921fa.0; Mon, 20 Nov 2023 23:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700552631; x=1701157431; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IUnc9FOwKkj+y0ZEOUUSG42s/p37Y4j7nSV22dAVM5c=; b=G4fG0moQX1An1iPs94CUFTpHbixSRDBDevP8HQ5zffZ/dsvZhkWte6tbxsuaaSawc5 7gfWdPVvBaBXn7sriTHpDKeuWmeXLMRiVj7igc4ql7fivfRaa6fsPw1EoVk/HsmICYw2 YE6u1gAT4m8Yc+y/CRiTFq4NaR33gP9J8mtCw9GbFfYdHVIGclpGUImmbEXwRMVNUkBB FK34/2ulYXtZ8wwtp0taBNi+CCzka6bLJz7eRVNOZ/Nk/V5juSJ8qg4LePQx5wN6WBl3 +WRPcGcw5xnKVHhuOmlj6ECShcpkFQ+d2u1+OP8Ul/aFxQXUDxKcC4W2NN78kPzryBU4 yIyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700552631; x=1701157431; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IUnc9FOwKkj+y0ZEOUUSG42s/p37Y4j7nSV22dAVM5c=; b=oTn+6YFIdj+7j1muA2GrV7pzDnHTmYaAS1PzHiDyE2ZWU/9mlBmcsBk5lVKIG85mCb EPril01GzXY+cyKLroIzc6VeIXV4MgIo2EtrlN41HSJNFQ61+D2ZItuTknjWo1lOr/7D Is6N9oMYHIhPlbZDPkMS6v4tXApt9P6ZumEfQpfcY+WrGs9mufImDRCRAqMf2axSJnsh 0wZh2ABpn/sn5fkpRc0LjU7UD4zh+qs/onl9VffAMJ/xBNiGjaHCBKF/l2Iy9Xi3tQvs tAJijb4yfvG8JMStzqDDsiQHD4xdFbFKIth/f1/ZnoK7Ub/qzqw1XEiU9xVLOOhDl9jd CZdw== X-Gm-Message-State: AOJu0YyVEF5IWQKsZchh019c9t+DuXsuqnyoB6Q26vMKM1UEs6g4VvUt CPFKtRhc2lERwwR+gINipWfpc+dhnetRuOEkMw== X-Google-Smtp-Source: AGHT+IHsYlENQmNN+GaAQnRh2QTElV/CeIbmTfzI8sIIzbiKAYaF9IcpguXzwG/0m8I1gioin2BBjDYxpZHzW5jQqMk= X-Received: by 2002:a2e:9b85:0:b0:2c5:130c:d41e with SMTP id z5-20020a2e9b85000000b002c5130cd41emr7170855lji.29.1700552630961; Mon, 20 Nov 2023 23:43:50 -0800 (PST) In-Reply-To: <87zfz7k8ya.fsf@thelio.lan> Received-SPF: pass client-ip=2a00:1450:4864:20::22f; envelope-from=vekazanov@gmail.com; helo=mail-lj1-x22f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313096 Archived-At: On Tue, 21 Nov 2023 at 04:48, john muhl wrote: > FWIW I used it to add tests for lua-ts-mode=E2=80=99s font-lock rules. > It works well and feels to me like it would be a nice addition > to Emacs. Thanks for working on it. Hey, that's nice to hear! Can I take a look at the code? Curious about the way comment highlighting is implemented in your mode. I did test popular Emacs major modes (cc-mode and the like, python, php, etc) but few ts-based ones. And even in the pre-Tree-sitter world comment detection is rather unstable and needs custom hacks in some cases. Thanks, Vlad -- Regards, Vladimir Kazanov